| Message ID | 20250417-iio-more-timestamp-alignment-v1-1-eafac1e22318@baylibre.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | iio: more timestamp alignment | expand |
On Thu, 17 Apr 2025 11:52:33 -0500 David Lechner <dlechner@baylibre.com> wrote: > Follow the pattern of other drivers and use aligned_s64 for the > timestamp. This will ensure the struct itself it also 8-byte aligned. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > drivers/iio/adc/dln2-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c > index a1e48a756a7b519105393f77c4aebde1f2f85d50..359e26e3f5bcfe16d723f621bdfc01df2dfcf6a9 100644 > --- a/drivers/iio/adc/dln2-adc.c > +++ b/drivers/iio/adc/dln2-adc.c > @@ -466,7 +466,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p) > struct iio_dev *indio_dev = pf->indio_dev; > struct { > __le16 values[DLN2_ADC_MAX_CHANNELS]; > - int64_t timestamp_space; > + aligned_s64 timestamp_space; Bug :( So needs a fixes tag ideally. Fine to just reply with one (or I might go digging if I get time). > } data; > struct dln2_adc_get_all_vals dev_data; > struct dln2_adc *dln2 = iio_priv(indio_dev); >
On Thu, 2025-04-17 at 11:52 -0500, David Lechner wrote: > Follow the pattern of other drivers and use aligned_s64 for the > timestamp. This will ensure the struct itself it also 8-byte aligned. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- With the fixes tag: Reviewed-by: Nuno Sá <nuno.sa@analog.com> > drivers/iio/adc/dln2-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c > index > a1e48a756a7b519105393f77c4aebde1f2f85d50..359e26e3f5bcfe16d723f621bdfc01df2dfcf6a9 > 100644 > --- a/drivers/iio/adc/dln2-adc.c > +++ b/drivers/iio/adc/dln2-adc.c > @@ -466,7 +466,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p) > struct iio_dev *indio_dev = pf->indio_dev; > struct { > __le16 values[DLN2_ADC_MAX_CHANNELS]; > - int64_t timestamp_space; > + aligned_s64 timestamp_space; > } data; > struct dln2_adc_get_all_vals dev_data; > struct dln2_adc *dln2 = iio_priv(indio_dev); >
On Fri, 18 Apr 2025 09:58:04 +0100 Nuno Sá <noname.nuno@gmail.com> wrote: > On Thu, 2025-04-17 at 11:52 -0500, David Lechner wrote: > > Follow the pattern of other drivers and use aligned_s64 for the > > timestamp. This will ensure the struct itself it also 8-byte aligned. > > > > Signed-off-by: David Lechner <dlechner@baylibre.com> > > --- > > With the fixes tag: > > Reviewed-by: Nuno Sá <nuno.sa@analog.com> This one was in my series... Admittedly without a fixes tag. :( I've added a tag to that patch given I'd not pushed it out yet. Fixes: 7c0299e879dd ("iio: adc: Add support for DLN2 ADC") > > > drivers/iio/adc/dln2-adc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c > > index > > a1e48a756a7b519105393f77c4aebde1f2f85d50..359e26e3f5bcfe16d723f621bdfc01df2dfcf6a9 > > 100644 > > --- a/drivers/iio/adc/dln2-adc.c > > +++ b/drivers/iio/adc/dln2-adc.c > > @@ -466,7 +466,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p) > > struct iio_dev *indio_dev = pf->indio_dev; > > struct { > > __le16 values[DLN2_ADC_MAX_CHANNELS]; > > - int64_t timestamp_space; > > + aligned_s64 timestamp_space; > > } data; > > struct dln2_adc_get_all_vals dev_data; > > struct dln2_adc *dln2 = iio_priv(indio_dev); > > >
diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c index a1e48a756a7b519105393f77c4aebde1f2f85d50..359e26e3f5bcfe16d723f621bdfc01df2dfcf6a9 100644 --- a/drivers/iio/adc/dln2-adc.c +++ b/drivers/iio/adc/dln2-adc.c @@ -466,7 +466,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p) struct iio_dev *indio_dev = pf->indio_dev; struct { __le16 values[DLN2_ADC_MAX_CHANNELS]; - int64_t timestamp_space; + aligned_s64 timestamp_space; } data; struct dln2_adc_get_all_vals dev_data; struct dln2_adc *dln2 = iio_priv(indio_dev);
Follow the pattern of other drivers and use aligned_s64 for the timestamp. This will ensure the struct itself it also 8-byte aligned. Signed-off-by: David Lechner <dlechner@baylibre.com> --- drivers/iio/adc/dln2-adc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)