| Message ID | 20250410063754.5483-3-linux.amoon@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Exynos Thermal code improvement | expand |
On 4/10/25 07:37, Anand Moon wrote: > Remove unnecessary IS_ERR() checks for the clk_sec clock, > the clk_enable() and clk_disable() functions can handle NULL clock > pointers, so the additional checks are redundant and have been removed > to simplify the code. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > --- > v5: None > v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. > v3: improve the commit message. > --- > drivers/thermal/samsung/exynos_tmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 3657920de000..ac3b9d2c900c 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > > mutex_lock(&data->lock); > clk_enable(data->clk); > - if (!IS_ERR(data->clk_sec)) > - clk_enable(data->clk_sec); > + clk_enable(data->clk_sec); > > status = readb(data->base + EXYNOS_TMU_REG_STATUS); > if (!status) { > @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > data->tmu_clear_irqs(data); > } > > - if (!IS_ERR(data->clk_sec)) > - clk_disable(data->clk_sec); > + clk_disable(data->clk_sec); > clk_disable(data->clk); > mutex_unlock(&data->lock); > Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
On Thu, Apr 10, 2025 at 12:07:49PM +0530, Anand Moon wrote: > Remove unnecessary IS_ERR() checks for the clk_sec clock, > the clk_enable() and clk_disable() functions can handle NULL clock > pointers, so the additional checks are redundant and have been removed > to simplify the code. > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> Typo in the subject: s/exymos/exynos/ > --- > v5: None > v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. > v3: improve the commit message. > --- > drivers/thermal/samsung/exynos_tmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 3657920de000..ac3b9d2c900c 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > > mutex_lock(&data->lock); > clk_enable(data->clk); > - if (!IS_ERR(data->clk_sec)) > - clk_enable(data->clk_sec); > + clk_enable(data->clk_sec); > > status = readb(data->base + EXYNOS_TMU_REG_STATUS); > if (!status) { > @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) > data->tmu_clear_irqs(data); > } > > - if (!IS_ERR(data->clk_sec)) > - clk_disable(data->clk_sec); > + clk_disable(data->clk_sec); > clk_disable(data->clk); > mutex_unlock(&data->lock); To be replaced by devm_clk_get_enabled() ? > > -- > 2.49.0 >
Hi Daniel, On Fri, 18 Apr 2025 at 13:41, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On Thu, Apr 10, 2025 at 12:07:49PM +0530, Anand Moon wrote: > > Remove unnecessary IS_ERR() checks for the clk_sec clock, > > the clk_enable() and clk_disable() functions can handle NULL clock > > pointers, so the additional checks are redundant and have been removed > > to simplify the code. > > > > Signed-off-by: Anand Moon <linux.amoon@gmail.com> > > Typo in the subject: s/exymos/exynos/ > Thanks for your review comments. Opps, I will fix this next version it got skipped. Thanks -Anand
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 3657920de000..ac3b9d2c900c 100644 --- a/drivers/thermal/samsung/exynos_tmu.c +++ b/drivers/thermal/samsung/exynos_tmu.c @@ -258,8 +258,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) mutex_lock(&data->lock); clk_enable(data->clk); - if (!IS_ERR(data->clk_sec)) - clk_enable(data->clk_sec); + clk_enable(data->clk_sec); status = readb(data->base + EXYNOS_TMU_REG_STATUS); if (!status) { @@ -269,8 +268,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev) data->tmu_clear_irqs(data); } - if (!IS_ERR(data->clk_sec)) - clk_disable(data->clk_sec); + clk_disable(data->clk_sec); clk_disable(data->clk); mutex_unlock(&data->lock);
Remove unnecessary IS_ERR() checks for the clk_sec clock, the clk_enable() and clk_disable() functions can handle NULL clock pointers, so the additional checks are redundant and have been removed to simplify the code. Signed-off-by: Anand Moon <linux.amoon@gmail.com> --- v5: None v4: drop IE_ERR() for clk_unprepare() as its handle in earlier code. v3: improve the commit message. --- drivers/thermal/samsung/exynos_tmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)