| Message ID | 1343092554-17734-1-git-send-email-yeohchunyeow@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Chun-Yeow, On Mon, Jul 23, 2012 at 6:15 PM, Chun-Yeow Yeoh <yeohchunyeow@gmail.com> wrote: > Rate control statistic is flushed whenever the mesh beacon > is received. This may not optimizes the performance of rate > control algorithm. This patch ensures that we return early > from mesh_peer_init if the plink_state is ESTAB. Thus, avoid > calling the rate_control_rate_init again for established mesh > STA. > > Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com> > --- > v2: simplify the logic checking (Thomas Pedersen) > v3: updating the sta last rx activity (Thomas Pedersen) > > net/mac80211/mesh_plink.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c > index 4256859..4f5740e 100644 > --- a/net/mac80211/mesh_plink.c > +++ b/net/mac80211/mesh_plink.c > @@ -360,6 +360,12 @@ static struct sta_info *mesh_peer_init(struct ieee80211_sub_if_data *sdata, > } > > spin_lock_bh(&sta->lock); > + if (sta->plink_state == NL80211_PLINK_ESTAB) { > + sta->last_rx = jiffies; > + spin_unlock_bh(&sta->lock); > + return sta; > + } > + > sta->last_rx = jiffies; You should avoid duplicating this assignment. Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Thomas >> sta->last_rx = jiffies; > > You should avoid duplicating this assignment. I think that we should also update the sta->last_rx if the sta->plink_state is not NL80211_PLINK_ESTAB, am I right? Please advice. Thanks Regards, Chun-Yeow -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Chun-Yeow, On Tue, Jul 24, 2012 at 1:40 PM, Yeoh Chun-Yeow <yeohchunyeow@gmail.com> wrote: > Hi, Thomas > >>> sta->last_rx = jiffies; >> >> You should avoid duplicating this assignment. > > I think that we should also update the sta->last_rx if the > sta->plink_state is not NL80211_PLINK_ESTAB, am I right? The point Thomas is making is that this assignment happens both when the if statement's condition is true and when it's false. So you could remove it from the if statement and move the one that's after the if statement above the if statement and the code would be functionally equivalent and cleaner. Thanks,
Hi, Julian > So you could remove it from the if statement and move the one that's > after the if statement above the if statement and the code would be > functionally equivalent and cleaner. Noted. Thanks Regards, Chun-Yeow -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac80211/mesh_plink.c b/net/mac80211/mesh_plink.c index 4256859..4f5740e 100644 --- a/net/mac80211/mesh_plink.c +++ b/net/mac80211/mesh_plink.c @@ -360,6 +360,12 @@ static struct sta_info *mesh_peer_init(struct ieee80211_sub_if_data *sdata, } spin_lock_bh(&sta->lock); + if (sta->plink_state == NL80211_PLINK_ESTAB) { + sta->last_rx = jiffies; + spin_unlock_bh(&sta->lock); + return sta; + } + sta->last_rx = jiffies; sta->sta.supp_rates[band] = rates; if (elems->ht_cap_elem &&
Rate control statistic is flushed whenever the mesh beacon is received. This may not optimizes the performance of rate control algorithm. This patch ensures that we return early from mesh_peer_init if the plink_state is ESTAB. Thus, avoid calling the rate_control_rate_init again for established mesh STA. Signed-off-by: Chun-Yeow Yeoh <yeohchunyeow@gmail.com> --- v2: simplify the logic checking (Thomas Pedersen) v3: updating the sta last rx activity (Thomas Pedersen) net/mac80211/mesh_plink.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)