| Message ID | 1343076052-27312-10-git-send-email-marex@denx.de (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
Hello. On 07/24/2012 12:40 AM, Marek Vasut wrote: > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Attila Kinali <attila@kinali.ch> > Cc: Chris Ball <cjb@laptop.org> > CC: Dong Aisheng <b29396@freescale.com> > Cc: Fabio Estevam <fabio.estevam@freescale.com> > Cc: Grant Likely <grant.likely@secretlab.ca> > Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org> > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> > CC: Shawn Guo <shawn.guo@linaro.org> > --- > Documentation/devicetree/bindings/spi/mxs-spi.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt b/Documentation/devicetree/bindings/spi/mxs-spi.txt > new file mode 100644 > index 0000000..f1263a9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.txt > @@ -0,0 +1,18 @@ > +* Freescale MX233/MX28 SSP/SPI > + > +Required properties: > +- compatible: Should be "fsl,<soc>-spi", where soc is "imx23" or "imx28" > +- reg: Offset and length of the register set for the device > +- interrupts: Should contain SSP interrupts (error irq first, dma irq second) > +- fsl,ssp-dma-channel: APBX DMA channel for the SSP > + > +Example: > + > +ssp0: ssp@80010000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx28-spi"; > + reg = <0x80010000 2000>; Not 0x2000? WBR, Sergei ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
Dear Sergei Shtylyov, > Hello. > > On 07/24/2012 12:40 AM, Marek Vasut wrote: > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Attila Kinali <attila@kinali.ch> > > Cc: Chris Ball <cjb@laptop.org> > > CC: Dong Aisheng <b29396@freescale.com> > > Cc: Fabio Estevam <fabio.estevam@freescale.com> > > Cc: Grant Likely <grant.likely@secretlab.ca> > > Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org> > > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> > > CC: Shawn Guo <shawn.guo@linaro.org> > > --- > > > > Documentation/devicetree/bindings/spi/mxs-spi.txt | 18 > > ++++++++++++++++++ 1 file changed, 18 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt > > > > diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt > > b/Documentation/devicetree/bindings/spi/mxs-spi.txt new file mode 100644 > > index 0000000..f1263a9 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/spi/mxs-spi.txt > > @@ -0,0 +1,18 @@ > > +* Freescale MX233/MX28 SSP/SPI > > + > > +Required properties: > > +- compatible: Should be "fsl,<soc>-spi", where soc is "imx23" or "imx28" > > +- reg: Offset and length of the register set for the device > > +- interrupts: Should contain SSP interrupts (error irq first, dma irq > > second) +- fsl,ssp-dma-channel: APBX DMA channel for the SSP > > + > > +Example: > > + > > +ssp0: ssp@80010000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "fsl,imx28-spi"; > > + reg = <0x80010000 2000>; > > Not 0x2000? This is actually not the first place I was curious about in the imx28 DTS ... yes, the size is 0x2000, but "2000" as is is used in multiple places across imx28. Shawn? > WBR, Sergei Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
On Tue, Jul 24, 2012 at 09:43:48PM +0200, Marek Vasut wrote: > This is actually not the first place I was curious about in the imx28 DTS ... > yes, the size is 0x2000, but "2000" as is is used in multiple places across > imx28. Shawn? > It seems that I overlooked the problem when it got introduced at the first place. I will send a patch to fix it. Thanks for spotting it.
Dear Shawn Guo, > On Tue, Jul 24, 2012 at 09:43:48PM +0200, Marek Vasut wrote: > > This is actually not the first place I was curious about in the imx28 DTS > > ... yes, the size is 0x2000, but "2000" as is is used in multiple places > > across imx28. Shawn? > > It seems that I overlooked the problem when it got introduced at the > first place. I will send a patch to fix it. Thanks for spotting it. Ok good. Mark, do you want me to send a V2 of only this particular patch or whole set (I think that's overkill)? Best regards, Marek Vasut ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
diff --git a/Documentation/devicetree/bindings/spi/mxs-spi.txt b/Documentation/devicetree/bindings/spi/mxs-spi.txt new file mode 100644 index 0000000..f1263a9 --- /dev/null +++ b/Documentation/devicetree/bindings/spi/mxs-spi.txt @@ -0,0 +1,18 @@ +* Freescale MX233/MX28 SSP/SPI + +Required properties: +- compatible: Should be "fsl,<soc>-spi", where soc is "imx23" or "imx28" +- reg: Offset and length of the register set for the device +- interrupts: Should contain SSP interrupts (error irq first, dma irq second) +- fsl,ssp-dma-channel: APBX DMA channel for the SSP + +Example: + +ssp0: ssp@80010000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "fsl,imx28-spi"; + reg = <0x80010000 2000>; + interrupts = <96 82>; + fsl,ssp-dma-channel = <0>; +};
Signed-off-by: Marek Vasut <marex@denx.de> Cc: Attila Kinali <attila@kinali.ch> Cc: Chris Ball <cjb@laptop.org> CC: Dong Aisheng <b29396@freescale.com> Cc: Fabio Estevam <fabio.estevam@freescale.com> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: Linux ARM kernel <linux-arm-kernel@lists.infradead.org> Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> CC: Shawn Guo <shawn.guo@linaro.org> --- Documentation/devicetree/bindings/spi/mxs-spi.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/mxs-spi.txt