diff mbox

[1/1] DSPBRIDGE Fix for image autoload

Message ID EAF47CD23C76F840A9E7FCE10091EFAB02A8F2BED3@dbde02.ent.ti.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Gupta, Ramesh March 12, 2009, 5:32 a.m. UTC
From fbbf5c9c308c2e1e90e70c57a48798c5d05a6b1d Mon Sep 17 00:00:00 2001
From: Ramesh Gupta <x0023949@ti.com>
Date: Thu, 12 Mar 2009 10:48:08 +0530
Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload.

This fixes the issue with the image autoloading while
installing the bridgedriver with install param base_img

Signed-off-by: Ramesh Gupta G <grgupta@ti.com>
---
 drivers/dsp/bridge/rmgr/drv_interface.c |   28 ++++++++++++++--------------
 1 files changed, 14 insertions(+), 14 deletions(-)

Comments

Nishanth Menon March 12, 2009, 5:48 a.m. UTC | #1
Ramesh,
> -----Original Message-----
> From: Gupta, Ramesh
> Sent: Thursday, March 12, 2009 7:32 AM
> To: linux-omap@vger.kernel.org
> Cc: Menon, Nishanth; Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> From fbbf5c9c308c2e1e90e70c57a48798c5d05a6b1d Mon Sep 17 00:00:00 2001
> From: Ramesh Gupta <x0023949@ti.com>
> Date: Thu, 12 Mar 2009 10:48:08 +0530
> Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload.
> 
> This fixes the issue with the image autoloading while
> installing the bridgedriver with install param base_img
What is your code base? Omapzoom or gitorious? Could you send us the link to the git log of the branch you are sending this for?

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gupta, Ramesh March 12, 2009, 6 a.m. UTC | #2
Nishant,
 

> -----Original Message-----
> From: Menon, Nishanth 
> Sent: Thursday, March 12, 2009 11:19 AM
> To: Gupta, Ramesh; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> Ramesh,
> > -----Original Message-----
> > From: Gupta, Ramesh
> > Sent: Thursday, March 12, 2009 7:32 AM
> > To: linux-omap@vger.kernel.org
> > Cc: Menon, Nishanth; Kanigeri, Hari; Guzman Lugo, Fernando
> > Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > 
> > From fbbf5c9c308c2e1e90e70c57a48798c5d05a6b1d Mon Sep 17 
> 00:00:00 2001
> > From: Ramesh Gupta <x0023949@ti.com>
> > Date: Thu, 12 Mar 2009 10:48:08 +0530
> > Subject: [PATCH 1/1] DSPBRIDGE Fix for image autoload.
> > 
> > This fixes the issue with the image autoloading while 
> installing the 
> > bridgedriver with install param base_img
> What is your code base? Omapzoom or gitorious? Could you send 
> us the link to the git log of the branch you are sending this for?

I have tried this on linux-omap pm branch . This can be applied on top of my DVFS
Patches earlier.

My git log shows 


commit fbbf5c9c308c2e1e90e70c57a48798c5d05a6b1d
Author: Ramesh Gupta <x0023949@linuxomap.(none)>
Date:   Thu Mar 12 10:48:08 2009 +0530

    DSPBRIDGE Fix for image autoload.

    This fixes the issue with the image autoloading while
    installing the bridgedriver with install param base_img

    Signed-off-by: Ramesh Gupta G <grgupta@ti.com>

commit a384d11047130358223a24080d58e57dcef92550
Author: Ramesh Gupta <x0023949@linuxomap.(none)>
Date:   Wed Mar 11 19:34:43 2009 +0530

    DVFS OFF MODE Support.

commit 4f422d583e2e233c19eb20754b8cfad6ed9e460a
Author: Nayak, Rajendra <rnayak@ti.com>
Date:   Fri Feb 13 11:30:57 2009 +0530

    OMAP3: PM: Update voltage levels for OPP1/2 on VDD1/2

    This patch updates the voltage levels for VDD1 OPP1/2 and
    VDD2 OPP1/2 according to the latest operating condition
    addendum for 3430.

    The new voltage levels at various OPP's for VDD1/2 are as below

    VDD1 OPP1 0.975v
    VDD1 OPP2 1.050v
    VDD1 OPP3 1.200v
    VDD1 OPP4 1.270v
    VDD1 OPP5 1.350v

    VDD2 OPP1 0.975v
    VDD2 OPP2 1.050v
    VDD2 OPP3 1.150v

    The patch applies on the latest pm head and is validated on 3430SDP.

    Signed-off-by: Rajendra Nayak <rnayak@ti.com>

commit 65d02c2c7fe676369b7162459feec60268c7f4ba
Author: Kevin Hilman <khilman@deeprootsystems.com>
Date:   Fri Feb 13 11:07:18 2009 -0800

    OMAP3: PM: fix compile warning when !CONFIG_SUSPEND

    Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>


Please let me know if you see any issues in applying this.


Regards
Ramesh Gupta G--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nishanth Menon March 12, 2009, 7:39 a.m. UTC | #3
> -----Original Message-----
> From: Gupta, Ramesh
> Sent: Thursday, March 12, 2009 8:01 AM
> To: Menon, Nishanth; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> I have tried this on linux-omap pm branch . This can be applied on top of
> my DVFS
> Patches earlier.
> 
Your patch does not apply clean :(
$ wget -O ramesh.auto.patch "http://marc.info/?l=linux-omap&m=123683598308417&q=raw"
$ vim ramesh.auto.patch (edited to remove the linux-omap trailer)
$ patch -p1<./ramesh.auto.patch --dry-run
patching file drivers/dsp/bridge/rmgr/drv_interface.c
Hunk #1 succeeded at 400 (offset -5 lines).
Hunk #2 succeeded at 408 (offset -5 lines).
Hunk #3 succeeded at 450 with fuzz 1 (offset -5 lines).
Hunk #4 succeeded at 470 (offset -5 lines).
Hunk #5 succeeded at 655 (offset -5 lines).

Could you rebase your patch against the following:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
cd linux-omap-2.6.git
git checkout -b pm --track origin/pm
git fetch git://gitorious.org/lk/mainline.git tidspbridge-pm:tidspbridge-pm
git checkout tidspbridge-pm
git merge pm

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nishanth Menon March 12, 2009, 7:52 a.m. UTC | #4
> -----Original Message-----
> From: Menon, Nishanth
> Sent: Thursday, March 12, 2009 9:39 AM
> To: Gupta, Ramesh; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> > -----Original Message-----
> > From: Gupta, Ramesh
> > Sent: Thursday, March 12, 2009 8:01 AM
> > To: Menon, Nishanth; linux-omap@vger.kernel.org
> > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> >
> > I have tried this on linux-omap pm branch . This can be applied on top
> of
> > my DVFS
> > Patches earlier.
> >
> Your patch does not apply clean :(
> $ wget -O ramesh.auto.patch "http://marc.info/?l=linux-
> omap&m=123683598308417&q=raw"
> $ vim ramesh.auto.patch (edited to remove the linux-omap trailer)
> $ patch -p1<./ramesh.auto.patch --dry-run
> patching file drivers/dsp/bridge/rmgr/drv_interface.c
> Hunk #1 succeeded at 400 (offset -5 lines).
> Hunk #2 succeeded at 408 (offset -5 lines).
> Hunk #3 succeeded at 450 with fuzz 1 (offset -5 lines).
> Hunk #4 succeeded at 470 (offset -5 lines).
> Hunk #5 succeeded at 655 (offset -5 lines).
> 
> Could you rebase your patch against the following:
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-
> 2.6.git
> cd linux-omap-2.6.git
> git checkout -b pm --track origin/pm
> git fetch git://gitorious.org/lk/mainline.git tidspbridge-pm:tidspbridge-
> pm
> git checkout tidspbridge-pm
> git merge pm


And the patch does not work :(

# insmod  ./bridgedriver.ko phys_mempool_base=0x87000000  phys_mempool_size=0x600000 base_img=dsp/baseimage.dof
<4>------------[ cut here ]------------
------------[ cut here ]------------
<4>WARNING: at arch/arm/plat-omap/omap-pm-srf.c:241 omap_pm_cpu_set_freq+0x20/0x44()
WARNING: at arch/arm/plat-omap/omap-pm-srf.c:241 omap_pm_cpu_set_freq+0x20/0x44()
Modules linked in:Modules linked in: bridgedriver(+) bridgedriver(+) [last unloaded: bridgedriver] [last unloaded: bridgedriver]

[<c0031e20>] [<c0031e20>] (dump_stack+0x0/0x14) (dump_stack+0x0/0x14) from [<c00562c8>] from [<c00562c8>] (warn_on_slowpath+0x4c/0x68)
(warn_on_slowpath+0x4c/0x68)
[<c005627c>] [<c005627c>] (warn_on_slowpath+0x0/0x68) (warn_on_slowpath+0x0/0x68) from [<c0043c44>] from [<c0043c44>] (omap_pm_cpu_set_freq+0x20/0x44)
(omap_pm_cpu_set_freq+0x20/0x44)
 r6:00008000 r6:00008000 r5:80008010 r5:80008010 r4:c3dc5b08 r4:c3dc5b08

[<c0043c24>] [<c0043c24>] (omap_pm_cpu_set_freq+0x0/0x44) (omap_pm_cpu_set_freq+0x0/0x44) from [<bf046544>] from [<bf046544>] (PROC_Load+0x2c8/0x40c [bridgedriver])
(PROC_Load+0x2c8/0x40c [bridgedriver])
[<bf04627c>] [<bf04627c>] (PROC_Load+0x0/0x40c [bridgedriver]) (PROC_Load+0x0/0x40c [bridgedriver]) from [<bf046ac0>] from [<bf046ac0>] (PROC_AutoStart+0x174/0x1c4 [bridgedriver)
(PROC_AutoStart+0x174/0x1c4 [bridgedriver])
[<bf04694c>] [<bf04694c>] (PROC_AutoStart+0x0/0x1c4 [bridgedriver]) (PROC_AutoStart+0x0/0x1c4 [bridgedriver]) from [<bf03add0>] from [<bf03add0>] (WCD_InitComplete2+0x58/0x8c [b)
(WCD_InitComplete2+0x58/0x8c [bridgedriver])
 r7:00000000 r7:00000000 r6:c3dc5dd4 r6:c3dc5dd4 r5:00008000 r5:00008000 r4:c3981600 r4:c3981600

[<bf03ad78>] [<bf03ad78>] (WCD_InitComplete2+0x0/0x8c [bridgedriver]) (WCD_InitComplete2+0x0/0x8c [bridgedriver]) from [<bf0487e0>] from [<bf0487e0>] (DSP_Init+0xd8/0xf0 [bridge)
(DSP_Init+0xd8/0xf0 [bridgedriver])
 r5:c3dc5c99 r5:c3dc5c99 r4:00008000 r4:00008000

[<bf048708>] [<bf048708>] (DSP_Init+0x0/0xf0 [bridgedriver]) (DSP_Init+0x0/0xf0 [bridgedriver]) from [<bf05d33c>] from [<bf05d33c>] (bridge_init+0x33c/0x3ec [bridgedriver])
(bridge_init+0x33c/0x3ec [bridgedriver])
 r6:bf05a288 r6:bf05a288 r5:bf05ab88 r5:bf05ab88 r4:bf05ab88 r4:bf05ab88

[<bf05d000>] [<bf05d000>] (bridge_init+0x0/0x3ec [bridgedriver]) (bridge_init+0x0/0x3ec [bridgedriver]) from [<c002d2d4>] from [<c002d2d4>] (do_one_initcall+0x64/0x198)
(do_one_initcall+0x64/0x198)
 r8:c002df28 r8:c002df28 r7:00000000 r7:00000000 r6:4023a000 r6:4023a000 r5:bf05a520 r5:bf05a520 r4:c03aa340 r4:c03aa340

[<c002d270>] [<c002d270>] (do_one_initcall+0x0/0x198) (do_one_initcall+0x0/0x198) from [<c0078cd4>] from [<c0078cd4>] (sys_init_module+0x98/0x188)
(sys_init_module+0x98/0x188)
[<c0078c3c>] [<c0078c3c>] (sys_init_module+0x0/0x188) (sys_init_module+0x0/0x188) from [<c002dd80>] from [<c002dd80>] (ret_fast_syscall+0x0/0x2c)
(ret_fast_syscall+0x0/0x2c)
 r7:00000080 r7:00000080 r6:00000000 r6:00000000 r5:0000000b r5:0000000b r4:00000000 r4:00000000

<4>---[ end trace 7a555f9f02586741 ]---
---[ end trace 7a555f9f02586741 ]---
<4>------------[ cut here ]------------
------------[ cut here ]------------
<4>WARNING: at arch/arm/plat-omap/omap-pm-srf.c:241 omap_pm_cpu_set_freq+0x20/0x44()
WARNING: at arch/arm/plat-omap/omap-pm-srf.c:241 omap_pm_cpu_set_freq+0x20/0x44()
Modules linked in:Modules linked in: bridgedriver(+) bridgedriver(+) [last unloaded: bridgedriver] [last unloaded: bridgedriver]

[<c0031e20>] [<c0031e20>] (dump_stack+0x0/0x14) (dump_stack+0x0/0x14) from [<c00562c8>] from [<c00562c8>] (warn_on_slowpath+0x4c/0x68)
(warn_on_slowpath+0x4c/0x68)
[<c005627c>] [<c005627c>] (warn_on_slowpath+0x0/0x68) (warn_on_slowpath+0x0/0x68) from [<c0043c44>] from [<c0043c44>] (omap_pm_cpu_set_freq+0x20/0x44)
(omap_pm_cpu_set_freq+0x20/0x44)
 r6:00008000 r6:00008000 r5:80008010 r5:80008010 r4:00008000 r4:00008000

[<c0043c24>] [<c0043c24>] (omap_pm_cpu_set_freq+0x0/0x44) (omap_pm_cpu_set_freq+0x0/0x44) from [<bf046580>] from [<bf046580>] (PROC_Load+0x304/0x40c [bridgedriver])
(PROC_Load+0x304/0x40c [bridgedriver])
[<bf04627c>] [<bf04627c>] (PROC_Load+0x0/0x40c [bridgedriver]) (PROC_Load+0x0/0x40c [bridgedriver]) from [<bf046ac0>] from [<bf046ac0>] (PROC_AutoStart+0x174/0x1c4 [bridgedriver)
(PROC_AutoStart+0x174/0x1c4 [bridgedriver])
[<bf04694c>] [<bf04694c>] (PROC_AutoStart+0x0/0x1c4 [bridgedriver]) (PROC_AutoStart+0x0/0x1c4 [bridgedriver]) from [<bf03add0>] from [<bf03add0>] (WCD_InitComplete2+0x58/0x8c [b)
(WCD_InitComplete2+0x58/0x8c [bridgedriver])
 r7:00000000 r7:00000000 r6:c3dc5dd4 r6:c3dc5dd4 r5:00008000 r5:00008000 r4:c3981600 r4:c3981600

[<bf03ad78>] [<bf03ad78>] (WCD_InitComplete2+0x0/0x8c [bridgedriver]) (WCD_InitComplete2+0x0/0x8c [bridgedriver]) from [<bf0487e0>] from [<bf0487e0>] (DSP_Init+0xd8/0xf0 [bridge)
(DSP_Init+0xd8/0xf0 [bridgedriver])
 r5:c3dc5c99 r5:c3dc5c99 r4:00008000 r4:00008000

[<bf048708>] [<bf048708>] (DSP_Init+0x0/0xf0 [bridgedriver]) (DSP_Init+0x0/0xf0 [bridgedriver]) from [<bf05d33c>] from [<bf05d33c>] (bridge_init+0x33c/0x3ec [bridgedriver])
(bridge_init+0x33c/0x3ec [bridgedriver])
 r6:bf05a288 r6:bf05a288 r5:bf05ab88 r5:bf05ab88 r4:bf05ab88 r4:bf05ab88

[<bf05d000>] [<bf05d000>] (bridge_init+0x0/0x3ec [bridgedriver]) (bridge_init+0x0/0x3ec [bridgedriver]) from [<c002d2d4>] from [<c002d2d4>] (do_one_initcall+0x64/0x198)
(do_one_initcall+0x64/0x198)
 r8:c002df28 r8:c002df28 r7:00000000 r7:00000000 r6:4023a000 r6:4023a000 r5:bf05a520 r5:bf05a520 r4:c03aa340 r4:c03aa340

[<c002d270>] [<c002d270>] (do_one_initcall+0x0/0x198) (do_one_initcall+0x0/0x198) from [<c0078cd4>] from [<c0078cd4>] (sys_init_module+0x98/0x188)
(sys_init_module+0x98/0x188)
[<c0078c3c>] [<c0078c3c>] (sys_init_module+0x0/0x188) (sys_init_module+0x0/0x188) from [<c002dd80>] from [<c002dd80>] (ret_fast_syscall+0x0/0x2c)
(ret_fast_syscall+0x0/0x2c)
 r7:00000080 r7:00000080 r6:00000000 r6:00000000 r5:0000000b r5:0000000b r4:00000000 r4:00000000

<4>---[ end trace 7a555f9f02586741 ]---
---[ end trace 7a555f9f02586741 ]---
# <4>SR1: VDD autocomp is not active
SR1: VDD autocomp is not active
<4>SR1: VDD autocomp is not active
SR1: VDD autocomp is not active

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gupta, Ramesh March 12, 2009, 8:31 a.m. UTC | #5
Nishant,
 

> -----Original Message-----
> From: Menon, Nishanth 
> Sent: Thursday, March 12, 2009 1:22 PM
> To: Gupta, Ramesh; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> > -----Original Message-----
> > From: Menon, Nishanth
> > Sent: Thursday, March 12, 2009 9:39 AM
> > To: Gupta, Ramesh; linux-omap@vger.kernel.org
> > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > 
> > > -----Original Message-----
> > > From: Gupta, Ramesh
> > > Sent: Thursday, March 12, 2009 8:01 AM
> > > To: Menon, Nishanth; linux-omap@vger.kernel.org
> > > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > >
> > > I have tried this on linux-omap pm branch . This can be 
> applied on 
> > > top
> > of
> > > my DVFS
> > > Patches earlier.
> > >
> > Your patch does not apply clean :(
> > $ wget -O ramesh.auto.patch "http://marc.info/?l=linux- 
> > omap&m=123683598308417&q=raw"
> > $ vim ramesh.auto.patch (edited to remove the linux-omap trailer) $ 
> > patch -p1<./ramesh.auto.patch --dry-run patching file 
> > drivers/dsp/bridge/rmgr/drv_interface.c
> > Hunk #1 succeeded at 400 (offset -5 lines).
> > Hunk #2 succeeded at 408 (offset -5 lines).
> > Hunk #3 succeeded at 450 with fuzz 1 (offset -5 lines).
> > Hunk #4 succeeded at 470 (offset -5 lines).
> > Hunk #5 succeeded at 655 (offset -5 lines).
> > 
> > Could you rebase your patch against the following:
> > git clone 
> > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-
> > 2.6.git
> > cd linux-omap-2.6.git
> > git checkout -b pm --track origin/pm
> > git fetch git://gitorious.org/lk/mainline.git 
> > tidspbridge-pm:tidspbridge- pm git checkout tidspbridge-pm 
> git merge 
> > pm
> 
> 
> And the patch does not work :(

What is your code base? It does work for me. 

# insmod ./bridgedriver.ko phys_mempool_base=0x87000000 phys_mempool_size=0x6000
00 shm_size=0x400000 base_img=./baseimage.dof
# <4>SR1: VDD autocomp is not active
SR1: VDD autocomp is not active
<4>SR1: VDD autocomp is not active
SR1: VDD autocomp is not active

# insmod ./bridgedriver.ko phys_mempool_base=0x87000000 phys_mempool_size=0x6000
00 shm_size=0x400000 base_img=./b

# rmmod bridgedriver.ko

# insmod ./bridgedriver.ko phys_mempool_base=0x87000000 phys_mempool_size=0x6000
00 shm_size=0x400000 base_img=./ddspbase_tiomap3430.dof64P
# ./ping.out 3
DSP device detected !!
DSPNodeCreate succeeded
DSPNode_registerNotify succeeded
DSPNode_run succeeded
Ping: Id 1.000000 Msg 0.000000 Mem 15384.000000
Ping: Id 1.000000 Msg 1.000000 Mem 15384.000000
Ping: Id 1.000000 Msg 2.000000 Mem 15384.000000

I will rebase the patch as you suggested.

Regards
Ramesh Gupta G --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nishanth Menon March 12, 2009, 8:42 a.m. UTC | #6
> -----Original Message-----
> From: Gupta, Ramesh
> Sent: Thursday, March 12, 2009 10:31 AM
> To: Menon, Nishanth; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> >
> > > -----Original Message-----
> > > From: Menon, Nishanth
> > > Sent: Thursday, March 12, 2009 9:39 AM
> > > To: Gupta, Ramesh; linux-omap@vger.kernel.org
> > > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > >
> > > > -----Original Message-----
> > > > From: Gupta, Ramesh
> > > > Sent: Thursday, March 12, 2009 8:01 AM
> > > > To: Menon, Nishanth; linux-omap@vger.kernel.org
> > > > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > > > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > > >
> > > > I have tried this on linux-omap pm branch . This can be
> > applied on
> > > > top
> > > of
> > > > my DVFS
> > > > Patches earlier.
> > > >
> > > Your patch does not apply clean :(
> > > $ wget -O ramesh.auto.patch "http://marc.info/?l=linux-
> > > omap&m=123683598308417&q=raw"
> > > $ vim ramesh.auto.patch (edited to remove the linux-omap trailer) $
> > > patch -p1<./ramesh.auto.patch --dry-run patching file
> > > drivers/dsp/bridge/rmgr/drv_interface.c
> > > Hunk #1 succeeded at 400 (offset -5 lines).
> > > Hunk #2 succeeded at 408 (offset -5 lines).
> > > Hunk #3 succeeded at 450 with fuzz 1 (offset -5 lines).
> > > Hunk #4 succeeded at 470 (offset -5 lines).
> > > Hunk #5 succeeded at 655 (offset -5 lines).
> > >
> > > Could you rebase your patch against the following:
> > > git clone
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-
> > > 2.6.git
> > > cd linux-omap-2.6.git
> > > git checkout -b pm --track origin/pm
> > > git fetch git://gitorious.org/lk/mainline.git
> > > tidspbridge-pm:tidspbridge- pm git checkout tidspbridge-pm
> > git merge
> > > pm
> >
> >
> > And the patch does not work :(
> 
> What is your code base? It does work for me.

As stated above:
git clone git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
cd linux-omap-2.6.git
git checkout -b pm --track origin/pm
git fetch git://gitorious.org/lk/mainline.gittidspbridge-pm:tidspbridge- pm git checkout tidspbridge-pm
git merge pm

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Gupta, Ramesh March 12, 2009, 11:48 a.m. UTC | #7
Nishant,
 

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org 
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Gupta, Ramesh
> Sent: Thursday, March 12, 2009 2:01 PM
> To: Menon, Nishanth; linux-omap@vger.kernel.org
> Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> 
> Nishant,
>  
> 
> > -----Original Message-----
> > From: Menon, Nishanth
> > Sent: Thursday, March 12, 2009 1:22 PM
> > To: Gupta, Ramesh; linux-omap@vger.kernel.org
> > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > 
> > > -----Original Message-----
> > > From: Menon, Nishanth
> > > Sent: Thursday, March 12, 2009 9:39 AM
> > > To: Gupta, Ramesh; linux-omap@vger.kernel.org
> > > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > > 
> > > > -----Original Message-----
> > > > From: Gupta, Ramesh
> > > > Sent: Thursday, March 12, 2009 8:01 AM
> > > > To: Menon, Nishanth; linux-omap@vger.kernel.org
> > > > Cc: Kanigeri, Hari; Guzman Lugo, Fernando
> > > > Subject: RE: [PATCH 1/1] DSPBRIDGE Fix for image autoload
> > > >
> > > > I have tried this on linux-omap pm branch . This can be
> > applied on
> > > > top
> > > of
> > > > my DVFS
> > > > Patches earlier.
> > > >
> > > Your patch does not apply clean :(
> > > $ wget -O ramesh.auto.patch "http://marc.info/?l=linux- 
> > > omap&m=123683598308417&q=raw"
> > > $ vim ramesh.auto.patch (edited to remove the linux-omap 
> trailer) $ 
> > > patch -p1<./ramesh.auto.patch --dry-run patching file 
> > > drivers/dsp/bridge/rmgr/drv_interface.c
> > > Hunk #1 succeeded at 400 (offset -5 lines).
> > > Hunk #2 succeeded at 408 (offset -5 lines).
> > > Hunk #3 succeeded at 450 with fuzz 1 (offset -5 lines).
> > > Hunk #4 succeeded at 470 (offset -5 lines).
> > > Hunk #5 succeeded at 655 (offset -5 lines).
> > > 
> > > Could you rebase your patch against the following:
> > > git clone
> > > git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-
> > > 2.6.git
> > > cd linux-omap-2.6.git
> > > git checkout -b pm --track origin/pm git fetch 
> > > git://gitorious.org/lk/mainline.git
> > > tidspbridge-pm:tidspbridge- pm git checkout tidspbridge-pm
> > git merge
> > > pm
> > 
> > 
> > And the patch does not work :(

There was a typo in previous patch I am sending an updated patch.

Thanks
Ramesh Gupta G --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c
index 9c82ef4..c5c9ee5 100755
--- a/drivers/dsp/bridge/rmgr/drv_interface.c
+++ b/drivers/dsp/bridge/rmgr/drv_interface.c
@@ -405,7 +405,7 @@  static int __init bridge_init(void)
 		REG_SetValue(NULL, NULL, AUTOSTART, REG_DWORD, (u8 *)&temp,
 			    sizeof(temp));
 		REG_SetValue(NULL, NULL, DEFEXEC, REG_SZ, (u8 *)base_img,
-                           strlen(base_img) + 1);
+						strlen(base_img) + 1);
 	} else {
 		temp = false;
 		REG_SetValue(NULL, NULL, AUTOSTART, REG_DWORD, (u8 *)&temp,
@@ -413,7 +413,7 @@  static int __init bridge_init(void)
 		REG_SetValue(NULL, NULL, DEFEXEC, REG_SZ, (u8 *) "\0", (u32)2);
 	}
 	REG_SetValue(NULL, NULL, NUMPROCS, REG_SZ, (u8 *) num_procs,
-                   strlen(num_procs) + 1);
+						strlen(num_procs) + 1);
 
 	if (shm_size >= 0x10000) {	/* 64 KB */
 		initStatus = REG_SetValue(NULL, NULL, SHMSIZE, REG_DWORD,
@@ -455,15 +455,6 @@  static int __init bridge_init(void)
 			    sizeof(tc_wordswapon));
 	}
 	if (DSP_SUCCEEDED(initStatus)) {
-		driverContext = DSP_Init(&initStatus);
-		if (DSP_FAILED(initStatus)) {
-			status = -1;
-			GT_0trace(driverTrace, GT_7CLASS,
-				 "DSP/BIOS Bridge initialization Failed\n");
-		} else {
-			GT_0trace(driverTrace, GT_5CLASS,
-					"DSP/BIOS Bridge driver loaded\n");
-		}
 #ifdef CONFIG_BRIDGE_DVFS
 		for (i = 0; i < 5; i++)
 			pdata->mpu_speed[i] = vdd1_rate_table_bridge[i].rate;
@@ -484,6 +475,15 @@  static int __init bridge_init(void)
 			"clk_notifier_register FAIL for iva2_ck \n");
 		}
 #endif
+		driverContext = DSP_Init(&initStatus);
+		if (DSP_FAILED(initStatus)) {
+			status = -1;
+			GT_0trace(driverTrace, GT_7CLASS,
+				 "DSP/BIOS Bridge initialization Failed\n");
+		} else {
+			GT_0trace(driverTrace, GT_5CLASS,
+					"DSP/BIOS Bridge driver loaded\n");
+		}
 	}
 
 	DBC_Assert(status == 0);
@@ -660,11 +660,11 @@  func_cont:
 				(struct DRV_OBJECT *)hDrvObject, &pPctxt);
 
 	if (pPctxt != NULL) {
-               /* Return PID instead of process handle */
-               hProcess = current->pid;
+			/* Return PID instead of process handle */
+			hProcess = current->pid;
 
 		DRV_ProcUpdatestate(pPctxt, PROC_RES_ALLOCATED);
-               DRV_ProcSetPID(pPctxt, hProcess);
+			DRV_ProcSetPID(pPctxt, hProcess);
 	}
 #endif