diff mbox

staging: drm/omap: remove reclaim_buffers callback

Message ID 1343813558-28347-1-git-send-email-cmahapatra@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chandrabhanu Mahapatra Aug. 1, 2012, 9:32 a.m. UTC
The reclaim_buffers callback has already been removed by Daniel Vetter
<daniel.vetter@ffwll.ch> with his patch "drm: kill reclaim_buffers callback"
for which the kernel compilation fails with omapdrm support. So, the callback
for reclaim_buffers is removed from omapdrm.

Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
---
 drivers/staging/omapdrm/omap_drv.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Sumit Semwal Aug. 1, 2012, 10:25 a.m. UTC | #1
On Wed, Aug 1, 2012 at 3:02 PM, Chandrabhanu Mahapatra
<cmahapatra@ti.com> wrote:
> The reclaim_buffers callback has already been removed by Daniel Vetter
> <daniel.vetter@ffwll.ch> with his patch "drm: kill reclaim_buffers callback"
> for which the kernel compilation fails with omapdrm support. So, the callback
> for reclaim_buffers is removed from omapdrm.
>
> Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
Reviewed-by: Sumit Semwal <sumit.semwal@ti.com>
> ---
>  drivers/staging/omapdrm/omap_drv.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
> index 342645a..b8e79eb 100644
> --- a/drivers/staging/omapdrm/omap_drv.c
> +++ b/drivers/staging/omapdrm/omap_drv.c
> @@ -778,7 +778,6 @@ static struct drm_driver omap_drm_driver = {
>                 .irq_postinstall = dev_irq_postinstall,
>                 .irq_uninstall = dev_irq_uninstall,
>                 .irq_handler = dev_irq_handler,
> -               .reclaim_buffers = drm_core_reclaim_buffers,
>  #ifdef CONFIG_DEBUG_FS
>                 .debugfs_init = omap_debugfs_init,
>                 .debugfs_cleanup = omap_debugfs_cleanup,
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Clark Aug. 1, 2012, 11:48 a.m. UTC | #2
On Wed, Aug 1, 2012 at 4:32 AM, Chandrabhanu Mahapatra
<cmahapatra@ti.com> wrote:
> The reclaim_buffers callback has already been removed by Daniel Vetter
> <daniel.vetter@ffwll.ch> with his patch "drm: kill reclaim_buffers callback"
> for which the kernel compilation fails with omapdrm support. So, the callback
> for reclaim_buffers is removed from omapdrm.
>
> Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>

Signed-off-by: Rob Clark <rob@ti.com>

> ---
>  drivers/staging/omapdrm/omap_drv.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
> index 342645a..b8e79eb 100644
> --- a/drivers/staging/omapdrm/omap_drv.c
> +++ b/drivers/staging/omapdrm/omap_drv.c
> @@ -778,7 +778,6 @@ static struct drm_driver omap_drm_driver = {
>                 .irq_postinstall = dev_irq_postinstall,
>                 .irq_uninstall = dev_irq_uninstall,
>                 .irq_handler = dev_irq_handler,
> -               .reclaim_buffers = drm_core_reclaim_buffers,
>  #ifdef CONFIG_DEBUG_FS
>                 .debugfs_init = omap_debugfs_init,
>                 .debugfs_cleanup = omap_debugfs_cleanup,
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Paul Menzel Aug. 1, 2012, 12:51 p.m. UTC | #3
Am Mittwoch, den 01.08.2012, 15:02 +0530 schrieb Chandrabhanu Mahapatra:
> The reclaim_buffers callback has already been removed by Daniel Vetter
> <daniel.vetter@ffwll.ch> with his patch "drm: kill reclaim_buffers callback"

Please add the first eight characters of the commit hash behind the
summary in parentheses.

> for which the kernel compilation fails with omapdrm support. So, the callback
> for reclaim_buffers is removed from omapdrm.
> 
> Signed-off-by: Chandrabhanu Mahapatra <cmahapatra@ti.com>
> ---
>  drivers/staging/omapdrm/omap_drv.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
> index 342645a..b8e79eb 100644
> --- a/drivers/staging/omapdrm/omap_drv.c
> +++ b/drivers/staging/omapdrm/omap_drv.c
> @@ -778,7 +778,6 @@ static struct drm_driver omap_drm_driver = {
>  		.irq_postinstall = dev_irq_postinstall,
>  		.irq_uninstall = dev_irq_uninstall,
>  		.irq_handler = dev_irq_handler,
> -		.reclaim_buffers = drm_core_reclaim_buffers,
>  #ifdef CONFIG_DEBUG_FS
>  		.debugfs_init = omap_debugfs_init,
>  		.debugfs_cleanup = omap_debugfs_cleanup,

Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>


Thanks,

Paul
diff mbox

Patch

diff --git a/drivers/staging/omapdrm/omap_drv.c b/drivers/staging/omapdrm/omap_drv.c
index 342645a..b8e79eb 100644
--- a/drivers/staging/omapdrm/omap_drv.c
+++ b/drivers/staging/omapdrm/omap_drv.c
@@ -778,7 +778,6 @@  static struct drm_driver omap_drm_driver = {
 		.irq_postinstall = dev_irq_postinstall,
 		.irq_uninstall = dev_irq_uninstall,
 		.irq_handler = dev_irq_handler,
-		.reclaim_buffers = drm_core_reclaim_buffers,
 #ifdef CONFIG_DEBUG_FS
 		.debugfs_init = omap_debugfs_init,
 		.debugfs_cleanup = omap_debugfs_cleanup,