| Message ID | 1344309015-13248-1-git-send-email-sonic.adi@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Hi Chris, Could you review this series of patches for Blackfin on-chip SD controller? The head file and new BF60x machine code have been merged upstream. These patches are necessary to get SD driver built on BF60x. Thanks Sonic Zhang On Tue, Aug 7, 2012 at 11:10 AM, Sonic Zhang <sonic.adi@gmail.com> wrote: > From: Sonic Zhang <sonic.zhang@analog.com> > > bf518 RSI dma doesn't work in array mode. > > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> > --- > drivers/mmc/host/bfin_sdh.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c > index 0366617..fd25b0c 100644 > --- a/drivers/mmc/host/bfin_sdh.c > +++ b/drivers/mmc/host/bfin_sdh.c > @@ -469,7 +469,11 @@ static int __devinit sdh_probe(struct platform_device *pdev) > } > > mmc->ops = &sdh_ops; > +#if defined(CONFIG_BF54x) > mmc->max_segs = 32; > +#elif defined(CONFIG_BF51x) > + mmc->max_segs = 1; > +#endif > mmc->max_seg_size = 1 << 16; > mmc->max_blk_size = 1 << 11; > mmc->max_blk_count = 1 << 11; > -- > 1.7.0.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Aug 07 2012, Sonic Zhang wrote: > Could you review this series of patches for Blackfin on-chip SD > controller? The head file and new BF60x machine code have been merged > upstream. These patches are necessary to get SD driver built on BF60x. I see that Cliff Cai <cliff.cai@analog.com> is listed as the maintainer of bfin_sdh.c in MAINTAINERS -- is it possible for you to get his ACK? Thanks, - Chris.
Hi, On Tue, Aug 07 2012, Chris Ball wrote: > On Tue, Aug 07 2012, Sonic Zhang wrote: >> Could you review this series of patches for Blackfin on-chip SD >> controller? The head file and new BF60x machine code have been merged >> upstream. These patches are necessary to get SD driver built on BF60x. > > I see that Cliff Cai <cliff.cai@analog.com> is listed as the maintainer > of bfin_sdh.c in MAINTAINERS -- is it possible for you to get his ACK? Ah, Cliff's e-mail address bounced, and I see this was noticed last November -- you said you'd send out a MAINTAINERS update. Are you planning on taking over as bfin_sdh maintainer? Thanks, - Chris.
Hi Chris, Cliff Cai was not working for Analog Devices since 2011. I take over this SD driver now. I will revise the maintainer for bfin_sdh.c soon. Regards, Sonic >-----Original Message----- >From: Chris Ball [mailto:cjb@laptop.org] >Sent: Wednesday, August 08, 2012 11:31 AM >To: Sonic Zhang >Cc: linux-mmc@vger.kernel.org; Bob Liu; uclinux-dist-devel@blackfin.uclinux.org; >Zhang, Sonic; Cliff Cai >Subject: Re: [PATCH 1/4] mmc: bfin_sdh: limit mmc DMA segment len to 1 for >bf518. > >Hi, > >On Tue, Aug 07 2012, Sonic Zhang wrote: >> Could you review this series of patches for Blackfin on-chip SD >> controller? The head file and new BF60x machine code have been merged >> upstream. These patches are necessary to get SD driver built on BF60x. > >I see that Cliff Cai <cliff.cai@analog.com> is listed as the maintainer >of bfin_sdh.c in MAINTAINERS -- is it possible for you to get his ACK? > >Thanks, > >- Chris. >-- >Chris Ball <cjb@laptop.org> <http://printf.net/> >One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>-----Original Message----- >From: Chris Ball [mailto:cjb@laptop.org] >Sent: Wednesday, August 08, 2012 11:37 AM >To: Sonic Zhang >Cc: linux-mmc@vger.kernel.org; Bob Liu; uclinux-dist-devel@blackfin.uclinux.org; >Zhang, Sonic >Subject: Re: [PATCH 1/4] mmc: bfin_sdh: limit mmc DMA segment len to 1 for >bf518. > >Hi, > >On Tue, Aug 07 2012, Chris Ball wrote: >> On Tue, Aug 07 2012, Sonic Zhang wrote: >>> Could you review this series of patches for Blackfin on-chip SD >>> controller? The head file and new BF60x machine code have been merged >>> upstream. These patches are necessary to get SD driver built on BF60x. >> >> I see that Cliff Cai <cliff.cai@analog.com> is listed as the maintainer >> of bfin_sdh.c in MAINTAINERS -- is it possible for you to get his ACK? > >Ah, Cliff's e-mail address bounced, and I see this was noticed last >November -- you said you'd send out a MAINTAINERS update. Are you >planning on taking over as bfin_sdh maintainer? > Yes. Regards, Sonic -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Aug 07 2012, Zhang, Sonic wrote: > Hi Chris, > > Cliff Cai was not working for Analog Devices since 2011. I take over > this SD driver now. I will revise the maintainer for bfin_sdh.c soon. Thanks. Please can you send me that patch now? I'll merge your other this patchset at the same time. - Chris.
Hi, On Mon, Aug 06 2012, Sonic Zhang wrote: > From: Sonic Zhang <sonic.zhang@analog.com> > > bf518 RSI dma doesn't work in array mode. > > Signed-off-by: Sonic Zhang <sonic.zhang@analog.com> > --- > drivers/mmc/host/bfin_sdh.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c > index 0366617..fd25b0c 100644 > --- a/drivers/mmc/host/bfin_sdh.c > +++ b/drivers/mmc/host/bfin_sdh.c > @@ -469,7 +469,11 @@ static int __devinit sdh_probe(struct platform_device *pdev) > } > > mmc->ops = &sdh_ops; > +#if defined(CONFIG_BF54x) > mmc->max_segs = 32; > +#elif defined(CONFIG_BF51x) > + mmc->max_segs = 1; > +#endif > mmc->max_seg_size = 1 << 16; > mmc->max_blk_size = 1 << 11; > mmc->max_blk_count = 1 << 11; Thanks, pushed to mmc-next for 3.7. - Chris.
diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index 0366617..fd25b0c 100644 --- a/drivers/mmc/host/bfin_sdh.c +++ b/drivers/mmc/host/bfin_sdh.c @@ -469,7 +469,11 @@ static int __devinit sdh_probe(struct platform_device *pdev) } mmc->ops = &sdh_ops; +#if defined(CONFIG_BF54x) mmc->max_segs = 32; +#elif defined(CONFIG_BF51x) + mmc->max_segs = 1; +#endif mmc->max_seg_size = 1 << 16; mmc->max_blk_size = 1 << 11; mmc->max_blk_count = 1 << 11;