| Message ID | 1344516365-7230-7-git-send-email-durgadoss.r@intel.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On ?, 2012-08-09 at 18:15 +0530, Durgadoss R wrote: > This patch adds a policy sysfs attribute to a thermal zone. > This attribute will give us the throttling policy used > for the zone. This is a RO attribute. > > Signed-off-by: Durgadoss R <durgadoss.r@intel.com> > --- > drivers/thermal/thermal_sys.c | 40 ++++++++++++++++++++++++++++++++++++++++ > include/linux/thermal.h | 1 + > 2 files changed, 41 insertions(+) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 243a3f0..195e529 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -411,6 +411,27 @@ passive_show(struct device *dev, struct device_attribute *attr, > return sprintf(buf, "%d\n", tz->forced_passive); > } > > +static ssize_t show_throttle_policy(struct device *dev, > + struct device_attribute *devattr, char *buf) > +{ > + struct thermal_zone_device *tz = to_thermal_zone(dev); > + struct thermal_zone_params *tzp = tz->tzp; > + > + if (!tzp) > + return sprintf(buf, "step_wise(default)\n"); > + > + switch (tzp->throttle_policy) { > + case THERMAL_FAIR_SHARE: > + return sprintf(buf, "fair_share\n"); > + case THERMAL_STEP_WISE: > + return sprintf(buf, "step_wise\n"); > + case THERMAL_USER_SPACE: > + return sprintf(buf, "user_space\n"); > + default: > + return sprintf(buf, "unknown\n"); > + } > +} > + > static DEVICE_ATTR(type, 0444, type_show, NULL); > static DEVICE_ATTR(temp, 0444, temp_show, NULL); > static DEVICE_ATTR(mode, 0644, mode_show, mode_store); > @@ -1269,6 +1290,15 @@ leave: > } > EXPORT_SYMBOL(thermal_zone_device_update); > > +static int create_policy_attr(struct thermal_zone_device *tz) > +{ > + sysfs_attr_init(&tz->policy_attr.attr); > + tz->policy_attr.attr.name = "throttle_policy"; > + tz->policy_attr.attr.mode = S_IRUGO | S_IWUSR; > + tz->policy_attr.show = show_throttle_policy; > + return device_create_file(&tz->device, &tz->policy_attr); > +} > + > /** > * create_trip_attrs - create attributes for trip points > * @tz: the thermal zone device > @@ -1479,6 +1509,14 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, > /* Retrieve platform level parameters for this zone */ > retrieve_zone_params(tz); > > + result = create_policy_attr(tz); > + if (result) { > + dev_err(&tz->device, > + "create_policy_attr for zone %s failed:%d\n", > + tz->type, result); > + goto unregister; > + } > + > mutex_lock(&thermal_list_lock); > list_add_tail(&tz->node, &thermal_tz_list); > if (ops->bind) > @@ -1539,6 +1577,8 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) > device_remove_file(&tz->device, &dev_attr_mode); > remove_trip_attrs(tz); > > + device_remove_file(&tz->device, &tz->policy_attr); > + > thermal_remove_hwmon_sysfs(tz); > release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); > idr_destroy(&tz->idr); > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index f9ce1e2..1d49f05 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -173,6 +173,7 @@ struct thermal_zone_device { > struct list_head node; > struct delayed_work poll_queue; > struct thermal_zone_params *tzp; > + struct device_attribute policy_attr; do we need a device_attribute for each thermal zone? I think we can share one static DEVICE_ATTR here. thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
SGkgUnVpLA0KDQo+ICsNCj4gPiAgCXRoZXJtYWxfcmVtb3ZlX2h3bW9uX3N5c2ZzKHR6KTsNCj4g PiAgCXJlbGVhc2VfaWRyKCZ0aGVybWFsX3R6X2lkciwgJnRoZXJtYWxfaWRyX2xvY2ssIHR6LT5p ZCk7DQo+ID4gIAlpZHJfZGVzdHJveSgmdHotPmlkcik7DQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1 ZGUvbGludXgvdGhlcm1hbC5oIGIvaW5jbHVkZS9saW51eC90aGVybWFsLmgNCj4gPiBpbmRleCBm OWNlMWUyLi4xZDQ5ZjA1IDEwMDY0NA0KPiA+IC0tLSBhL2luY2x1ZGUvbGludXgvdGhlcm1hbC5o DQo+ID4gKysrIGIvaW5jbHVkZS9saW51eC90aGVybWFsLmgNCj4gPiBAQCAtMTczLDYgKzE3Myw3 IEBAIHN0cnVjdCB0aGVybWFsX3pvbmVfZGV2aWNlIHsNCj4gPiAgCXN0cnVjdCBsaXN0X2hlYWQg bm9kZTsNCj4gPiAgCXN0cnVjdCBkZWxheWVkX3dvcmsgcG9sbF9xdWV1ZTsNCj4gPiAgCXN0cnVj dCB0aGVybWFsX3pvbmVfcGFyYW1zICp0enA7DQo+ID4gKwlzdHJ1Y3QgZGV2aWNlX2F0dHJpYnV0 ZSBwb2xpY3lfYXR0cjsNCj4gDQo+IGRvIHdlIG5lZWQgYSBkZXZpY2VfYXR0cmlidXRlIGZvciBl YWNoIHRoZXJtYWwgem9uZT8NCj4gSSB0aGluayB3ZSBjYW4gc2hhcmUgb25lIHN0YXRpYyBERVZJ Q0VfQVRUUiBoZXJlLg0KDQpXZSBuZWVkIGEgcG9saWN5IHN5c2ZzIG5vZGUgcGVyIHpvbmUuIFRo YXTigJlzIHdoeSBJIHB1dCBpdA0KdGhpcyB3YXksIGFuZCB0aG91Z2h0IHRoaXMgbG9va3MgY2xl YW5lci4NCg0KQnV0LCBhcyBwZXIgdGhlIGltcGxlbWVudGF0aW9uIHBvaW50LCBzdGF0aWMgREVW SUNFX0FUVFIgDQp3b3VsZCBhbHNvIHdvcmsuIEVpdGhlciB3YXlzIGlzIGZpbmUgZm9yIG1lLg0K DQpUaGFua3MsDQpEdXJnYQ0K -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On ?, 2012-08-13 at 00:34 -0600, R, Durgadoss wrote: > Hi Rui, > > > + > > > thermal_remove_hwmon_sysfs(tz); > > > release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); > > > idr_destroy(&tz->idr); > > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > > > index f9ce1e2..1d49f05 100644 > > > --- a/include/linux/thermal.h > > > +++ b/include/linux/thermal.h > > > @@ -173,6 +173,7 @@ struct thermal_zone_device { > > > struct list_head node; > > > struct delayed_work poll_queue; > > > struct thermal_zone_params *tzp; > > > + struct device_attribute policy_attr; > > > > do we need a device_attribute for each thermal zone? > > I think we can share one static DEVICE_ATTR here. > > We need a policy sysfs node per zone. That’s why I put it > this way, and thought this looks cleaner. > > But, as per the implementation point, static DEVICE_ATTR > would also work. Either ways is fine for me. > I'd prefer the static DEVICE_ATTR, which is the way we do for other attributes like type, mode, temp, etc. thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On Thu, Aug 09, 2012 at 06:15:58PM +0530, Durgadoss R wrote: > This patch adds a policy sysfs attribute to a thermal zone. > This attribute will give us the throttling policy used > for the zone. This is a RO attribute. > > Signed-off-by: Durgadoss R <durgadoss.r@intel.com> > --- > drivers/thermal/thermal_sys.c | 40 ++++++++++++++++++++++++++++++++++++++++ > include/linux/thermal.h | 1 + > 2 files changed, 41 insertions(+) > > diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c > index 243a3f0..195e529 100644 > --- a/drivers/thermal/thermal_sys.c > +++ b/drivers/thermal/thermal_sys.c > @@ -411,6 +411,27 @@ passive_show(struct device *dev, struct device_attribute *attr, > return sprintf(buf, "%d\n", tz->forced_passive); > } > > +static ssize_t show_throttle_policy(struct device *dev, > + struct device_attribute *devattr, char *buf) > +{ > + struct thermal_zone_device *tz = to_thermal_zone(dev); > + struct thermal_zone_params *tzp = tz->tzp; > + > + if (!tzp) > + return sprintf(buf, "step_wise(default)\n"); > + > + switch (tzp->throttle_policy) { > + case THERMAL_FAIR_SHARE: > + return sprintf(buf, "fair_share\n"); > + case THERMAL_STEP_WISE: > + return sprintf(buf, "step_wise\n"); > + case THERMAL_USER_SPACE: > + return sprintf(buf, "user_space\n"); > + default: > + return sprintf(buf, "unknown\n"); > + } Assume you store the policy type under platform data tzp, does it mean that zones which does not have the tzp won't be capable to change the policy? > +} > + > static DEVICE_ATTR(type, 0444, type_show, NULL); > static DEVICE_ATTR(temp, 0444, temp_show, NULL); > static DEVICE_ATTR(mode, 0644, mode_show, mode_store); > @@ -1269,6 +1290,15 @@ leave: > } > EXPORT_SYMBOL(thermal_zone_device_update); > > +static int create_policy_attr(struct thermal_zone_device *tz) > +{ > + sysfs_attr_init(&tz->policy_attr.attr); > + tz->policy_attr.attr.name = "throttle_policy"; > + tz->policy_attr.attr.mode = S_IRUGO | S_IWUSR; > + tz->policy_attr.show = show_throttle_policy; > + return device_create_file(&tz->device, &tz->policy_attr); > +} > + > /** > * create_trip_attrs - create attributes for trip points > * @tz: the thermal zone device > @@ -1479,6 +1509,14 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, > /* Retrieve platform level parameters for this zone */ > retrieve_zone_params(tz); > > + result = create_policy_attr(tz); > + if (result) { > + dev_err(&tz->device, > + "create_policy_attr for zone %s failed:%d\n", > + tz->type, result); > + goto unregister; > + } > + > mutex_lock(&thermal_list_lock); > list_add_tail(&tz->node, &thermal_tz_list); > if (ops->bind) > @@ -1539,6 +1577,8 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) > device_remove_file(&tz->device, &dev_attr_mode); > remove_trip_attrs(tz); > > + device_remove_file(&tz->device, &tz->policy_attr); > + > thermal_remove_hwmon_sysfs(tz); > release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); > idr_destroy(&tz->idr); > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index f9ce1e2..1d49f05 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -173,6 +173,7 @@ struct thermal_zone_device { > struct list_head node; > struct delayed_work poll_queue; > struct thermal_zone_params *tzp; > + struct device_attribute policy_attr; > }; > > /* > -- > 1.7.9.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c index 243a3f0..195e529 100644 --- a/drivers/thermal/thermal_sys.c +++ b/drivers/thermal/thermal_sys.c @@ -411,6 +411,27 @@ passive_show(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%d\n", tz->forced_passive); } +static ssize_t show_throttle_policy(struct device *dev, + struct device_attribute *devattr, char *buf) +{ + struct thermal_zone_device *tz = to_thermal_zone(dev); + struct thermal_zone_params *tzp = tz->tzp; + + if (!tzp) + return sprintf(buf, "step_wise(default)\n"); + + switch (tzp->throttle_policy) { + case THERMAL_FAIR_SHARE: + return sprintf(buf, "fair_share\n"); + case THERMAL_STEP_WISE: + return sprintf(buf, "step_wise\n"); + case THERMAL_USER_SPACE: + return sprintf(buf, "user_space\n"); + default: + return sprintf(buf, "unknown\n"); + } +} + static DEVICE_ATTR(type, 0444, type_show, NULL); static DEVICE_ATTR(temp, 0444, temp_show, NULL); static DEVICE_ATTR(mode, 0644, mode_show, mode_store); @@ -1269,6 +1290,15 @@ leave: } EXPORT_SYMBOL(thermal_zone_device_update); +static int create_policy_attr(struct thermal_zone_device *tz) +{ + sysfs_attr_init(&tz->policy_attr.attr); + tz->policy_attr.attr.name = "throttle_policy"; + tz->policy_attr.attr.mode = S_IRUGO | S_IWUSR; + tz->policy_attr.show = show_throttle_policy; + return device_create_file(&tz->device, &tz->policy_attr); +} + /** * create_trip_attrs - create attributes for trip points * @tz: the thermal zone device @@ -1479,6 +1509,14 @@ struct thermal_zone_device *thermal_zone_device_register(const char *type, /* Retrieve platform level parameters for this zone */ retrieve_zone_params(tz); + result = create_policy_attr(tz); + if (result) { + dev_err(&tz->device, + "create_policy_attr for zone %s failed:%d\n", + tz->type, result); + goto unregister; + } + mutex_lock(&thermal_list_lock); list_add_tail(&tz->node, &thermal_tz_list); if (ops->bind) @@ -1539,6 +1577,8 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) device_remove_file(&tz->device, &dev_attr_mode); remove_trip_attrs(tz); + device_remove_file(&tz->device, &tz->policy_attr); + thermal_remove_hwmon_sysfs(tz); release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); idr_destroy(&tz->idr); diff --git a/include/linux/thermal.h b/include/linux/thermal.h index f9ce1e2..1d49f05 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -173,6 +173,7 @@ struct thermal_zone_device { struct list_head node; struct delayed_work poll_queue; struct thermal_zone_params *tzp; + struct device_attribute policy_attr; }; /*
This patch adds a policy sysfs attribute to a thermal zone. This attribute will give us the throttling policy used for the zone. This is a RO attribute. Signed-off-by: Durgadoss R <durgadoss.r@intel.com> --- drivers/thermal/thermal_sys.c | 40 ++++++++++++++++++++++++++++++++++++++++ include/linux/thermal.h | 1 + 2 files changed, 41 insertions(+)