diff mbox

[v3,2/3] Input: add devicetree binding note for egalax_ts

Message ID 1345026708-14139-3-git-send-email-jason77.wang@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jason Wang Aug. 15, 2012, 10:31 a.m. UTC
The egalax_ts driver needs to get the gpio number of the irq pin,
and use this gpio to wake up the controller. So add a note
for this change.

Signed-off-by: Hui Wang <jason77.wang@gmail.com>
---
 .../bindings/input/touchscreen/egalax-ts.txt       |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt

Comments

Shawn Guo Aug. 15, 2012, 12:53 p.m. UTC | #1
On Wed, Aug 15, 2012 at 06:31:47PM +0800, Hui Wang wrote:
> The egalax_ts driver needs to get the gpio number of the irq pin,
> and use this gpio to wake up the controller. So add a note
> for this change.
> 
> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
> ---
>  .../bindings/input/touchscreen/egalax-ts.txt       |   19 +++++++++++++++++++
>  1 files changed, 19 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> new file mode 100644
> index 0000000..df70318
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
> @@ -0,0 +1,19 @@
> +* EETI eGalax Multiple Touch Controller
> +
> +Required properties:
> +- compatible: must be "eeti,egalax_ts"

Since we define this in the binding anyway, can we have an corresponding
.of_match_table in the driver?

Regards,
Shawn

> +- reg: i2c slave address
> +- interrupt-parent: the phandle for the interrupt controller
> +- interrupts: touch controller interrupt
> +- wakeup-gpios: the gpio pin to be used for waking up the controller
> +  as well as uased as irq pin
> +
> +Example:
> +
> +	egalax_ts@04 {
> +		compatible = "eeti,egalax_ts";
> +		reg = <0x04>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <9 2>;
> +		wakeup-gpios = <&gpio1 9 0>;
> +	};
> -- 
> 1.7.6
>
Jason Wang Aug. 16, 2012, 6:48 a.m. UTC | #2
Shawn Guo wrote:
> On Wed, Aug 15, 2012 at 06:31:47PM +0800, Hui Wang wrote:
>   
>> The egalax_ts driver needs to get the gpio number of the irq pin,
>> and use this gpio to wake up the controller. So add a note
>> for this change.
>>
>> Signed-off-by: Hui Wang <jason77.wang@gmail.com>
>> ---
>>  .../bindings/input/touchscreen/egalax-ts.txt       |   19 +++++++++++++++++++
>>  1 files changed, 19 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
>>
>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
>> new file mode 100644
>> index 0000000..df70318
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
>> @@ -0,0 +1,19 @@
>> +* EETI eGalax Multiple Touch Controller
>> +
>> +Required properties:
>> +- compatible: must be "eeti,egalax_ts"
>>     
>
> Since we define this in the binding anyway, can we have an corresponding
> .of_match_table in the driver?
>
> Regards,
> Shawn
>
>   
OK, will add it in the driver.

Regards,
Hui.
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
new file mode 100644
index 0000000..df70318
--- /dev/null
+++ b/Documentation/devicetree/bindings/input/touchscreen/egalax-ts.txt
@@ -0,0 +1,19 @@ 
+* EETI eGalax Multiple Touch Controller
+
+Required properties:
+- compatible: must be "eeti,egalax_ts"
+- reg: i2c slave address
+- interrupt-parent: the phandle for the interrupt controller
+- interrupts: touch controller interrupt
+- wakeup-gpios: the gpio pin to be used for waking up the controller
+  as well as uased as irq pin
+
+Example:
+
+	egalax_ts@04 {
+		compatible = "eeti,egalax_ts";
+		reg = <0x04>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <9 2>;
+		wakeup-gpios = <&gpio1 9 0>;
+	};