Fwd: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness

Commit Message

Dave Airlie Aug. 18, 2012, 1:14 a.m. UTC

Hi Michael,

forwarding to a list that might be better place.

Dave.


---------- Forwarded message ----------
From: Michael Chapman <[e-mail]>
Date: Fri, Aug 17, 2012 at 10:30 PM
Subject: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness
To: [e-mail]


Hello Dave:

A couple of weeks ago, Carsten Emde helped me fix a display issue on
my Acer Aspire 5732Z that was similar to the problem on the 5734Z.
(Please see the email fragment below.) I don't know if he submitted a
patch, but I was wondering if this fix would be in place for Linux
3.6. I've attached a patch file that was made against
git://people.freedesktop.org/~danvet/drm-intel.

Thank you,

Michael


---------- Forwarded message ----------
From: Carsten Emde <[e-mail]>
Date: Wed, Jul 25, 2012 at 6:04 PM
Subject: Re: quirk_invert_brightness and Acer Aspire 5732Z
To: Michael Chapman <[e-mail]>


On 07/25/2012 07:09 PM, Michael Chapman wrote:
>
> Subsystem: 1025:0212

This is the patch:

Please let me know, whether a kernel with this patch still requires
manual setpci hassle or whether the problem is now fixed.

        -Carsten.
--- drm-intel/drivers/gpu/drm/i915/intel_display.c.orig	2012-08-17 07:56:15.000000000 -0400
+++ drm-intel/drivers/gpu/drm/i915/intel_display.c	2012-08-17 08:07:41.134723059 -0400
@@ -7041,6 +7041,9 @@
 
 	/* Acer Aspire 5734Z must invert backlight brightness */
 	{ 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
+
+	/* Acer Aspire 5732Z must invert backlight brightness */
+	{ 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
 };
 
 static void intel_init_quirks(struct drm_device *dev)

Comments

Daniel Vetter Aug. 18, 2012, 9:56 a.m. UTC | #1

Hi Michael,

> ---------- Forwarded message ----------
> From: Michael Chapman <[e-mail]>
> Date: Fri, Aug 17, 2012 at 10:30 PM
> Subject: intel_display.c: marking Acer Aspire 5732Z for quirk_invert_brightness
> To: [e-mail]
>
>
> Hello Dave:
>
> A couple of weeks ago, Carsten Emde helped me fix a display issue on
> my Acer Aspire 5732Z that was similar to the problem on the 5734Z.
> (Please see the email fragment below.) I don't know if he submitted a
> patch, but I was wondering if this fix would be in place for Linux
> 3.6. I've attached a patch file that was made against
> git://people.freedesktop.org/~danvet/drm-intel.

Afaikt this is just I quick hack and I intend to rip it out (same for
the original entry from Carsten Emde). I've sent Carsten Emde a quick
debug patch which should fix his issues for real, but unfortunately
never got a test results for it. To test, please try this patch:

https://bugs.freedesktop.org/attachment.cgi?id=65156

I've volunteered Jani from our team to write up a neat patch series to
fix this issue for good (which should hopefully land in 3.7).

Yours, Daniel

>
> Thank you,
>
> Michael
>
>
> ---------- Forwarded message ----------
> From: Carsten Emde <[e-mail]>
> Date: Wed, Jul 25, 2012 at 6:04 PM
> Subject: Re: quirk_invert_brightness and Acer Aspire 5732Z
> To: Michael Chapman <[e-mail]>
>
>
> On 07/25/2012 07:09 PM, Michael Chapman wrote:
>>
>> Subsystem: 1025:0212
>
> This is the patch:
>
> Index: linux-git/drivers/gpu/drm/i915/intel_display.c
> ===================================================================
> --- linux-git.orig/drivers/gpu/drm/i915/intel_display.c
> +++ linux-git/drivers/gpu/drm/i915/intel_display.c
> @@ -6877,7 +6877,8 @@ static struct intel_quirk intel_quirks[]
>         /* Sony Vaio Y cannot use SSC on LVDS */
>         { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },
>
> -       /* Acer Aspire 5734Z must invert backlight brightness */
> +       /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */
> +       { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
>         { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
>  };
>
> Please let me know, whether a kernel with this patch still requires
> manual setpci hassle or whether the problem is now fixed.
>
>         -Carsten.
>
> _______________________________________________
> Intel-gfx mailing list
> [e-mail]
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

Patch

Index: linux-git/drivers/gpu/drm/i915/intel_display.c
===================================================================
--- linux-git.orig/drivers/gpu/drm/i915/intel_display.c
+++ linux-git/drivers/gpu/drm/i915/intel_display.c
@@ -6877,7 +6877,8 @@  static struct intel_quirk intel_quirks[]
        /* Sony Vaio Y cannot use SSC on LVDS */
        { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable },

-       /* Acer Aspire 5734Z must invert backlight brightness */
+       /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */
+       { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness },
        { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness },
 };