| Message ID | 1345799431-29426-4-git-send-email-agust@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > Set "y_skip_top" to zero and remove comment as I do not see this > line corruption on two different mt9v022 setups. The first read-out > line is perfectly fine. On what systems have you checked this? Thanks Guennadi > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > --- > drivers/media/i2c/soc_camera/mt9v022.c | 6 +----- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/soc_camera/mt9v022.c b/drivers/media/i2c/soc_camera/mt9v022.c > index d26c071..e41d738 100644 > --- a/drivers/media/i2c/soc_camera/mt9v022.c > +++ b/drivers/media/i2c/soc_camera/mt9v022.c > @@ -960,11 +960,7 @@ static int mt9v022_probe(struct i2c_client *client, > > mt9v022->chip_control = MT9V022_CHIP_CONTROL_DEFAULT; > > - /* > - * MT9V022 _really_ corrupts the first read out line. > - * TODO: verify on i.MX31 > - */ > - mt9v022->y_skip_top = 1; > + mt9v022->y_skip_top = 0; > mt9v022->rect.left = MT9V022_COLUMN_SKIP; > mt9v022->rect.top = MT9V022_ROW_SKIP; > mt9v022->rect.width = MT9V022_MAX_WIDTH; > -- > 1.7.1 > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > > > Set "y_skip_top" to zero and remove comment as I do not see this > > line corruption on two different mt9v022 setups. The first read-out > > line is perfectly fine. > > On what systems have you checked this? On camera systems from ifm, both using mt9v022. Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > On Fri, 24 Aug 2012 13:23:22 +0200 (CEST) > Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: > > > On Fri, 24 Aug 2012, Anatolij Gustschin wrote: > > > > > Set "y_skip_top" to zero and remove comment as I do not see this > > > line corruption on two different mt9v022 setups. The first read-out > > > line is perfectly fine. > > > > On what systems have you checked this? > > On camera systems from ifm, both using mt9v022. Ok, I agree, this was a hack in the beginning, and, probably, there was a reason for the problem, that we've seen, that we didn't find a proper solution to, but I wouldn't like to punish those systems now. The y_skip_top field is only taken into account by the pxa driver, and there is only one pxa270 system, using mt9v022: pcm990-baseboard.c. Could you, please, add platform data to mt9v022 with only one parameter to initialise y_skip_top, use 0 as default and set it to 1 on pcm990-baseboard.c? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi, On Tue, 11 Sep 2012 10:55:31 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> wrote: ... > > > On what systems have you checked this? > > > > On camera systems from ifm, both using mt9v022. > > Ok, I agree, this was a hack in the beginning, and, probably, there was a > reason for the problem, that we've seen, that we didn't find a proper > solution to, but I wouldn't like to punish those systems now. The > y_skip_top field is only taken into account by the pxa driver, and there > is only one pxa270 system, using mt9v022: pcm990-baseboard.c. Could you, > please, add platform data to mt9v022 with only one parameter to initialise > y_skip_top, use 0 as default and set it to 1 on pcm990-baseboard.c? Yes, I've reworked this patch as suggested and will resubmit. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/i2c/soc_camera/mt9v022.c b/drivers/media/i2c/soc_camera/mt9v022.c index d26c071..e41d738 100644 --- a/drivers/media/i2c/soc_camera/mt9v022.c +++ b/drivers/media/i2c/soc_camera/mt9v022.c @@ -960,11 +960,7 @@ static int mt9v022_probe(struct i2c_client *client, mt9v022->chip_control = MT9V022_CHIP_CONTROL_DEFAULT; - /* - * MT9V022 _really_ corrupts the first read out line. - * TODO: verify on i.MX31 - */ - mt9v022->y_skip_top = 1; + mt9v022->y_skip_top = 0; mt9v022->rect.left = MT9V022_COLUMN_SKIP; mt9v022->rect.top = MT9V022_ROW_SKIP; mt9v022->rect.width = MT9V022_MAX_WIDTH;
Set "y_skip_top" to zero and remove comment as I do not see this line corruption on two different mt9v022 setups. The first read-out line is perfectly fine. Signed-off-by: Anatolij Gustschin <agust@denx.de> --- drivers/media/i2c/soc_camera/mt9v022.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-)