diff mbox

[1/1] DSPBRIDGE Fix flush_workque

Message ID EAF47CD23C76F840A9E7FCE10091EFAB02A91ACA75@dbde02.ent.ti.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Gupta, Ramesh March 19, 2009, 4:25 a.m. UTC 
From a8aabc6233329998d0ac62be42ade5a77f03ef2a Mon Sep 17 00:00:00 2001
From: Ramesh Gupta <x0023949@ti.com>
Date: Thu, 19 Mar 2009 09:56:30 +0530
Subject: [PATCH 1/1] DSPBRIDGE Fix flush_workque

Observed some crash with flush_workque after 
multiple load and unload.
Replaced flush_workque with destroy_workque

Signed-off-by: Varide Nischal <x0102224@ti.com>
---
 drivers/dsp/bridge/wmd/io_sm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Nishanth Menon March 19, 2009, 12:40 p.m. UTC | #1 
> -----Original Message-----
> From: Gupta, Ramesh
> Sent: Thursday, March 19, 2009 6:25 AM
> To: linux-omap@vger.kernel.org
> Cc: Menon, Nishanth; Kanigeri, Hari; Varide, Nischal; Guzman Lugo,
> Fernando
> Subject: [PATCH 1/1] DSPBRIDGE Fix flush_workque
> 
> From a8aabc6233329998d0ac62be42ade5a77f03ef2a Mon Sep 17 00:00:00 2001
> From: Ramesh Gupta <x0023949@ti.com>
> Date: Thu, 19 Mar 2009 09:56:30 +0530
> Subject: [PATCH 1/1] DSPBRIDGE Fix flush_workque
> 
> Observed some crash with flush_workque after
> multiple load and unload.
> Replaced flush_workque with destroy_workque
> 
> Signed-off-by: Varide Nischal <x0102224@ti.com>
Thanks Ramesh.
Tested-by: Nishanth Menon <nm@ti.com>

Test h/w: SDP3430. - OMAP3430 ES3.0 

Test iteration: (bootargs mem=122M)
./bridgedriver.ko phys_mempool_base=0x87A00000 phys_mempool_size=0x00600000  base_img=dsp/baseimage.dof
rmmod bridgedriver
--

Num iterations: 30K

Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c
index 0eb9893..ea802d0 100644
--- a/drivers/dsp/bridge/wmd/io_sm.c
+++ b/drivers/dsp/bridge/wmd/io_sm.c
@@ -391,7 +391,7 @@  DSP_STATUS WMD_IO_Destroy(struct IO_MGR *hIOMgr)
                       &hWmdContext)))
                                DBC_Assert(hWmdContext);
                (void)CHNLSM_DisableInterrupt(hWmdContext);
-               flush_workqueue(bridge_workqueue);
+               destroy_workqueue(bridge_workqueue);
                /* Linux function to uninstall ISR */
                free_irq(INT_MAIL_MPU_IRQ, (void *)hIOMgr);
                (void)DPC_Destroy(hIOMgr->hDPC);