| Message ID | 1345738494-4014-1-git-send-email-nicolas.ferre@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 18:14 Thu 23 Aug , Nicolas Ferre wrote: > From: Joachim Eastwood <manabian@gmail.com> > > Include linux/io.h for raw io operations in atmel-scc header. > > This fixes the following build error: > CC [M] sound/soc/atmel/atmel_ssc_dai.o > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': > sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': > sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' > > Signed-off-by: Joachim Eastwood <joachim.eastwood@jotron.com> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Best Regards, J. > --- > Mark, > > Here is a copy of the original patch by Joachim. Can you please take a look and > give your acknowledgement so that I can queue it in arm-soc tree. > > Thanks, bye, > > include/linux/atmel-ssc.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h > index 0602339..4eb3175 100644 > --- a/include/linux/atmel-ssc.h > +++ b/include/linux/atmel-ssc.h > @@ -3,6 +3,7 @@ > > #include <linux/platform_device.h> > #include <linux/list.h> > +#include <linux/io.h> > > struct ssc_device { > struct list_head list; > -- > 1.7.10 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote: > From: Joachim Eastwood <manabian@gmail.com> > > Include linux/io.h for raw io operations in atmel-scc header. > > This fixes the following build error: > CC [M] sound/soc/atmel/atmel_ssc_dai.o > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': > sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' > sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': > sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> but why not just apply it to the ASoC tree?
On 08/25/2012 10:25 PM, Mark Brown : > On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote: >> From: Joachim Eastwood <manabian@gmail.com> >> >> Include linux/io.h for raw io operations in atmel-scc header. >> >> This fixes the following build error: >> CC [M] sound/soc/atmel/atmel_ssc_dai.o >> sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': >> sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' >> sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': >> sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > > but why not just apply it to the ASoC tree? Fine by me then: so Mark, can you take it for a 3.6 fixes branch? (I remove it from my at91-fixes branch that will go through arm-soc tree). Best regards,
On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote: > From: Joachim Eastwood <manabian@gmail.com> > > Include linux/io.h for raw io operations in atmel-scc header. Applied, thanks.
On 08/27/2012 10:01 AM, Nicolas Ferre : > On 08/25/2012 10:25 PM, Mark Brown : >> On Thu, Aug 23, 2012 at 06:14:54PM +0200, Nicolas Ferre wrote: >>> From: Joachim Eastwood <manabian@gmail.com> >>> >>> Include linux/io.h for raw io operations in atmel-scc header. >>> >>> This fixes the following build error: >>> CC [M] sound/soc/atmel/atmel_ssc_dai.o >>> sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt': >>> sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' >>> sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown': >>> sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel' >> >> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> >> >> but why not just apply it to the ASoC tree? > > Fine by me then: so Mark, can you take it for a 3.6 fixes branch? > > (I remove it from my at91-fixes branch that will go through arm-soc tree). Hi Mark, Ping? Best regards,
On Tue, Sep 11, 2012 at 02:15:18PM +0200, Nicolas Ferre wrote:
> Ping?
Pong. Don't send contentless pings... If you want me to apply the
patch someone should send me a copy.
diff --git a/include/linux/atmel-ssc.h b/include/linux/atmel-ssc.h index 0602339..4eb3175 100644 --- a/include/linux/atmel-ssc.h +++ b/include/linux/atmel-ssc.h @@ -3,6 +3,7 @@ #include <linux/platform_device.h> #include <linux/list.h> +#include <linux/io.h> struct ssc_device { struct list_head list;