diff mbox

[3/5] rt2x00: rt2800lib - code cleanup.

Message ID 1347827393-26948-4-git-send-email-gwingerde@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Gertjan van Wingerde Sept. 16, 2012, 8:29 p.m. UTC 
Move RT3290 BBP initialization sequence (part) to the right place in the code.

This is just a code style change, no functional changes.

Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>

Comments

Ivo van Doorn Sept. 17, 2012, 3:28 p.m. UTC | #1 
2012/9/16 Gertjan van Wingerde <gwingerde@gmail.com>:
> Move RT3290 BBP initialization sequence (part) to the right place in the code.
>
> This is just a code style change, no functional changes.
>
> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 17b8a28..37f64ba 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -3535,6 +3535,11 @@ static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
>         } else if (rt2800_is_305x_soc(rt2x00dev)) {
>                 rt2800_bbp_write(rt2x00dev, 78, 0x0e);
>                 rt2800_bbp_write(rt2x00dev, 80, 0x08);
> +       } else if (rt2x00_rt(rt2x00dev, RT3290)) {
> +               rt2800_bbp_write(rt2x00dev, 74, 0x0b);
> +               rt2800_bbp_write(rt2x00dev, 79, 0x18);
> +               rt2800_bbp_write(rt2x00dev, 80, 0x09);
> +               rt2800_bbp_write(rt2x00dev, 81, 0x33);
>         } else if (rt2x00_rt(rt2x00dev, RT3352)) {
>                 rt2800_bbp_write(rt2x00dev, 78, 0x0e);
>                 rt2800_bbp_write(rt2x00dev, 80, 0x08);
> @@ -3543,13 +3548,6 @@ static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
>                 rt2800_bbp_write(rt2x00dev, 81, 0x37);
>         }
>
> -       if (rt2x00_rt(rt2x00dev, RT3290)) {
> -               rt2800_bbp_write(rt2x00dev, 74, 0x0b);
> -               rt2800_bbp_write(rt2x00dev, 79, 0x18);
> -               rt2800_bbp_write(rt2x00dev, 80, 0x09);
> -               rt2800_bbp_write(rt2x00dev, 81, 0x33);
> -       }
> -
>         rt2800_bbp_write(rt2x00dev, 82, 0x62);
>         if (rt2x00_rt(rt2x00dev, RT3290) ||
>             rt2x00_rt(rt2x00dev, RT5390) ||
> --
> 1.7.11.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 17b8a28..37f64ba 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -3535,6 +3535,11 @@  static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
 	} else if (rt2800_is_305x_soc(rt2x00dev)) {
 		rt2800_bbp_write(rt2x00dev, 78, 0x0e);
 		rt2800_bbp_write(rt2x00dev, 80, 0x08);
+	} else if (rt2x00_rt(rt2x00dev, RT3290)) {
+		rt2800_bbp_write(rt2x00dev, 74, 0x0b);
+		rt2800_bbp_write(rt2x00dev, 79, 0x18);
+		rt2800_bbp_write(rt2x00dev, 80, 0x09);
+		rt2800_bbp_write(rt2x00dev, 81, 0x33);
 	} else if (rt2x00_rt(rt2x00dev, RT3352)) {
 		rt2800_bbp_write(rt2x00dev, 78, 0x0e);
 		rt2800_bbp_write(rt2x00dev, 80, 0x08);
@@ -3543,13 +3548,6 @@  static int rt2800_init_bbp(struct rt2x00_dev *rt2x00dev)
 		rt2800_bbp_write(rt2x00dev, 81, 0x37);
 	}
 
-	if (rt2x00_rt(rt2x00dev, RT3290)) {
-		rt2800_bbp_write(rt2x00dev, 74, 0x0b);
-		rt2800_bbp_write(rt2x00dev, 79, 0x18);
-		rt2800_bbp_write(rt2x00dev, 80, 0x09);
-		rt2800_bbp_write(rt2x00dev, 81, 0x33);
-	}
-
 	rt2800_bbp_write(rt2x00dev, 82, 0x62);
 	if (rt2x00_rt(rt2x00dev, RT3290) ||
 	    rt2x00_rt(rt2x00dev, RT5390) ||