diff mbox

arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Message ID 1341325242-17638-1-git-send-email-yegorslists@googlemail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yegor Yefremov July 3, 2012, 2:20 p.m. UTC 
From: Yegor Yefremov <yegorslists@googlemail.com>

FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
of consistent DMA memory (da8xx frame buffer driver).

Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 arch/arm/Kconfig |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

Comments

Tony Lindgren Sept. 24, 2012, 5:18 p.m. UTC | #1 
* yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
> From: Yegor Yefremov <yegorslists@googlemail.com>
> 
> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> of consistent DMA memory (da8xx frame buffer driver).

Sorry for the delay on this one, looks like this one is
still valid. I'll apply it.

Regards,

Tony
 
> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> ---
>  arch/arm/Kconfig |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index e876819..ff14c1e 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
>  source "mm/Kconfig"
>  
>  config FORCE_MAX_ZONEORDER
> -	int "Maximum zone order" if ARCH_SHMOBILE
> -	range 11 64 if ARCH_SHMOBILE
> +	int "Maximum zone order"
> +	depends on ARCH_SHMOBILE || SOC_AM33XX
> +	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>  	default "9" if SA1111
>  	default "11"
>  	help
> -- 
> 1.7.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yegor Yefremov Sept. 24, 2012, 7:05 p.m. UTC | #2 
On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@atomide.com> wrote:
> * yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>
>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>> of consistent DMA memory (da8xx frame buffer driver).
>
> Sorry for the delay on this one, looks like this one is
> still valid. I'll apply it.

Thanks.

Yegor

>> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>> ---
>>  arch/arm/Kconfig |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index e876819..ff14c1e 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
>>  source "mm/Kconfig"
>>
>>  config FORCE_MAX_ZONEORDER
>> -     int "Maximum zone order" if ARCH_SHMOBILE
>> -     range 11 64 if ARCH_SHMOBILE
>> +     int "Maximum zone order"
>> +     depends on ARCH_SHMOBILE || SOC_AM33XX
>> +     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>>       default "9" if SA1111
>>       default "11"
>>       help
>> --
>> 1.7.7
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Russell King - ARM Linux Sept. 24, 2012, 11:16 p.m. UTC | #3 
On Mon, Sep 24, 2012 at 09:05:11PM +0200, Yegor Yefremov wrote:
> On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@atomide.com> wrote:
> > * yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
> >> From: Yegor Yefremov <yegorslists@googlemail.com>
> >>
> >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> >> of consistent DMA memory (da8xx frame buffer driver).
> >
> > Sorry for the delay on this one, looks like this one is
> > still valid. I'll apply it.
> 
> Thanks.
> 
> Yegor
> 
> >> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
> >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> >> ---
> >>  arch/arm/Kconfig |    5 +++--
> >>  1 files changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >> index e876819..ff14c1e 100644
> >> --- a/arch/arm/Kconfig
> >> +++ b/arch/arm/Kconfig
> >> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
> >>  source "mm/Kconfig"
> >>
> >>  config FORCE_MAX_ZONEORDER
> >> -     int "Maximum zone order" if ARCH_SHMOBILE
> >> -     range 11 64 if ARCH_SHMOBILE
> >> +     int "Maximum zone order"
> >> +     depends on ARCH_SHMOBILE || SOC_AM33XX
> >> +     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> >>       default "9" if SA1111
> >>       default "11"

NAK.  This patch breaks SA1111 platforms.  To see why, read the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Sept. 25, 2012, 12:37 a.m. UTC | #4 
* Russell King - ARM Linux <linux@arm.linux.org.uk> [120924 16:17]:
> On Mon, Sep 24, 2012 at 09:05:11PM +0200, Yegor Yefremov wrote:
> > On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@atomide.com> wrote:
> > > * yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
> > >> From: Yegor Yefremov <yegorslists@googlemail.com>
> > >>
> > >> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
> > >> of consistent DMA memory (da8xx frame buffer driver).
> > >
> > > Sorry for the delay on this one, looks like this one is
> > > still valid. I'll apply it.
> > 
> > Thanks.
> > 
> > Yegor
> > 
> > >> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
> > >> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> > >> ---
> > >>  arch/arm/Kconfig |    5 +++--
> > >>  1 files changed, 3 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > >> index e876819..ff14c1e 100644
> > >> --- a/arch/arm/Kconfig
> > >> +++ b/arch/arm/Kconfig
> > >> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
> > >>  source "mm/Kconfig"
> > >>
> > >>  config FORCE_MAX_ZONEORDER
> > >> -     int "Maximum zone order" if ARCH_SHMOBILE
> > >> -     range 11 64 if ARCH_SHMOBILE
> > >> +     int "Maximum zone order"
> > >> +     depends on ARCH_SHMOBILE || SOC_AM33XX
> > >> +     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
> > >>       default "9" if SA1111
> > >>       default "11"
> 
> NAK.  This patch breaks SA1111 platforms.  To see why, read the patch.

OK let's drop this.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yegor Yefremov Sept. 25, 2012, 8:05 a.m. UTC | #5 
On 25.09.2012 02:37, Tony Lindgren wrote:
> * Russell King - ARM Linux <linux@arm.linux.org.uk> [120924 16:17]:
>> On Mon, Sep 24, 2012 at 09:05:11PM +0200, Yegor Yefremov wrote:
>>> On Mon, Sep 24, 2012 at 7:18 PM, Tony Lindgren <tony@atomide.com> wrote:
>>>> * yegorslists@googlemail.com <yegorslists@googlemail.com> [120703 07:26]:
>>>>> From: Yegor Yefremov <yegorslists@googlemail.com>
>>>>>
>>>>> FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB
>>>>> of consistent DMA memory (da8xx frame buffer driver).
>>>>
>>>> Sorry for the delay on this one, looks like this one is
>>>> still valid. I'll apply it.
>>>
>>> Thanks.
>>>
>>> Yegor
>>>
>>>>> Signed-off-by: Dejan Gacnik <dejan.gacnik@gmail.com>
>>>>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
>>>>> ---
>>>>>  arch/arm/Kconfig |    5 +++--
>>>>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>>>>> index e876819..ff14c1e 100644
>>>>> --- a/arch/arm/Kconfig
>>>>> +++ b/arch/arm/Kconfig
>>>>> @@ -1725,8 +1725,9 @@ config HW_PERF_EVENTS
>>>>>  source "mm/Kconfig"
>>>>>
>>>>>  config FORCE_MAX_ZONEORDER
>>>>> -     int "Maximum zone order" if ARCH_SHMOBILE
>>>>> -     range 11 64 if ARCH_SHMOBILE
>>>>> +     int "Maximum zone order"
>>>>> +     depends on ARCH_SHMOBILE || SOC_AM33XX
>>>>> +     range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
>>>>>       default "9" if SA1111
>>>>>       default "11"
>>
>> NAK.  This patch breaks SA1111 platforms.  To see why, read the patch.
> 
> OK let's drop this.

How should I change the patch to make it proper? SA1111 is broken anyway:

config FORCE_MAX_ZONEORDER
        int "Maximum zone order" if ARCH_SHMOBILE
        range 11 64 if ARCH_SHMOBILE
        default "9" if SA1111
        default "11"

AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE, so SA1111 won't be evaluated (at least if I select SA1111 include/generated/autoconf.h shows "11"). If I add SA1111 to dependency list like this:

depends on ARCH_SHMOBILE || SOC_AM33XX || SA1111

the prompt in "Kernel features" becomes visible, but it doesn't have the default value of "9", but "11".

Am I missing something?

Yegor
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Russell King - ARM Linux Sept. 25, 2012, 8:14 a.m. UTC | #6 
On Tue, Sep 25, 2012 at 10:05:30AM +0200, Yegor Yefremov wrote:
> How should I change the patch to make it proper? SA1111 is broken anyway:

No it isn't.  This is what it produces _today_, and has done for the last
5-10 years without modification

# CONFIG_CLEANCACHE is not set
# CONFIG_FRONTSWAP is not set
CONFIG_FORCE_MAX_ZONEORDER=9
CONFIG_LEDS=y
CONFIG_LEDS_CPU=y

> config FORCE_MAX_ZONEORDER
>         int "Maximum zone order" if ARCH_SHMOBILE
>         range 11 64 if ARCH_SHMOBILE
>         default "9" if SA1111
>         default "11"
> 
> AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,

No it doens't.

	int "Maximum zone order" if ARCH_SHMOBILE

is far from being the same as:

	int "Maximum zone order"
	depends on ARCH_SHMOBILE

The former defines a condition upon which the option is offered in GUIs -
or to put it another way, it defines the visibility of the option.

The latter defines a dependency which must be met for the option to be
both visible and appear in the resulting configuration file.

> so SA1111 won't be evaluated (at least if I select SA1111

And did you check that SA1111 remains selected?  I bet you didn't.  Or
maybe you tested your patched version.  Whatever.  The original works,
and has been known to work for years.  Your patch breaks it.  It's
really as simple as that.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yegor Yefremov Sept. 25, 2012, 8:28 a.m. UTC | #7 
On 25.09.2012 10:14, Russell King - ARM Linux wrote:
> On Tue, Sep 25, 2012 at 10:05:30AM +0200, Yegor Yefremov wrote:
>> How should I change the patch to make it proper? SA1111 is broken anyway:
> No it isn't.  This is what it produces _today_, and has done for the last
> 5-10 years without modification
>
> # CONFIG_CLEANCACHE is not set
> # CONFIG_FRONTSWAP is not set
> CONFIG_FORCE_MAX_ZONEORDER=9
> CONFIG_LEDS=y
> CONFIG_LEDS_CPU=y
>
>> config FORCE_MAX_ZONEORDER
>>         int "Maximum zone order" if ARCH_SHMOBILE
>>         range 11 64 if ARCH_SHMOBILE
>>         default "9" if SA1111
>>         default "11"
>>
>> AFAIK if ARCH_SHMOBILE defines dependency on ARCH_SHMOBILE,
> No it doens't.
>
> 	int "Maximum zone order" if ARCH_SHMOBILE
>
> is far from being the same as:
>
> 	int "Maximum zone order"
> 	depends on ARCH_SHMOBILE
>
> The former defines a condition upon which the option is offered in GUIs -
> or to put it another way, it defines the visibility of the option.
>
> The latter defines a dependency which must be met for the option to be
> both visible and appear in the resulting configuration file.
>
>> so SA1111 won't be evaluated (at least if I select SA1111
> And did you check that SA1111 remains selected?  I bet you didn't.  Or
> maybe you tested your patched version.  Whatever.  The original works,
> and has been known to work for years.  Your patch breaks it.  It's
> really as simple as that.

Thanks for explanation. I think I've got it now. Please review the v2 version.

Yegor

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tony Lindgren Oct. 8, 2012, 8:55 p.m. UTC | #8 
* Dejan Ga?nik <dejan.gacnik@gmail.com> [120927 07:13]:
> 
> I and my colleagues have developed a brand new very enhanced board having
> AM35xx CPU, 512MB DDR2, DVI, true dual Ethernet support (not using PRUSS),
> CAN, SPI, I2C, 7 USBs, etc…Board is already materialized and operational.
> 
> 
> According to our board we have create new machine type in the kernel
> (version: linux-3.2-psp04.06.00.07.sdk) and all other required stuff to
> support our board, modify some things, like adding support for dual eth,
> etc. Our goal is to provide this new board to the market (let say with
> large quantity) and therefore I am wondering how to start or if it is even
> possible to transfer our kernel change the main stream of this distro?
> During this kernel modification process we have been looking to not
> changing anything in kernel, what could affect other machine types.

For the mainline kernel, you should go with device tree based booting
to start with, we are no longer adding new board-*.c files. For older
distro kernels you need to maintain a separate board-*.c file until
we have moved everything to use device tree and distros are using
that kernel.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index e876819..ff14c1e 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1725,8 +1725,9 @@  config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order"
+	depends on ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
 	default "9" if SA1111
 	default "11"
 	help