diff mbox

ARM: dts: AM33XX: Add tsl2550 ambient light sensor DT data

Message ID 1348242551-21293-1-git-send-email-anilkumar@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

AnilKumar, Chimata Sept. 21, 2012, 3:49 p.m. UTC
Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
adds child node inside i2c2 node with i2c slave address.

TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
also reduces I2C2 clock frequency to 100KHz from 400KHz because the
maximum clock frequency of SMBus is 100KHz.

Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
 arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

AnilKumar, Chimata Oct. 18, 2012, 5:46 a.m. UTC | #1
On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote:
> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
> adds child node inside i2c2 node with i2c slave address.
> 
> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
> also reduces I2C2 clock frequency to 100KHz from 400KHz because the
> maximum clock frequency of SMBus is 100KHz.
> 
> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> ---
>  arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index 3b1f313..d99aa0f 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -49,7 +49,7 @@
>  
>  		i2c2: i2c@4802a000 {
>  			status = "okay";
> -			clock-frequency = <400000>;
> +			clock-frequency = <100000>;
>  
>  			lis331dlh: lis331dlh@18 {
>  				compatible = "st,lis331dlh", "st,lis3lv02d";
> @@ -79,6 +79,11 @@
>  				st,max-limit-z = <750>;
>  			};
>  
> +			tsl2550: tsl2550@39 {
> +				compatible = "taos,tsl2550";
> +				reg = <0x39>;
> +			};
> +
>  			tmp275: tmp275@48 {
>  				compatible = "ti,tmp275";
>  				reg = <0x48>;

Hi Tony/Benoit,

If there are no comments in this patch could you please take this in?

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Benoit Cousson Oct. 18, 2012, 8:08 a.m. UTC | #2
Hi Anil,

On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote:
> On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote:
>> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
>> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
>> adds child node inside i2c2 node with i2c slave address.
>>
>> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
>> also reduces I2C2 clock frequency to 100KHz from 400KHz because the
>> maximum clock frequency of SMBus is 100KHz.
>>
>> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
>> ---
>>  arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 3b1f313..d99aa0f 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -49,7 +49,7 @@
>>  
>>  		i2c2: i2c@4802a000 {
>>  			status = "okay";
>> -			clock-frequency = <400000>;
>> +			clock-frequency = <100000>;
>>  
>>  			lis331dlh: lis331dlh@18 {
>>  				compatible = "st,lis331dlh", "st,lis3lv02d";
>> @@ -79,6 +79,11 @@
>>  				st,max-limit-z = <750>;
>>  			};
>>  
>> +			tsl2550: tsl2550@39 {
>> +				compatible = "taos,tsl2550";
>> +				reg = <0x39>;
>> +			};
>> +
>>  			tmp275: tmp275@48 {
>>  				compatible = "ti,tmp275";
>>  				reg = <0x48>;
> 
> Hi Tony/Benoit,
> 
> If there are no comments in this patch could you please take this in?

Have you updated the binding documentation to list the device?

It should be in:
Documentation/devicetree/bindings/i2c/trivial-devices.txt

Please Cc as well the DT ml.

Regards,
Benoit

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
AnilKumar, Chimata Oct. 18, 2012, 11:24 a.m. UTC | #3
+Grant, DTML

On Thu, Oct 18, 2012 at 13:38:30, Cousson, Benoit wrote:
> Hi Anil,
> 
> On 10/18/2012 07:46 AM, AnilKumar, Chimata wrote:
> > On Fri, Sep 21, 2012 at 21:19:11, AnilKumar, Chimata wrote:
> >> Add tsl2550 ambient light sensor DT data to am335x-evm.dts. In AM335x
> >> EVM tsl2550 ambient light sensor is connected to I2C2 bus. So this patch
> >> adds child node inside i2c2 node with i2c slave address.
> >>
> >> TAOS tsl2550 sensor with two-wire SMBus serial interface. This patch
> >> also reduces I2C2 clock frequency to 100KHz from 400KHz because the
> >> maximum clock frequency of SMBus is 100KHz.
> >>
> >> Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
> >> ---
> >>  arch/arm/boot/dts/am335x-evm.dts |    7 ++++++-
> >>  1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> >> index 3b1f313..d99aa0f 100644
> >> --- a/arch/arm/boot/dts/am335x-evm.dts
> >> +++ b/arch/arm/boot/dts/am335x-evm.dts
> >> @@ -49,7 +49,7 @@
> >>  
> >>  		i2c2: i2c@4802a000 {
> >>  			status = "okay";
> >> -			clock-frequency = <400000>;
> >> +			clock-frequency = <100000>;
> >>  
> >>  			lis331dlh: lis331dlh@18 {
> >>  				compatible = "st,lis331dlh", "st,lis3lv02d";
> >> @@ -79,6 +79,11 @@
> >>  				st,max-limit-z = <750>;
> >>  			};
> >>  
> >> +			tsl2550: tsl2550@39 {
> >> +				compatible = "taos,tsl2550";
> >> +				reg = <0x39>;
> >> +			};
> >> +
> >>  			tmp275: tmp275@48 {
> >>  				compatible = "ti,tmp275";
> >>  				reg = <0x48>;
> > 
> > Hi Tony/Benoit,
> > 
> > If there are no comments in this patch could you please take this in?
> 
> Have you updated the binding documentation to list the device?
> 
> It should be in:
> Documentation/devicetree/bindings/i2c/trivial-devices.txt
> 

No I have not updated, I will send a separate patch by adding all the supported
devices, missed from earlier (this device, tmp275 and lis331dlh)

Thanks
AnilKumar
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
index 3b1f313..d99aa0f 100644
--- a/arch/arm/boot/dts/am335x-evm.dts
+++ b/arch/arm/boot/dts/am335x-evm.dts
@@ -49,7 +49,7 @@ 
 
 		i2c2: i2c@4802a000 {
 			status = "okay";
-			clock-frequency = <400000>;
+			clock-frequency = <100000>;
 
 			lis331dlh: lis331dlh@18 {
 				compatible = "st,lis331dlh", "st,lis3lv02d";
@@ -79,6 +79,11 @@ 
 				st,max-limit-z = <750>;
 			};
 
+			tsl2550: tsl2550@39 {
+				compatible = "taos,tsl2550";
+				reg = <0x39>;
+			};
+
 			tmp275: tmp275@48 {
 				compatible = "ti,tmp275";
 				reg = <0x48>;