| Message ID | 1351167915-15079-4-git-send-email-balbi@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Thu, Oct 25, 2012 at 06:13:16PM +0530, Santosh Shilimkar wrote: > On Thursday 25 October 2012 05:55 PM, Felipe Balbi wrote: > >In case we loop on IRQ handler until stat is > >finally zero, we would end up in a situation > >where all I2C transfers would misteriously > >timeout because we were not calling complete() > >in that situation. > > > >Fix the issue by moving omap_i2c_complete_cmd() > >call inside the 'out' label. > > > >Signed-off-by: Felipe Balbi <balbi@ti.com> > >--- > Looks fine. Have you hit this issue in any corner case ? in fact, yes. With a difficult to reproduce situation with drv2665 (one of TI's piezo drivers) I saw that I was missing the ack and all transfers were timing out ;-)
On Thursday 25 October 2012 05:55 PM, Felipe Balbi wrote: > In case we loop on IRQ handler until stat is > finally zero, we would end up in a situation > where all I2C transfers would misteriously > timeout because we were not calling complete() > in that situation. > > Fix the issue by moving omap_i2c_complete_cmd() > call inside the 'out' label. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- Looks fine. Have you hit this issue in any corner case ? Regards santosh
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index bea0277..b004126 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -1021,9 +1021,8 @@ omap_i2c_isr_thread(int this_irq, void *dev_id) } } while (stat); - omap_i2c_complete_cmd(dev, err); - out: + omap_i2c_complete_cmd(dev, err); spin_unlock_irqrestore(&dev->lock, flags); return IRQ_HANDLED;
In case we loop on IRQ handler until stat is finally zero, we would end up in a situation where all I2C transfers would misteriously timeout because we were not calling complete() in that situation. Fix the issue by moving omap_i2c_complete_cmd() call inside the 'out' label. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/i2c/busses/i2c-omap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)