[libdrm] libkms: fix the name of the intel driver in linux_sysfs_create

Commit Message

Ander Conselvan de Oliveira Sept. 5, 2012, 11:30 a.m. UTC

From: Ander Conselvan de Oliveira <[e-mail]>

linux_sysfs_create() checked for a driver named "intel" while the intel
driver is called "i915". This went unnoticed because in kernels 2.6.39
and after this code path was never reached because of the dumb buffer
interface. On earlier kernels, kms_create() would fail.

Signed-off-by: Ander Conselvan de Oliveira <[e-mail]>
---
 libkms/linux.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Ander Conselvan de Oliveira Oct. 29, 2012, 1:47 p.m. UTC | #1

Ping?

On 09/05/2012 02:30 PM, Ander Conselvan de Oliveira wrote:
> From: Ander Conselvan de Oliveira <[e-mail]>
>
> linux_sysfs_create() checked for a driver named "intel" while the intel
> driver is called "i915". This went unnoticed because in kernels 2.6.39
> and after this code path was never reached because of the dumb buffer
> interface. On earlier kernels, kms_create() would fail.
>
> Signed-off-by: Ander Conselvan de Oliveira <[e-mail]>
> ---
>   libkms/linux.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libkms/linux.c b/libkms/linux.c
> index fc4f205..dde74f7 100644
> --- a/libkms/linux.c
> +++ b/libkms/linux.c
> @@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out)
>   	if (ret)
>   		return ret;
>
> -	if (!strcmp(name, "intel"))
> +	if (!strcmp(name, "i915"))
>   		ret = intel_create(fd, out);
>   #ifdef HAVE_VMWGFX
>   	else if (!strcmp(name, "vmwgfx"))
>

Patch

diff --git a/libkms/linux.c b/libkms/linux.c
index fc4f205..dde74f7 100644
--- a/libkms/linux.c
+++ b/libkms/linux.c
@@ -101,7 +101,7 @@  linux_from_sysfs(int fd, struct kms_driver **out)
 	if (ret)
 		return ret;
 
-	if (!strcmp(name, "intel"))
+	if (!strcmp(name, "i915"))
 		ret = intel_create(fd, out);
 #ifdef HAVE_VMWGFX
 	else if (!strcmp(name, "vmwgfx"))