diff mbox

i2c: mv64xxx: Add support Armada-XP SoC

Message ID 1351593581-19555-1-git-send-email-iwamatsu@nigauri.org (mailing list archive)
State New, archived
Headers show

Commit Message

Nobuhiro Iwamatsu Oct. 30, 2012, 10:39 a.m. UTC
The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c.
This validates to use mv64xxx in this SoC.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 drivers/i2c/busses/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Oct. 30, 2012, 10:44 a.m. UTC | #1
Dear Nobuhiro Iwamatsu,

On Tue, 30 Oct 2012 19:39:41 +0900, Nobuhiro Iwamatsu wrote:
> The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c.
> This validates to use mv64xxx in this SoC.
> 
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/i2c/busses/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 65dd599..ff53cf4 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -474,7 +474,7 @@ config I2C_MPC
>  
>  config I2C_MV64XXX
>  	tristate "Marvell mv64xxx I2C Controller"
> -	depends on (MV64X60 || PLAT_ORION)
> +	depends on (MV64X60 || PLAT_ORION || MACH_ARMADA_370_XP)
>  	help
>  	  If you say yes to this option, support will be included for the
>  	  built-in I2C interface on the Marvell 64xxx line of host bridges.

This is not needed: ARCH_MVEBU already selects PLAT_ORION.

Best regards,

Thomas
Sergei Shtylyov Oct. 30, 2012, 3:50 p.m. UTC | #2
Hello.

On 10/30/2012 01:39 PM, Nobuhiro Iwamatsu wrote:

> The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c.
> This validates to use mv64xxx in this SoC.

> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
>  drivers/i2c/busses/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 65dd599..ff53cf4 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -474,7 +474,7 @@ config I2C_MPC
>  
>  config I2C_MV64XXX
>  	tristate "Marvell mv64xxx I2C Controller"
> -	depends on (MV64X60 || PLAT_ORION)
> +	depends on (MV64X60 || PLAT_ORION || MACH_ARMADA_370_XP)

  Could remove useless parens, while at it...

WBR, Sergei
Nobuhiro Iwamatsu Oct. 31, 2012, 3:38 a.m. UTC | #3
Hi,

On Tue, Oct 30, 2012 at 7:44 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Nobuhiro Iwamatsu,
>
> On Tue, 30 Oct 2012 19:39:41 +0900, Nobuhiro Iwamatsu wrote:
>> The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c.
>> This validates to use mv64xxx in this SoC.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>>  drivers/i2c/busses/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 65dd599..ff53cf4 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -474,7 +474,7 @@ config I2C_MPC
>>
>>  config I2C_MV64XXX
>>       tristate "Marvell mv64xxx I2C Controller"
>> -     depends on (MV64X60 || PLAT_ORION)
>> +     depends on (MV64X60 || PLAT_ORION || MACH_ARMADA_370_XP)
>>       help
>>         If you say yes to this option, support will be included for the
>>         built-in I2C interface on the Marvell 64xxx line of host bridges.
>
> This is not needed: ARCH_MVEBU already selects PLAT_ORION.
>

Oh, I see. Thanks!

Nobuhiro
Nobuhiro Iwamatsu Oct. 31, 2012, 3:44 a.m. UTC | #4
Hi,

On Wed, Oct 31, 2012 at 12:50 AM, Sergei Shtylyov <sshtylyov@mvista.com> wrote:
> Hello.
>
> On 10/30/2012 01:39 PM, Nobuhiro Iwamatsu wrote:
>
>> The Armada-XP SoC has the same I2C controller as mv64xxxi-i2c.
>> This validates to use mv64xxx in this SoC.
>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>> ---
>>  drivers/i2c/busses/Kconfig |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
>> index 65dd599..ff53cf4 100644
>> --- a/drivers/i2c/busses/Kconfig
>> +++ b/drivers/i2c/busses/Kconfig
>> @@ -474,7 +474,7 @@ config I2C_MPC
>>
>>  config I2C_MV64XXX
>>       tristate "Marvell mv64xxx I2C Controller"
>> -     depends on (MV64X60 || PLAT_ORION)
>> +     depends on (MV64X60 || PLAT_ORION || MACH_ARMADA_370_XP)
>
>   Could remove useless parens, while at it...
>
OK, I will send a patch which revise about this.
diff mbox

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 65dd599..ff53cf4 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -474,7 +474,7 @@  config I2C_MPC
 
 config I2C_MV64XXX
 	tristate "Marvell mv64xxx I2C Controller"
-	depends on (MV64X60 || PLAT_ORION)
+	depends on (MV64X60 || PLAT_ORION || MACH_ARMADA_370_XP)
 	help
 	  If you say yes to this option, support will be included for the
 	  built-in I2C interface on the Marvell 64xxx line of host bridges.