diff mbox

da8xx: Fix revision check on the da8xx driver

Message ID 1351698984-4007-1-git-send-email-panto@antoniou-consulting.com (mailing list archive)
State New, archived
Headers show

Commit Message

Pantelis Antoniou Oct. 31, 2012, 3:56 p.m. UTC
The revision check fails for the beaglebone; Add new revision ID.

Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
---
 drivers/video/da8xx-fb.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Manjunathappa, Prakash Oct. 31, 2012, 3:51 a.m. UTC | #1
On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
> The revision check fails for the beaglebone; Add new revision ID.
> 
> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> ---
>  drivers/video/da8xx-fb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> index 80665f6..866d804 100644
> --- a/drivers/video/da8xx-fb.c
> +++ b/drivers/video/da8xx-fb.c
> @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
>  		lcd_revision = LCD_VERSION_1;
>  		break;
>  	case 0x4F200800:
> +	case 0x4F201000:

Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
with to one read(0x4F200800) on emulator platform.

Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>

>  		lcd_revision = LCD_VERSION_2;
>  		break;
>  	default:
> -- 
> 1.7.12
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Manjunathappa, Prakash Dec. 4, 2012, 6:36 a.m. UTC | #2
Hi Tomi,

On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
> On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
> > The revision check fails for the beaglebone; Add new revision ID.
> > 
> > Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
> > ---
> >  drivers/video/da8xx-fb.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
> > index 80665f6..866d804 100644
> > --- a/drivers/video/da8xx-fb.c
> > +++ b/drivers/video/da8xx-fb.c
> > @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
> >  		lcd_revision = LCD_VERSION_1;
> >  		break;
> >  	case 0x4F200800:
> > +	case 0x4F201000:
> 
> Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
> with to one read(0x4F200800) on emulator platform.
> 
> Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>
> 

This patch is necessary for am335x FB, I could not see in your for-next branch,
could you please consider this patch for 3.8 merge window. There are no pending
review comments on this.

Thanks,
Prakash

> >  		lcd_revision = LCD_VERSION_2;
> >  		break;
> >  	default:
> > -- 
> > 1.7.12
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Tomi Valkeinen Dec. 4, 2012, 9:18 a.m. UTC | #3
On 2012-12-04 08:36, Manjunathappa, Prakash wrote:
> Hi Tomi,
> 
> On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote:
>> On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote:
>>> The revision check fails for the beaglebone; Add new revision ID.
>>>
>>> Signed-off-by: Pantelis Antoniou <panto@antoniou-consulting.com>
>>> ---
>>>  drivers/video/da8xx-fb.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
>>> index 80665f6..866d804 100644
>>> --- a/drivers/video/da8xx-fb.c
>>> +++ b/drivers/video/da8xx-fb.c
>>> @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device)
>>>  		lcd_revision = LCD_VERSION_1;
>>>  		break;
>>>  	case 0x4F200800:
>>> +	case 0x4F201000:
>>
>> Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison
>> with to one read(0x4F200800) on emulator platform.
>>
>> Acked-by: Manjunathappa, Prakash <prakash.pm@ti.com>
>>
> 
> This patch is necessary for am335x FB, I could not see in your for-next branch,

I have only applied the patches that have been sent to me.

> could you please consider this patch for 3.8 merge window. There are no pending
> review comments on this.

Applied.

 Tomi
diff mbox

Patch

diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c
index 80665f6..866d804 100644
--- a/drivers/video/da8xx-fb.c
+++ b/drivers/video/da8xx-fb.c
@@ -1283,6 +1283,7 @@  static int __devinit fb_probe(struct platform_device *device)
 		lcd_revision = LCD_VERSION_1;
 		break;
 	case 0x4F200800:
+	case 0x4F201000:
 		lcd_revision = LCD_VERSION_2;
 		break;
 	default: