| Message ID | alpine.BSF.2.00.1211111101390.70593@toaster.local (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Ira Weiny |
| Headers | show |
On Sun, 11 Nov 2012 11:05:32 -0800
Garrett Cooper <yanegomi@gmail.com> wrote:
> Signed-off-by: Garrett Cooper <gcooper@isilon.com>
Please note that the following scripts are _deprecated_ and should no longer
be used.
scripts/ibcheckerrors.in | 6 +++---
scripts/ibcheckerrs.in | 12 ++++++------
scripts/ibchecknet.in | 6 +++---
scripts/ibchecknode.in | 8 ++++----
scripts/ibcheckport.in | 8 ++++----
scripts/ibcheckportstate.in | 8 ++++----
scripts/ibcheckportwidth.in | 8 ++++----
scripts/ibcheckstate.in | 6 +++---
scripts/ibcheckwidth.in | 6 +++---
scripts/ibclearcounters.in | 6 +++---
scripts/ibclearerrors.in | 6 +++---
scripts/ibdatacounters.in | 6 +++---
scripts/ibdatacounts.in | 8 ++++----
scripts/set_nodedesc.sh | 2 +-
That said, what are you trying to fix here? Is there a reason bash can't be used on your system?
Thanks,
Ira
On Nov 12, 2012, at 3:22 PM, Ira Weiny wrote: > On Sun, 11 Nov 2012 11:05:32 -0800 > Garrett Cooper <yanegomi@gmail.com> wrote: > >> Signed-off-by: Garrett Cooper <gcooper@isilon.com> > > Please note that the following scripts are _deprecated_ and should no longer > be used. Ok :/.. where is the functionality being moved to? > scripts/ibcheckerrors.in | 6 +++--- > scripts/ibcheckerrs.in | 12 ++++++------ > scripts/ibchecknet.in | 6 +++--- > scripts/ibchecknode.in | 8 ++++---- > scripts/ibcheckport.in | 8 ++++---- > scripts/ibcheckportstate.in | 8 ++++---- > scripts/ibcheckportwidth.in | 8 ++++---- > scripts/ibcheckstate.in | 6 +++--- > scripts/ibcheckwidth.in | 6 +++--- > scripts/ibclearcounters.in | 6 +++--- > scripts/ibclearerrors.in | 6 +++--- > scripts/ibdatacounters.in | 6 +++--- > scripts/ibdatacounts.in | 8 ++++---- > scripts/set_nodedesc.sh | 2 +- > > That said, what are you trying to fix here? Is there a reason bash can't be used on your system? Good question! 1. FreeBSD (which is a downstream consumer of OFED to some degree) doesn't come with /bin/bash for licensing reasons. 2. Some Linux distro configs (thinking of busy box, etc) don't use bash because it's too bloated to include in the base image; they use dash (the parent shell which was ash from FreeBSD), mksh, etc instead. The goal was to use portable idioms so POSIX capable bourne shells could use the scripts. Thanks! -Garrett-- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 12 Nov 2012 15:44:54 -0800 Garrett Cooper <yanegomi@gmail.com> wrote: > On Nov 12, 2012, at 3:22 PM, Ira Weiny wrote: > > > On Sun, 11 Nov 2012 11:05:32 -0800 > > Garrett Cooper <yanegomi@gmail.com> wrote: > > > >> Signed-off-by: Garrett Cooper <gcooper@isilon.com> > > > > Please note that the following scripts are _deprecated_ and should no longer > > be used. > > Ok :/.. where is the functionality being moved to? Each of the tools has pointers to other tools which provide similar functionality. For example ibcheckerrors is replaced by ibqueryerrors. ibcheck[node|port|width] don't really have equivalents because they mostly checked for 4x DDR links which is not useful in general. The best tool for that is probably iblinkinfo which reports links which could be running at faster speed/widths. set_nodedesc.sh is no longer needed as all the distros/OFED have start up scripts which do the same thing. > > > scripts/ibcheckerrors.in | 6 +++--- > > scripts/ibcheckerrs.in | 12 ++++++------ > > scripts/ibchecknet.in | 6 +++--- > > scripts/ibchecknode.in | 8 ++++---- > > scripts/ibcheckport.in | 8 ++++---- > > scripts/ibcheckportstate.in | 8 ++++---- > > scripts/ibcheckportwidth.in | 8 ++++---- > > scripts/ibcheckstate.in | 6 +++--- > > scripts/ibcheckwidth.in | 6 +++--- > > scripts/ibclearcounters.in | 6 +++--- > > scripts/ibclearerrors.in | 6 +++--- > > scripts/ibdatacounters.in | 6 +++--- > > scripts/ibdatacounts.in | 8 ++++---- > > scripts/set_nodedesc.sh | 2 +- > > > > That said, what are you trying to fix here? Is there a reason bash can't be used on your system? > > Good question! > 1. FreeBSD (which is a downstream consumer of OFED to some degree) doesn't come with /bin/bash for licensing reasons. > 2. Some Linux distro configs (thinking of busy box, etc) don't use bash because it's too bloated to include in the base image; they use dash (the parent shell which was ash from FreeBSD), mksh, etc instead. > The goal was to use portable idioms so POSIX capable bourne shells could use the scripts. I like this idea but I worry about maintaining non-bashisms in scripts. I don't have ready access to a wide range of systems. Would you agree that dash is a least common denominator which would be a good tool to use as an automatic checker? To this end I could add a make check target which uses dash to check the scripts. Thoughts? Ira
On Sun, 11 Nov 2012 11:05:32 -0800
Garrett Cooper <yanegomi@gmail.com> wrote:
> Signed-off-by: Garrett Cooper <gcooper@isilon.com>
Thanks applied,
Ira
On Mon, Nov 26, 2012 at 10:33 AM, Ira Weiny <weiny2@llnl.gov> wrote: > On Sun, 11 Nov 2012 11:05:32 -0800 > Garrett Cooper <yanegomi@gmail.com> wrote: > >> Signed-off-by: Garrett Cooper <gcooper@isilon.com> > > Thanks applied, Thanks! -Garrett -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/doc/generate b/doc/generate index 3152e1d..68a4cbd 100755 --- a/doc/generate +++ b/doc/generate @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh docdir=`dirname $0` mode=$1 diff --git a/perltidy.sh b/perltidy.sh index 512abdd..16cf552 100755 --- a/perltidy.sh +++ b/perltidy.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # # Copyright (c) 2009 Voltaire, Inc. All rights reserved. # Copyright (c) 2006 The Regents of the University of California. diff --git a/scripts/dump_lfts.sh b/scripts/dump_lfts.sh index 0bf334d..a07c211 100755 --- a/scripts/dump_lfts.sh +++ b/scripts/dump_lfts.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # # This simple script will collect outputs of ibroute for all switches # on the subnet and drop it on stdout. It can be used for LFTs dump diff --git a/scripts/dump_mfts.sh b/scripts/dump_mfts.sh index d6c2359..cdadba2 100755 --- a/scripts/dump_mfts.sh +++ b/scripts/dump_mfts.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # # This simple script will collect outputs of ibroute for all switches # on the subnet and drop it on stdout. It can be used for MFTs dump diff --git a/scripts/ibcheckerrors.in b/scripts/ibcheckerrors.in index ca40a68..6ebbe7f 100644 --- a/scripts/ibcheckerrors.in +++ b/scripts/ibcheckerrors.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-b] [-v] [-N | -nocolor]"\ "[<topology-file> | -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibcheckerrs.in b/scripts/ibcheckerrs.in index 4b34efc..1edd1eb 100644 --- a/scripts/ibcheckerrs.in +++ b/scripts/ibcheckerrs.in @@ -1,15 +1,15 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-b] [-v] [-G] [-T <threshold_file>]" \ "[-s(how_thresholds)] [-N \| -nocolor] [-C ca_name] [-P ca_port]" \ "[-t(imeout) timeout_ms] <lid|guid> [<port>]" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -21,7 +21,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return @@ -29,7 +29,7 @@ function red() { echo -e "\\033[1;031m" $1 "\\033[0;39m" } -function show_thresholds() { +show_thresholds() { echo "SymbolErrorCounter=$SymbolErrorCounter" echo "LinkErrorRecoveryCounter=$LinkErrorRecoveryCounter" echo "LinkDownedCounter=$LinkDownedCounter" @@ -44,7 +44,7 @@ function show_thresholds() { echo "VL15Dropped=$VL15Dropped" } -function get_thresholds() { +get_thresholds() { . $1 } diff --git a/scripts/ibchecknet.in b/scripts/ibchecknet.in index 75bc45a..3fd4ae7 100644 --- a/scripts/ibchecknet.in +++ b/scripts/ibchecknet.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor]" \ "[<topology-file> | -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibchecknode.in b/scripts/ibchecknode.in index eac8069..d70d5c8 100644 --- a/scripts/ibchecknode.in +++ b/scripts/ibchecknode.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor] [-G]" \ "[-C ca_name] [-P ca_port] [-t(imeout) timeout_ms] <lid|guid>" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -20,7 +20,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return diff --git a/scripts/ibcheckport.in b/scripts/ibcheckport.in index 3c8588e..16a8c24 100644 --- a/scripts/ibcheckport.in +++ b/scripts/ibcheckport.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor] [-G]" \ "[-C ca_name] [-P ca_port] [-t(imeout) timeout_ms] <lid|guid> <port>" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -20,7 +20,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return diff --git a/scripts/ibcheckportstate.in b/scripts/ibcheckportstate.in index eb5e304..c5fb948 100644 --- a/scripts/ibcheckportstate.in +++ b/scripts/ibcheckportstate.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor] [-G]" \ "[-C ca_name] [-P ca_port] [-t(imeout) timeout_ms] <lid|guid> <port>" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -20,7 +20,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return diff --git a/scripts/ibcheckportwidth.in b/scripts/ibcheckportwidth.in index 0df7a11..9cfca11 100644 --- a/scripts/ibcheckportwidth.in +++ b/scripts/ibcheckportwidth.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor] [-G]" \ "[-C ca_name] [-P ca_port] [-t(imeout) timeout_ms] <lid|guid> <port>" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -20,7 +20,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return diff --git a/scripts/ibcheckstate.in b/scripts/ibcheckstate.in index 8f85f7b..ce89df5 100644 --- a/scripts/ibcheckstate.in +++ b/scripts/ibcheckstate.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor]" \ "[<topology-file> | -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibcheckwidth.in b/scripts/ibcheckwidth.in index bf917fb..c8a08ee 100644 --- a/scripts/ibcheckwidth.in +++ b/scripts/ibcheckwidth.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-v] [-N | -nocolor]" \ "[<topology-file> \| -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibclearcounters.in b/scripts/ibclearcounters.in index 318fa84..789e02e 100644 --- a/scripts/ibclearcounters.in +++ b/scripts/ibclearcounters.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [<topology-file>" \ "| -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibclearerrors.in b/scripts/ibclearerrors.in index 4329ae6..ff7a452 100644 --- a/scripts/ibclearerrors.in +++ b/scripts/ibclearerrors.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-N | -nocolor] [<topology-file>" \ "| -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibdatacounters.in b/scripts/ibdatacounters.in index d7bf185..6f0389e 100644 --- a/scripts/ibdatacounters.in +++ b/scripts/ibdatacounters.in @@ -1,14 +1,14 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-b] [-v] [-N | -nocolor]" \ "[<topology-file> \| -C ca_name -P ca_port -t(imeout) timeout_ms]" exit -1 } -function user_abort() { +user_abort() { echo "Aborted" exit 1 } diff --git a/scripts/ibdatacounts.in b/scripts/ibdatacounts.in index ed5f85d..ac5f8c4 100644 --- a/scripts/ibdatacounts.in +++ b/scripts/ibdatacounts.in @@ -1,15 +1,15 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [-b] [-v] [-G] [-N | -nocolor]" \ "[-C ca_name] [-P ca_port] [-t(imeout) timeout_ms] <lid|guid>" \ "[<port>]" exit -1 } -function green() { +green() { if [ "$bw" = "yes" ]; then if [ "$verbose" = "yes" ]; then echo $1 @@ -21,7 +21,7 @@ function green() { fi } -function red() { +red() { if [ "$bw" = "yes" ]; then echo $1 return diff --git a/scripts/ibhosts.in b/scripts/ibhosts.in index 20abdf3..fda0541 100644 --- a/scripts/ibhosts.in +++ b/scripts/ibhosts.in @@ -1,8 +1,8 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [<topology-file> | -C ca_name" \ "-P ca_port -t timeout_ms]" exit -1 diff --git a/scripts/ibnodes.in b/scripts/ibnodes.in index 0726efc..5871da8 100644 --- a/scripts/ibnodes.in +++ b/scripts/ibnodes.in @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} diff --git a/scripts/ibrouters.in b/scripts/ibrouters.in index 71f4c60..ae66ca4 100644 --- a/scripts/ibrouters.in +++ b/scripts/ibrouters.in @@ -1,8 +1,8 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [<topology-file> | -C ca_name" \ "-P ca_port -t timeout_ms]" exit -1 diff --git a/scripts/ibstatus b/scripts/ibstatus index 6f01be0..f7fbbc2 100755 --- a/scripts/ibstatus +++ b/scripts/ibstatus @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # Usage ibstatus [devname[:port]] diff --git a/scripts/ibswitches.in b/scripts/ibswitches.in index 2a1bcae..0f3aa91 100644 --- a/scripts/ibswitches.in +++ b/scripts/ibswitches.in @@ -1,8 +1,8 @@ -#!/bin/bash +#!/bin/sh IBPATH=${IBPATH:-@IBSCRIPTPATH@} -function usage() { +usage() { echo Usage: `basename $0` "[-h] [<topology-file> | -C ca_name" \ "-P ca_port -t timeout_ms]" exit -1 diff --git a/scripts/set_nodedesc.sh b/scripts/set_nodedesc.sh index 1f08a54..1e42ac8 100755 --- a/scripts/set_nodedesc.sh +++ b/scripts/set_nodedesc.sh @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh if [ -f /etc/sysconfig/network ]; then . /etc/sysconfig/network