diff mbox

GPIO: OMAP: Fixed spurious IRQ issue for GPIO interrupts

Message ID 49D5C1A8.5090606@nokia.com (mailing list archive)
State Accepted
Commit da502fced01eef3610209b7bfb0eed7cc97fdac0
Headers show

Commit Message

Roger Quadros April 3, 2009, 7:58 a.m. UTC 
From: Roger Quadros <ext-roger.quadros@nokia.com>
Date: Fri, 3 Apr 2009 10:32:20 +0300
Subject: [PATCH] GPIO: OMAP: Fixed spurious IRQ issue for GPIO interrupts

Flush posted write to IRQSTATUS register in GPIO IRQ handler.
This eliminates the below error for all peripherals that use GPIO interrupts.

<4>Spurious irq 95: 0xffffffdf, please flush posted write for irq 31

Signed-off-by: Roger Quadros <ext-roger.quadros@nokia.com>
---
 arch/arm/plat-omap/gpio.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

Comments

Tony Lindgren April 3, 2009, 11:46 p.m. UTC | #1 
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.

Commit: da502fced01eef3610209b7bfb0eed7cc97fdac0

PatchWorks
http://patchwork.kernel.org/patch/16046/

Git
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=da502fced01eef3610209b7bfb0eed7cc97fdac0


--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 210a1c0..17d7afe 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -758,8 +758,12 @@  static void _clear_gpio_irqbank(struct gpio_bank *bank, int gpio_mask)
 
 	/* Workaround for clearing DSP GPIO interrupts to allow retention */
 #if defined(CONFIG_ARCH_OMAP24XX) || defined(CONFIG_ARCH_OMAP34XX)
+	reg = bank->base + OMAP24XX_GPIO_IRQSTATUS2;
 	if (cpu_is_omap24xx() || cpu_is_omap34xx())
-		__raw_writel(gpio_mask, bank->base + OMAP24XX_GPIO_IRQSTATUS2);
+		__raw_writel(gpio_mask, reg);
+
+	/* Flush posted write for the irq status to avoid spurious interrupts */
+	__raw_readl(reg);
 #endif
 }