pinctrl: nomadik: Staticize non-exported symbols

Commit Message

Axel Lin Nov. 15, 2012, 4:01 p.m. UTC

They are not referenced outside of this file, make them static.

Signed-off-by: Axel Lin <[e-mail]>
---
 drivers/pinctrl/pinctrl-nomadik.c |   26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

Comments

Lee Jones Nov. 15, 2012, 5:04 p.m. UTC | #1

On Fri, 16 Nov 2012, Axel Lin wrote:

> They are not referenced outside of this file, make them static.
> 
> Signed-off-by: Axel Lin <[e-mail]>
> ---
>  drivers/pinctrl/pinctrl-nomadik.c |   26 ++++++++++++--------------
>  1 file changed, 12 insertions(+), 14 deletions(-)

Seems sensible:

Acked-by: Lee Jones <[e-mail]>

Linus Walleij Nov. 15, 2012, 5:34 p.m. UTC | #2

On Thu, Nov 15, 2012 at 5:01 PM, Axel Lin <[e-mail]> wrote:

> They are not referenced outside of this file, make them static.
>
> Signed-off-by: Axel Lin <[e-mail]>

Applied with Lee's ACK, thanks!

Yours,
Linus Walleij

Patch

diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c
index 238060e..cf99e0a 100644
--- a/drivers/pinctrl/pinctrl-nomadik.c
+++ b/drivers/pinctrl/pinctrl-nomadik.c
@@ -1285,8 +1285,8 @@  void nmk_gpio_read_pull(int gpio_bank, u32 *pull_up)
 	}
 }
 
-int nmk_gpio_irq_map(struct irq_domain *d, unsigned int irq,
-			  irq_hw_number_t hwirq)
+static int nmk_gpio_irq_map(struct irq_domain *d, unsigned int irq,
+			    irq_hw_number_t hwirq)
 {
 	struct nmk_gpio_chip *nmk_chip = d->host_data;
 
@@ -1670,9 +1670,9 @@  static void nmk_pmx_disable(struct pinctrl_dev *pctldev,
 	dev_dbg(npct->dev, "disable group %s, %u pins\n", g->name, g->npins);
 }
 
-int nmk_gpio_request_enable(struct pinctrl_dev *pctldev,
-			    struct pinctrl_gpio_range *range,
-			    unsigned offset)
+static int nmk_gpio_request_enable(struct pinctrl_dev *pctldev,
+				   struct pinctrl_gpio_range *range,
+				   unsigned offset)
 {
 	struct nmk_pinctrl *npct = pinctrl_dev_get_drvdata(pctldev);
 	struct nmk_gpio_chip *nmk_chip;
@@ -1701,9 +1701,9 @@  int nmk_gpio_request_enable(struct pinctrl_dev *pctldev,
 	return 0;
 }
 
-void nmk_gpio_disable_free(struct pinctrl_dev *pctldev,
-			   struct pinctrl_gpio_range *range,
-			   unsigned offset)
+static void nmk_gpio_disable_free(struct pinctrl_dev *pctldev,
+				  struct pinctrl_gpio_range *range,
+				  unsigned offset)
 {
 	struct nmk_pinctrl *npct = pinctrl_dev_get_drvdata(pctldev);
 
@@ -1721,17 +1721,15 @@  static struct pinmux_ops nmk_pinmux_ops = {
 	.gpio_disable_free = nmk_gpio_disable_free,
 };
 
-int nmk_pin_config_get(struct pinctrl_dev *pctldev,
-		       unsigned pin,
-		       unsigned long *config)
+static int nmk_pin_config_get(struct pinctrl_dev *pctldev, unsigned pin,
+			      unsigned long *config)
 {
 	/* Not implemented */
 	return -EINVAL;
 }
 
-int nmk_pin_config_set(struct pinctrl_dev *pctldev,
-		       unsigned pin,
-		       unsigned long config)
+static int nmk_pin_config_set(struct pinctrl_dev *pctldev, unsigned pin,
+			      unsigned long config)
 {
 	static const char *pullnames[] = {
 		[NMK_GPIO_PULL_NONE]	= "none",