diff mbox

[2/4] ARM: imx: add imx5x usbmisc clock lookups

Message ID 1352988014-14769-3-git-send-email-m.grzeschik@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Michael Grzeschik Nov. 15, 2012, 2 p.m. UTC 
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 arch/arm/mach-imx/clk-imx51-imx53.c |    6 ++++++
 1 file changed, 6 insertions(+)

Comments

Sascha Hauer Nov. 16, 2012, 9:25 a.m. UTC | #1 
On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> ---
>  arch/arm/mach-imx/clk-imx51-imx53.c |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> index 3edd11c..33c3c9b 100644
> --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
>  	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
>  	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
>  	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> +	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> +	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> +	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");

Shawn, do you have plans to move the clock lookups to devicetree like
you did on i.MX6? It would be nice to get rid of patches like this.

Sascha
Sascha Hauer Nov. 16, 2012, 2:19 p.m. UTC | #2 
On Fri, Nov 16, 2012 at 10:28:48PM +0800, Shawn Guo wrote:
> On Fri, Nov 16, 2012 at 10:25:15AM +0100, Sascha Hauer wrote:
> > On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > > ---
> > >  arch/arm/mach-imx/clk-imx51-imx53.c |    6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > > diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> > > index 3edd11c..33c3c9b 100644
> > > --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> > > +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> > > @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
> > >  	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
> > >  	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
> > >  	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> > > +	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> > > +	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> > > +	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
> > 
> > Shawn, do you have plans to move the clock lookups to devicetree like
> > you did on i.MX6? It would be nice to get rid of patches like this.
> > 
> Right.  But I will not be able to resume the IMX cleanup work like this
> any soon, as I have some FSL internal stuff to sort out.  So please go
> ahead to do it.

I didn't have the intention to volunteer for this job ;)
Anyway, I'll see if I find time for this.

Sascha
Shawn Guo Nov. 16, 2012, 2:28 p.m. UTC | #3 
On Fri, Nov 16, 2012 at 10:25:15AM +0100, Sascha Hauer wrote:
> On Thu, Nov 15, 2012 at 03:00:12PM +0100, Michael Grzeschik wrote:
> > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > ---
> >  arch/arm/mach-imx/clk-imx51-imx53.c |    6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
> > index 3edd11c..33c3c9b 100644
> > --- a/arch/arm/mach-imx/clk-imx51-imx53.c
> > +++ b/arch/arm/mach-imx/clk-imx51-imx53.c
> > @@ -365,6 +365,9 @@ int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
> >  	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
> >  	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
> >  	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
> > +	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
> > +	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
> > +	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
> 
> Shawn, do you have plans to move the clock lookups to devicetree like
> you did on i.MX6? It would be nice to get rid of patches like this.
> 
Right.  But I will not be able to resume the IMX cleanup work like this
any soon, as I have some FSL internal stuff to sort out.  So please go
ahead to do it.

Shawn
Fabio Estevam Nov. 16, 2012, 5:48 p.m. UTC | #4 
Sascha,

On Fri, Nov 16, 2012 at 12:19 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:

> I didn't have the intention to volunteer for this job ;)
> Anyway, I'll see if I find time for this.

I sent a RFC patch for this conversion. Only built-tested, as I don't
have access to any mx5 board now.

Regards,

Fabio Estevam
diff mbox

Patch

diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c
index 3edd11c..33c3c9b 100644
--- a/arch/arm/mach-imx/clk-imx51-imx53.c
+++ b/arch/arm/mach-imx/clk-imx51-imx53.c
@@ -365,6 +365,9 @@  int __init mx51_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
 	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80000.usb");
 	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80000.usb");
 	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80000.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "73f80800.usbmisc");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "73f80800.usbmisc");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "73f80800.usbmisc");
 	clk_register_clkdev(clk[usb_phy_gate], "phy", "mxc-ehci.0");
 	clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx51.0");
 	clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx51.0");
@@ -470,6 +473,9 @@  int __init mx53_clocks_init(unsigned long rate_ckil, unsigned long rate_osc,
 	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80000.usb");
 	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80000.usb");
 	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80000.usb");
+	clk_register_clkdev(clk[usboh3_per_gate], "per", "53f80800.usbmisc");
+	clk_register_clkdev(clk[usboh3_gate], "ipg", "53f80800.usbmisc");
+	clk_register_clkdev(clk[usboh3_gate], "ahb", "53f80800.usbmisc");
 	clk_register_clkdev(clk[usb_phy1_gate], "usb_phy1", "mxc-ehci.0");
 	clk_register_clkdev(clk[esdhc1_ipg_gate], "ipg", "sdhci-esdhc-imx53.0");
 	clk_register_clkdev(clk[dummy], "ahb", "sdhci-esdhc-imx53.0");