| Message ID | fd576f198e6f3dc4031bb905247ed9c0a0b66a20.1352387305.git.viresh.kumar@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 8 November 2012 20:39, Viresh Kumar <viresh.kumar@linaro.org> wrote: > From: Vipul Kumar Samar <vipulkumar.samar@st.com> > > SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning. > This patch sets clk to 50 MHz in probe. > > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Ping!! -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 20 November 2012 12:11, Viresh Kumar <viresh.kumar@linaro.org> wrote: > On 8 November 2012 20:39, Viresh Kumar <viresh.kumar@linaro.org> wrote: >> From: Vipul Kumar Samar <vipulkumar.samar@st.com> >> >> SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning. >> This patch sets clk to 50 MHz in probe. >> >> Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > > Ping!! Hi Chris, Are you taking these for v3.8? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, Nov 08 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar <vipulkumar.samar@st.com> > > SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning. > This patch sets clk to 50 MHz in probe. > > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/mmc/host/sdhci-spear.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 6be89c0..fea8bf9 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -146,6 +146,11 @@ static int __devinit sdhci_probe(struct platform_device *pdev) > goto put_clk; > } > > + ret = clk_set_rate(sdhci->clk, 50000000); > + if (ret) > + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n", > + clk_get_rate(sdhci->clk)); > + > if (np) { > sdhci->data = sdhci_probe_config_dt(pdev); > if (IS_ERR(sdhci->data)) { Can I change this to a dev_err()? No-one's going to see a dev_dbg(). Thanks, - Chris.
On 26 November 2012 20:39, Chris Ball <cjb@laptop.org> wrote: > On Thu, Nov 08 2012, Viresh Kumar wrote: >> + ret = clk_set_rate(sdhci->clk, 50000000); >> + if (ret) >> + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n", >> + clk_get_rate(sdhci->clk)); >> + >> if (np) { >> sdhci->data = sdhci_probe_config_dt(pdev); >> if (IS_ERR(sdhci->data)) { > > Can I change this to a dev_err()? No-one's going to see a dev_dbg(). Yes and thanks :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Thu, Nov 08 2012, Viresh Kumar wrote: > From: Vipul Kumar Samar <vipulkumar.samar@st.com> > > SPEAr sdhci driver expects the clock to be set to 50 MHz for proper functioning. > This patch sets clk to 50 MHz in probe. > > Signed-off-by: Vipul Kumar Samar <vipulkumar.samar@st.com> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/mmc/host/sdhci-spear.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c > index 6be89c0..fea8bf9 100644 > --- a/drivers/mmc/host/sdhci-spear.c > +++ b/drivers/mmc/host/sdhci-spear.c > @@ -146,6 +146,11 @@ static int __devinit sdhci_probe(struct platform_device *pdev) > goto put_clk; > } > > + ret = clk_set_rate(sdhci->clk, 50000000); > + if (ret) > + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n", > + clk_get_rate(sdhci->clk)); > + > if (np) { > sdhci->data = sdhci_probe_config_dt(pdev); > if (IS_ERR(sdhci->data)) { Thanks, pushed to mmc-next for 3.8. - Chris.
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 6be89c0..fea8bf9 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -146,6 +146,11 @@ static int __devinit sdhci_probe(struct platform_device *pdev) goto put_clk; } + ret = clk_set_rate(sdhci->clk, 50000000); + if (ret) + dev_dbg(&pdev->dev, "Error setting desired clk, clk=%lu\n", + clk_get_rate(sdhci->clk)); + if (np) { sdhci->data = sdhci_probe_config_dt(pdev); if (IS_ERR(sdhci->data)) {