| Message ID | 1352900837-20759-2-git-send-email-lee.jones@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> Currently the BU21013 Touch Screen driver requests a regulator by the > name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The > correct name, as referenced in platform regulator code is 'avdd'. Here, > when we request a regulator, we use the correct name instead. > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org > Acked-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/input/touchscreen/bu21013_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c > index 5c487d2..2fae682 100644 > --- a/drivers/input/touchscreen/bu21013_ts.c > +++ b/drivers/input/touchscreen/bu21013_ts.c > @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client, > bu21013_data->chip = pdata; > bu21013_data->client = client; > > - bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); > + bu21013_data->regulator = regulator_get(&client->dev, "avdd"); > if (IS_ERR(bu21013_data->regulator)) { > dev_err(&client->dev, "regulator_get failed\n"); > error = PTR_ERR(bu21013_data->regulator); > -- > 1.7.9.5 Friendly poke for Dmitry.
On Wed, 14 Nov 2012, Lee Jones wrote: > Currently the BU21013 Touch Screen driver requests a regulator by the > name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The > correct name, as referenced in platform regulator code is 'avdd'. Here, > when we request a regulator, we use the correct name instead. > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > Cc: linux-input@vger.kernel.org > Acked-by: Arnd Bergmann <arnd@arndb.de> > Acked-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > drivers/input/touchscreen/bu21013_ts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c > index 5c487d2..2fae682 100644 > --- a/drivers/input/touchscreen/bu21013_ts.c > +++ b/drivers/input/touchscreen/bu21013_ts.c > @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client, > bu21013_data->chip = pdata; > bu21013_data->client = client; > > - bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); > + bu21013_data->regulator = regulator_get(&client->dev, "avdd"); > if (IS_ERR(bu21013_data->regulator)) { > dev_err(&client->dev, "regulator_get failed\n"); > error = PTR_ERR(bu21013_data->regulator); > -- > 1.7.9.5 Did you see this one also Dmitry?
On Mon, Nov 26, 2012 at 12:16:18PM +0000, Lee Jones wrote: > On Wed, 14 Nov 2012, Lee Jones wrote: > > > Currently the BU21013 Touch Screen driver requests a regulator by the > > name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The > > correct name, as referenced in platform regulator code is 'avdd'. Here, > > when we request a regulator, we use the correct name instead. > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: linux-input@vger.kernel.org > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > drivers/input/touchscreen/bu21013_ts.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c > > index 5c487d2..2fae682 100644 > > --- a/drivers/input/touchscreen/bu21013_ts.c > > +++ b/drivers/input/touchscreen/bu21013_ts.c > > @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client, > > bu21013_data->chip = pdata; > > bu21013_data->client = client; > > > > - bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); > > + bu21013_data->regulator = regulator_get(&client->dev, "avdd"); > > if (IS_ERR(bu21013_data->regulator)) { > > dev_err(&client->dev, "regulator_get failed\n"); > > error = PTR_ERR(bu21013_data->regulator); > > -- > > 1.7.9.5 > > Did you see this one also Dmitry? Yes, I have it, I am waiting for the other 2 patches in series to settle.
On Mon, 26 Nov 2012, Dmitry Torokhov wrote: > On Mon, Nov 26, 2012 at 12:16:18PM +0000, Lee Jones wrote: > > On Wed, 14 Nov 2012, Lee Jones wrote: > > > > > Currently the BU21013 Touch Screen driver requests a regulator by the > > > name of 'V-TOUCH', which doesn't exist anywhere in the kernel. The > > > correct name, as referenced in platform regulator code is 'avdd'. Here, > > > when we request a regulator, we use the correct name instead. > > > > > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > Cc: linux-input@vger.kernel.org > > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > > --- > > > drivers/input/touchscreen/bu21013_ts.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c > > > index 5c487d2..2fae682 100644 > > > --- a/drivers/input/touchscreen/bu21013_ts.c > > > +++ b/drivers/input/touchscreen/bu21013_ts.c > > > @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client, > > > bu21013_data->chip = pdata; > > > bu21013_data->client = client; > > > > > > - bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); > > > + bu21013_data->regulator = regulator_get(&client->dev, "avdd"); > > > if (IS_ERR(bu21013_data->regulator)) { > > > dev_err(&client->dev, "regulator_get failed\n"); > > > error = PTR_ERR(bu21013_data->regulator); > > > -- > > > 1.7.9.5 > > > > Did you see this one also Dmitry? > > Yes, I have it, I am waiting for the other 2 patches in series to > settle. This patch is unrelated to the others and fixes a bug. Would you be kind enough to take it in right away please?
diff --git a/drivers/input/touchscreen/bu21013_ts.c b/drivers/input/touchscreen/bu21013_ts.c index 5c487d2..2fae682 100644 --- a/drivers/input/touchscreen/bu21013_ts.c +++ b/drivers/input/touchscreen/bu21013_ts.c @@ -461,7 +461,7 @@ static int __devinit bu21013_probe(struct i2c_client *client, bu21013_data->chip = pdata; bu21013_data->client = client; - bu21013_data->regulator = regulator_get(&client->dev, "V-TOUCH"); + bu21013_data->regulator = regulator_get(&client->dev, "avdd"); if (IS_ERR(bu21013_data->regulator)) { dev_err(&client->dev, "regulator_get failed\n"); error = PTR_ERR(bu21013_data->regulator);