diff mbox

[PATCHv2] rt2x00: Use addr_mask to disallow invalid MAC addresses in mutli-bssid mode

Message ID 1354094932-15703-1-git-send-email-helmut.schaa@googlemail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Helmut Schaa Nov. 28, 2012, 9:28 a.m. UTC
Reported-by: Petr Stetiar <ynezz@true.cz>
Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>
---
 drivers/net/wireless/rt2x00/rt2x00dev.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

Comments

Gertjan van Wingerde Nov. 28, 2012, 10:06 a.m. UTC | #1
On Wed, Nov 28, 2012 at 10:28 AM, Helmut Schaa
<helmut.schaa@googlemail.com> wrote:
> Reported-by: Petr Stetiar <ynezz@true.cz>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 69097d1..f9d9754 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1182,6 +1182,13 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
>         rt2x00dev->hw->vif_data_size = sizeof(struct rt2x00_intf);
>
>         /*
> +        * rt2x00 devices can only use the last n bits of the MAC address
> +        * for virtual interfaces.
> +        */
> +       rt2x00dev->hw->wiphy->addr_mask[ETH_ALEN - 1] =
> +               (rt2x00dev->ops->max_ap_intf - 1);
> +
> +       /*
>          * Determine which operating modes are supported, all modes
>          * which require beaconing, depend on the availability of
>          * beacon entries.
> --
> 1.7.7
>
Ivo van Doorn Nov. 28, 2012, 10:08 a.m. UTC | #2
Hi,

> Reported-by: Petr Stetiar <ynezz@true.cz>
> Signed-off-by: Helmut Schaa <helmut.schaa@googlemail.com>

Acked-by: Ivo van Doorn <IvDoorn@gmail.com>

> ---
>  drivers/net/wireless/rt2x00/rt2x00dev.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 69097d1..f9d9754 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1182,6 +1182,13 @@ int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
>         rt2x00dev->hw->vif_data_size = sizeof(struct rt2x00_intf);
>
>         /*
> +        * rt2x00 devices can only use the last n bits of the MAC address
> +        * for virtual interfaces.
> +        */
> +       rt2x00dev->hw->wiphy->addr_mask[ETH_ALEN - 1] =
> +               (rt2x00dev->ops->max_ap_intf - 1);
> +
> +       /*
>          * Determine which operating modes are supported, all modes
>          * which require beaconing, depend on the availability of
>          * beacon entries.
> --
> 1.7.7
>
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 69097d1..f9d9754 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1182,6 +1182,13 @@  int rt2x00lib_probe_dev(struct rt2x00_dev *rt2x00dev)
 	rt2x00dev->hw->vif_data_size = sizeof(struct rt2x00_intf);
 
 	/*
+	 * rt2x00 devices can only use the last n bits of the MAC address
+	 * for virtual interfaces.
+	 */
+	rt2x00dev->hw->wiphy->addr_mask[ETH_ALEN - 1] =
+		(rt2x00dev->ops->max_ap_intf - 1);
+
+	/*
 	 * Determine which operating modes are supported, all modes
 	 * which require beaconing, depend on the availability of
 	 * beacon entries.