diff mbox

GPIO: MVEBU: Fix so only built when CONFIG_OF_IRQ

Message ID 1354463099-6121-1-git-send-email-andrew@lunn.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Andrew Lunn Dec. 2, 2012, 3:44 p.m. UTC
This driver only builds when CONFIG_OF_IRQ is enabled. So add this as
a dependency. Dockstar, and other none DT boards don't build because
of this, when all other OF boards are disabled.

Reported-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Willy Tarreau <w@1wt.eu>
---
 drivers/gpio/Kconfig |    1 +
 1 file changed, 1 insertion(+)

Comments

Linus Walleij Dec. 3, 2012, 11:01 p.m. UTC | #1
On Sun, Dec 2, 2012 at 4:44 PM, Andrew Lunn <andrew@lunn.ch> wrote:

> This driver only builds when CONFIG_OF_IRQ is enabled. So add this as
> a dependency. Dockstar, and other none DT boards don't build because
> of this, when all other OF boards are disabled.
>
> Reported-by: Willy Tarreau <w@1wt.eu>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Willy Tarreau <w@1wt.eu>
> ---
>  drivers/gpio/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 6dbc403..4d84c17 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -153,6 +153,7 @@ config GPIO_MSM_V2
>  config GPIO_MVEBU
>         def_bool y
>         depends on PLAT_ORION
> +       depends on OF_IRQ
>         select GPIO_GENERIC
>         select GENERIC_IRQ_CHIP

This does not apply to the GPIO tree, I assume it's intended for the
MVEBU tree.
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Jason Cooper Jan. 6, 2013, 5:37 p.m. UTC | #2
On Sun, Dec 02, 2012 at 04:44:59PM +0100, Andrew Lunn wrote:
> This driver only builds when CONFIG_OF_IRQ is enabled. So add this as
> a dependency. Dockstar, and other none DT boards don't build because
> of this, when all other OF boards are disabled.
> 
> Reported-by: Willy Tarreau <w@1wt.eu>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Tested-by: Willy Tarreau <w@1wt.eu>
> ---
>  drivers/gpio/Kconfig |    1 +
>  1 file changed, 1 insertion(+)

I believe this was superceded by:

bc1008c gpio/mvebu-gpio: Make mvebu-gpio depend on OF_CONFIG

by Gregory.

thx,

Jason.
diff mbox

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 6dbc403..4d84c17 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -153,6 +153,7 @@  config GPIO_MSM_V2
 config GPIO_MVEBU
 	def_bool y
 	depends on PLAT_ORION
+	depends on OF_IRQ
 	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP