diff mbox

HID: uhid: use __packed__ for uhid_feature_answer_req

Message ID 1355746843-14015-1-git-send-email-dh.herrmann@googlemail.com (mailing list archive)
State New, archived
Delegated to: Jiri Kosina
Headers show

Commit Message

David Herrmann Dec. 17, 2012, 12:20 p.m. UTC 
We use __packed__ for all API structures so we can extend them without
breaking alignment rules. We do try to explicitly align the structures,
but to be safe we also use __packed__.
uhid_feature_answer_req is already 64bit aligned so we can add __packed__
without breaking ABI.

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 include/uapi/linux/uhid.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Kosina Jan. 3, 2013, 9:40 a.m. UTC | #1 
On Mon, 17 Dec 2012, David Herrmann wrote:

> We use __packed__ for all API structures so we can extend them without
> breaking alignment rules. We do try to explicitly align the structures,
> but to be safe we also use __packed__.
> uhid_feature_answer_req is already 64bit aligned so we can add __packed__
> without breaking ABI.
> 
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>

Applied, thanks David.
diff mbox

Patch

diff --git a/include/uapi/linux/uhid.h b/include/uapi/linux/uhid.h
index 9c6974f..e9ed951 100644
--- a/include/uapi/linux/uhid.h
+++ b/include/uapi/linux/uhid.h
@@ -86,7 +86,7 @@  struct uhid_feature_answer_req {
 	__u16 err;
 	__u16 size;
 	__u8 data[UHID_DATA_MAX];
-};
+} __attribute__((__packed__));
 
 struct uhid_event {
 	__u32 type;