| Message ID | 201301032127.34467.sshtylyov@ru.mvista.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Sergei, On 1/3/2013 11:57 PM, Sergei Shtylyov wrote: > Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF > support for davinci nand controller) has never been really build tested with > the driver as a module. When the driver is built-in, the missing semicolon > after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro > being empty and so the initializer using the trailing semicolon on the next > line; when the driver is built as a module, compilation error ensues, and as > the 'davinci_all_defconfig' has the NAND driver modular, this error prevents > DaVinci family kernel from building... > > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > Cc: stable@vger.kernel.org # 3.7 > > --- > The patch is atop of the recent Linus' tree. > Sekhar, have you build tested at least 3.8-rc1? v3.8-rc2 builds and boots fine. 'make modules' needs your patch, of course. For this patch, FWIW: Acked-by: Sekhar Nori <nsekhar@ti.com> Thanks, Sekhar
Hello Sergei On 03.01.2013 19:27, Sergei Shtylyov wrote: > Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF > support for davinci nand controller) has never been really build tested with > the driver as a module. When the driver is built-in, the missing semicolon > after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro > being empty and so the initializer using the trailing semicolon on the next > line; when the driver is built as a module, compilation error ensues, and as > the 'davinci_all_defconfig' has the NAND driver modular, this error prevents > DaVinci family kernel from building... > > Signed-off-by: Sergei Shtylyov<sshtylyov@ru.mvista.com> > Cc: stable@vger.kernel.org # 3.7 > > --- > The patch is atop of the recent Linus' tree. > Sekhar, have you build tested at least 3.8-rc1? > > drivers/mtd/nand/davinci_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux/drivers/mtd/nand/davinci_nand.c > =================================================================== > --- linux.orig/drivers/mtd/nand/davinci_nand.c > +++ linux/drivers/mtd/nand/davinci_nand.c > @@ -523,7 +523,7 @@ static struct nand_ecclayout hwecc4_2048 > static const struct of_device_id davinci_nand_of_match[] = { > {.compatible = "ti,davinci-nand", }, > {}, > -} > +}; > MODULE_DEVICE_TABLE(of, davinci_nand_of_match); > > static struct davinci_nand_pdata Acked-by: Heiko Schocher <hs@denx.de> Thanks for detecting this! bye, Heiko
On Fri, 2013-01-11 at 20:44 +0300, Sergei Shtylyov wrote: > > > The patch is atop of the recent Linus' tree. > > OK, a week has passed. Anybody going to queue this up for 3.8? I've just applied it to my tree; I'll send it in a day or so. Thanks for the reminder.
Hello. On 01/03/2013 09:27 PM, Sergei Shtylyov wrote: > Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF > support for davinci nand controller) has never been really build tested with > the driver as a module. When the driver is built-in, the missing semicolon > after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro > being empty and so the initializer using the trailing semicolon on the next > line; when the driver is built as a module, compilation error ensues, and as > the 'davinci_all_defconfig' has the NAND driver modular, this error prevents > DaVinci family kernel from building... > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> > Cc: stable@vger.kernel.org # 3.7 > --- > The patch is atop of the recent Linus' tree. OK, a week has passed. Anybody going to queue this up for 3.8? WBR, Sergei
Index: linux/drivers/mtd/nand/davinci_nand.c =================================================================== --- linux.orig/drivers/mtd/nand/davinci_nand.c +++ linux/drivers/mtd/nand/davinci_nand.c @@ -523,7 +523,7 @@ static struct nand_ecclayout hwecc4_2048 static const struct of_device_id davinci_nand_of_match[] = { {.compatible = "ti,davinci-nand", }, {}, -} +}; MODULE_DEVICE_TABLE(of, davinci_nand_of_match); static struct davinci_nand_pdata
Commit cdeadd712f52b16a9285386d61ee26fd14eb4085 (mtd: nand: davinci: add OF support for davinci nand controller) has never been really build tested with the driver as a module. When the driver is built-in, the missing semicolon after structure initializer is "compensated" by MODULE_DEVICE_TABLE() macro being empty and so the initializer using the trailing semicolon on the next line; when the driver is built as a module, compilation error ensues, and as the 'davinci_all_defconfig' has the NAND driver modular, this error prevents DaVinci family kernel from building... Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Cc: stable@vger.kernel.org # 3.7 --- The patch is atop of the recent Linus' tree. Sekhar, have you build tested at least 3.8-rc1? drivers/mtd/nand/davinci_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)