| Message ID | 1358243670-11935-5-git-send-email-ezequiel.garcia@free-electrons.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Tue, Jan 15, 2013 at 6:54 PM, Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote: > Cc: Lior Amsalem <alior@marvell.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> > --- > arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts > index b24644f..55f5b6f 100644 > --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts > +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts > @@ -127,5 +127,14 @@ > nr-ports = <2>; > status = "okay"; > }; > + usb@d0050000 { > + status = "okay"; > + }; > + usb@d0051000 { > + status = "okay"; > + }; > + usb@d0052000 { > + status = "okay"; > + }; USB2 of openblocks-ax3-4 is used as Mini-PCIE. I think this is unnecessary. > }; > }; > -- > 1.7.8.6 > Best regards, Nobuhiro
Hi Nobuhiro, On Tue, Jan 15, 2013 at 9:01 PM, Nobuhiro Iwamatsu <iwamatsu@nigauri.org> wrote: > Hi, > > > > On Tue, Jan 15, 2013 at 6:54 PM, Ezequiel Garcia > <ezequiel.garcia@free-electrons.com> wrote: >> Cc: Lior Amsalem <alior@marvell.com> >> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> >> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> >> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> >> --- >> arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 9 +++++++++ >> 1 files changed, 9 insertions(+), 0 deletions(-) >> >> diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts >> index b24644f..55f5b6f 100644 >> --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts >> +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts >> @@ -127,5 +127,14 @@ >> nr-ports = <2>; >> status = "okay"; >> }; >> + usb@d0050000 { >> + status = "okay"; >> + }; >> + usb@d0051000 { >> + status = "okay"; >> + }; >> + usb@d0052000 { >> + status = "okay"; >> + }; > USB2 of openblocks-ax3-4 is used as Mini-PCIE. > I think this is unnecessary. > Mmm... could you explain this with some more detail. Unfortunately, I don't have access to an Openblocks board to check on this, so I'd appreciate any clarification. Is there any Openblocks datasheet or hardware schematics publicly available for me to look at? Thanks a lot,
Dear Ezequiel Garcia, On Wed, 16 Jan 2013 16:16:59 -0300, Ezequiel Garcia wrote: > >> + usb@d0050000 { > >> + status = "okay"; > >> + }; > >> + usb@d0051000 { > >> + status = "okay"; > >> + }; > >> + usb@d0052000 { > >> + status = "okay"; > >> + }; > > USB2 of openblocks-ax3-4 is used as Mini-PCIE. > > I think this is unnecessary. > > Mmm... could you explain this with some more detail. > Unfortunately, I don't have access to an Openblocks board to check on > this, so I'd appreciate any clarification. > > Is there any Openblocks datasheet or hardware schematics publicly > available for me to look at? As far as I know, there is no public document. I've been given access to a PDF, in Japanese, that gives some details about the hardware. From what I can read, only 2 USB ports are used from the internal Marvell EHCI controller. Another USB port is available, but it is connected to a USB controller that sits on the PCIe bus. And the PCIe interface on which this USB controller is connected is not enabled in the default U-Boot shipped with AX3-4 (at least not with the generation I have). I've been given an U-Boot version that is supposed to enable this PCIe interface, but I haven't tested yet. Anyway, from a Marvell EHCI controller perspective, only two ports are used, as Nobuhiro said. I am not sure which ports, but it seems like the first two ones were used. One of the two physical ports is a combined USB / eSATA port, but I don't think this makes any difference at the software level. I don't have the OpenBlocks AX3-4 with me right now, but I could probably make a test on Friday. Best regards, Thomas
Hi, Thomas, Thank you for the detailed explanation. Ezequiel, I checked your patch on OpenBlocks AX3, work fine. But I have a question. your patch "arm: mvebu: Add support for USB host controllers in Armada 370/XP" was set USB controller of 0xd0050000 to IRQ 45. I think this is 47, and 0xd0052000 is 45. Because manual has been written irq 45 is USB2. I'm sorry if if my lack of understanding or typo in the manual. Best regards, Nobuhiro On Thu, Jan 17, 2013 at 4:37 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Ezequiel Garcia, > > On Wed, 16 Jan 2013 16:16:59 -0300, Ezequiel Garcia wrote: > >> >> + usb@d0050000 { >> >> + status = "okay"; >> >> + }; >> >> + usb@d0051000 { >> >> + status = "okay"; >> >> + }; >> >> + usb@d0052000 { >> >> + status = "okay"; >> >> + }; >> > USB2 of openblocks-ax3-4 is used as Mini-PCIE. >> > I think this is unnecessary. >> >> Mmm... could you explain this with some more detail. >> Unfortunately, I don't have access to an Openblocks board to check on >> this, so I'd appreciate any clarification. >> >> Is there any Openblocks datasheet or hardware schematics publicly >> available for me to look at? > > As far as I know, there is no public document. I've been given access > to a PDF, in Japanese, that gives some details about the hardware. > > From what I can read, only 2 USB ports are used from the internal > Marvell EHCI controller. > > Another USB port is available, but it is connected to a USB controller > that sits on the PCIe bus. And the PCIe interface on which this USB > controller is connected is not enabled in the default U-Boot shipped > with AX3-4 (at least not with the generation I have). I've been given > an U-Boot version that is supposed to enable this PCIe interface, but I > haven't tested yet. > > Anyway, from a Marvell EHCI controller perspective, only two ports are > used, as Nobuhiro said. I am not sure which ports, but it seems like > the first two ones were used. One of the two physical ports is a > combined USB / eSATA port, but I don't think this makes any difference > at the software level. > > I don't have the OpenBlocks AX3-4 with me right now, but I could > probably make a test on Friday. > > Best regards, > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com
On 01/19/2013 01:07 AM, Nobuhiro Iwamatsu wrote: > Hi, > > Thomas, Thank you for the detailed explanation. > > Ezequiel, I checked your patch on OpenBlocks AX3, work fine. > > But I have a question. your patch "arm: mvebu: Add support for USB > host controllers in Armada 370/XP" > was set USB controller of 0xd0050000 to IRQ 45. I think this is 47, > and 0xd0052000 is 45. > Because manual has been written irq 45 is USB2. > I'm sorry if if my lack of understanding or typo in the manual. It was a typo in the manual, and we have spent some time to figure it out!
Hi, On Sat, Jan 19, 2013 at 9:11 AM, Gregory CLEMENT <gregory.clement@free-electrons.com> wrote: > On 01/19/2013 01:07 AM, Nobuhiro Iwamatsu wrote: >> Hi, >> >> Thomas, Thank you for the detailed explanation. >> >> Ezequiel, I checked your patch on OpenBlocks AX3, work fine. >> >> But I have a question. your patch "arm: mvebu: Add support for USB >> host controllers in Armada 370/XP" >> was set USB controller of 0xd0050000 to IRQ 45. I think this is 47, >> and 0xd0052000 is 45. >> Because manual has been written irq 45 is USB2. >> I'm sorry if if my lack of understanding or typo in the manual. > > It was a typo in the manual, and we have spent some time to figure > it out! > I see, thanks for your comment. Tested-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org> Nobuhiro
diff --git a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts index b24644f..55f5b6f 100644 --- a/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts +++ b/arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts @@ -127,5 +127,14 @@ nr-ports = <2>; status = "okay"; }; + usb@d0050000 { + status = "okay"; + }; + usb@d0051000 { + status = "okay"; + }; + usb@d0052000 { + status = "okay"; + }; }; };
Cc: Lior Amsalem <alior@marvell.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com> --- arch/arm/boot/dts/armada-xp-openblocks-ax3-4.dts | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-)