diff mbox

mmc: sdhci-esdhc-imx: Remove unused variables

Message ID 1358383916-23614-1-git-send-email-festevam@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Jan. 17, 2013, 12:51 a.m. UTC 
From: Fabio Estevam <fabio.estevam@freescale.com>

commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after 
probe) introduced the following build warnings:

drivers/mmc/host/sdhci-esdhc-imx.c:149:30: warning: unused variable 'boarddata' [-Wunused-variable]
drivers/mmc/host/sdhci-esdhc-imx.c:181:30: warning: unused variable 'boarddata' [-Wunused-variable]

Remove the unused variables.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mmc/host/sdhci-esdhc-imx.c |    5 -----
 1 file changed, 5 deletions(-)

Comments

Shawn Guo Jan. 17, 2013, 2:25 a.m. UTC | #1 
On Wed, Jan 16, 2013 at 10:51:56PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after 
> probe) introduced the following build warnings:
> 
My bad.  The warnings are introduced by my commit 78b2b04 (mmc:
sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from IO accessory).

So with the commit log corrected,

Acked-by: Shawn Guo <shawn.guo@linaro.org>

> drivers/mmc/host/sdhci-esdhc-imx.c:149:30: warning: unused variable 'boarddata' [-Wunused-variable]
> drivers/mmc/host/sdhci-esdhc-imx.c:181:30: warning: unused variable 'boarddata' [-Wunused-variable]
> 
> Remove the unused variables.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Fabio Estevam Jan. 17, 2013, 2:31 a.m. UTC | #2 
On Thu, Jan 17, 2013 at 12:25 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Wed, Jan 16, 2013 at 10:51:56PM -0200, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> commit 842afc02cf (mmc: sdhci-esdhc-imx: do not reference platform data after
>> probe) introduced the following build warnings:
>>
> My bad.  The warnings are introduced by my commit 78b2b04 (mmc:

I guess you meant 3f175a6e5 instead. Will fix it in v2.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index ae68bc9..509be3a 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -144,10 +144,6 @@  static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i
 
 static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
 {
-	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
-	struct pltfm_imx_data *imx_data = pltfm_host->priv;
-	struct esdhc_platform_data *boarddata = &imx_data->boarddata;
-
 	u32 val = readl(host->ioaddr + reg);
 
 	if (unlikely(reg == SDHCI_CAPABILITIES)) {
@@ -178,7 +174,6 @@  static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg)
 {
 	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
 	struct pltfm_imx_data *imx_data = pltfm_host->priv;
-	struct esdhc_platform_data *boarddata = &imx_data->boarddata;
 	u32 data;
 
 	if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) {