Message ID | 20130116175726.29147.57548.stgit@ubuntu (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Christoffer, On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: > diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > index a3f3792..6ef8afd 100644 > --- a/arch/arm/include/asm/pgtable-3level.h > +++ b/arch/arm/include/asm/pgtable-3level.h > @@ -104,11 +104,29 @@ > */ > #define L_PGD_SWAPPER (_AT(pgdval_t, 1) << 55) /* swapper_pg_dir entry */ > > +/* > + * 2nd stage PTE definitions for LPAE. > + */ > +#define L_PTE_S2_MT_UNCACHED (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */ > +#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */ > +#define L_PTE_S2_MT_WRITEBACK (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */ > +#define L_PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[1] */ > +#define L_PTE_S2_RDWR (_AT(pteval_t, 2) << 6) /* HAP[2:1] */ Why is this called L_PTE_S2_RDWR? The ARM ARM shows HAP[2:1] as 0b11 for read/write and 0b10 for WRONLY. > --- a/arch/arm/include/asm/pgtable.h > +++ b/arch/arm/include/asm/pgtable.h > @@ -70,6 +70,9 @@ extern void __pgd_error(const char *file, int line, pgd_t); > > extern pgprot_t pgprot_user; > extern pgprot_t pgprot_kernel; > +extern pgprot_t pgprot_hyp_device; > +extern pgprot_t pgprot_s2; > +extern pgprot_t pgprot_s2_device; > > #define _MOD_PROT(p, b) __pgprot(pgprot_val(p) | (b)) > > @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; > #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) > #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) > #define PAGE_KERNEL_EXEC pgprot_kernel > +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) > +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) > +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) > +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) Are these S2 read-only by default?
On Thu, Jan 24, 2013 at 6:39 AM, Catalin Marinas <catalin.marinas@arm.com> wrote: > Hi Christoffer, > > On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: >> diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h >> index a3f3792..6ef8afd 100644 >> --- a/arch/arm/include/asm/pgtable-3level.h >> +++ b/arch/arm/include/asm/pgtable-3level.h >> @@ -104,11 +104,29 @@ >> */ >> #define L_PGD_SWAPPER (_AT(pgdval_t, 1) << 55) /* swapper_pg_dir entry */ >> >> +/* >> + * 2nd stage PTE definitions for LPAE. >> + */ >> +#define L_PTE_S2_MT_UNCACHED (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */ >> +#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */ >> +#define L_PTE_S2_MT_WRITEBACK (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */ >> +#define L_PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[1] */ >> +#define L_PTE_S2_RDWR (_AT(pteval_t, 2) << 6) /* HAP[2:1] */ > > Why is this called L_PTE_S2_RDWR? The ARM ARM shows HAP[2:1] as 0b11 for > read/write and 0b10 for WRONLY. > it should be +#define L_PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ >> --- a/arch/arm/include/asm/pgtable.h >> +++ b/arch/arm/include/asm/pgtable.h >> @@ -70,6 +70,9 @@ extern void __pgd_error(const char *file, int line, pgd_t); >> >> extern pgprot_t pgprot_user; >> extern pgprot_t pgprot_kernel; >> +extern pgprot_t pgprot_hyp_device; >> +extern pgprot_t pgprot_s2; >> +extern pgprot_t pgprot_s2_device; >> >> #define _MOD_PROT(p, b) __pgprot(pgprot_val(p) | (b)) >> >> @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; >> #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) >> #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) >> #define PAGE_KERNEL_EXEC pgprot_kernel >> +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) >> +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) >> +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) >> +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) > > Are these S2 read-only by default? > not sure I understand what you're asking here? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 24, 2013 at 04:05:33PM +0000, Christoffer Dall wrote: > On Thu, Jan 24, 2013 at 6:39 AM, Catalin Marinas > <catalin.marinas@arm.com> wrote: > > On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: > >> diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h > >> index a3f3792..6ef8afd 100644 > >> --- a/arch/arm/include/asm/pgtable-3level.h > >> +++ b/arch/arm/include/asm/pgtable-3level.h > >> @@ -104,11 +104,29 @@ > >> */ > >> #define L_PGD_SWAPPER (_AT(pgdval_t, 1) << 55) /* swapper_pg_dir entry */ > >> > >> +/* > >> + * 2nd stage PTE definitions for LPAE. > >> + */ > >> +#define L_PTE_S2_MT_UNCACHED (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */ > >> +#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */ > >> +#define L_PTE_S2_MT_WRITEBACK (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */ > >> +#define L_PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[1] */ > >> +#define L_PTE_S2_RDWR (_AT(pteval_t, 2) << 6) /* HAP[2:1] */ > > > > Why is this called L_PTE_S2_RDWR? The ARM ARM shows HAP[2:1] as 0b11 for > > read/write and 0b10 for WRONLY. > > it should be > > +#define L_PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ OK. > > >> --- a/arch/arm/include/asm/pgtable.h > >> +++ b/arch/arm/include/asm/pgtable.h > >> @@ -70,6 +70,9 @@ extern void __pgd_error(const char *file, int line, pgd_t); > >> > >> extern pgprot_t pgprot_user; > >> extern pgprot_t pgprot_kernel; > >> +extern pgprot_t pgprot_hyp_device; > >> +extern pgprot_t pgprot_s2; > >> +extern pgprot_t pgprot_s2_device; > >> > >> #define _MOD_PROT(p, b) __pgprot(pgprot_val(p) | (b)) > >> > >> @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; > >> #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) > >> #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) > >> #define PAGE_KERNEL_EXEC pgprot_kernel > >> +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) > >> +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) > >> +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) > >> +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) > > > > Are these S2 read-only by default? > > not sure I understand what you're asking here? Why do you pass L_PTE_S2_RDONLY? Do you need to restrict guest writes via the stage 2 attributes?
On Thu, Jan 24, 2013 at 12:02 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Thu, Jan 24, 2013 at 04:05:33PM +0000, Christoffer Dall wrote: >> On Thu, Jan 24, 2013 at 6:39 AM, Catalin Marinas >> <catalin.marinas@arm.com> wrote: >> > On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: >> >> diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h >> >> index a3f3792..6ef8afd 100644 >> >> --- a/arch/arm/include/asm/pgtable-3level.h >> >> +++ b/arch/arm/include/asm/pgtable-3level.h >> >> @@ -104,11 +104,29 @@ >> >> */ >> >> #define L_PGD_SWAPPER (_AT(pgdval_t, 1) << 55) /* swapper_pg_dir entry */ >> >> >> >> +/* >> >> + * 2nd stage PTE definitions for LPAE. >> >> + */ >> >> +#define L_PTE_S2_MT_UNCACHED (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */ >> >> +#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */ >> >> +#define L_PTE_S2_MT_WRITEBACK (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */ >> >> +#define L_PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[1] */ >> >> +#define L_PTE_S2_RDWR (_AT(pteval_t, 2) << 6) /* HAP[2:1] */ >> > >> > Why is this called L_PTE_S2_RDWR? The ARM ARM shows HAP[2:1] as 0b11 for >> > read/write and 0b10 for WRONLY. >> >> it should be >> >> +#define L_PTE_S2_RDWR (_AT(pteval_t, 3) << 6) /* HAP[2:1] */ > > OK. > >> >> >> --- a/arch/arm/include/asm/pgtable.h >> >> +++ b/arch/arm/include/asm/pgtable.h >> >> @@ -70,6 +70,9 @@ extern void __pgd_error(const char *file, int line, pgd_t); >> >> >> >> extern pgprot_t pgprot_user; >> >> extern pgprot_t pgprot_kernel; >> >> +extern pgprot_t pgprot_hyp_device; >> >> +extern pgprot_t pgprot_s2; >> >> +extern pgprot_t pgprot_s2_device; >> >> >> >> #define _MOD_PROT(p, b) __pgprot(pgprot_val(p) | (b)) >> >> >> >> @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; >> >> #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) >> >> #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) >> >> #define PAGE_KERNEL_EXEC pgprot_kernel >> >> +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) >> >> +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) >> >> +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) >> >> +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) >> > >> > Are these S2 read-only by default? >> >> not sure I understand what you're asking here? > > Why do you pass L_PTE_S2_RDONLY? Do you need to restrict guest writes > via the stage 2 attributes? > yes, for example when KSM merges two pages, then it must be mapped read-only to the guest so that we catch writes and perform COW. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 24, 2013 at 05:04:32PM +0000, Christoffer Dall wrote: > On Thu, Jan 24, 2013 at 12:02 PM, Catalin Marinas > <catalin.marinas@arm.com> wrote: > > On Thu, Jan 24, 2013 at 04:05:33PM +0000, Christoffer Dall wrote: > >> On Thu, Jan 24, 2013 at 6:39 AM, Catalin Marinas > >> <catalin.marinas@arm.com> wrote: > >> > On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: > >> >> @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; > >> >> #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) > >> >> #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) > >> >> #define PAGE_KERNEL_EXEC pgprot_kernel > >> >> +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) > >> >> +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) > >> >> +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) > >> >> +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) > >> > > >> > Are these S2 read-only by default? > >> > >> not sure I understand what you're asking here? > > > > Why do you pass L_PTE_S2_RDONLY? Do you need to restrict guest writes > > via the stage 2 attributes? > > > yes, for example when KSM merges two pages, then it must be mapped > read-only to the guest so that we catch writes and perform COW. OK, so you want the default to be read-only unless write access is required and you perform an 'or' with L_PTE_S2_RDWR. Sounds fine.
On Thu, Jan 24, 2013 at 12:13 PM, Catalin Marinas <catalin.marinas@arm.com> wrote: > On Thu, Jan 24, 2013 at 05:04:32PM +0000, Christoffer Dall wrote: >> On Thu, Jan 24, 2013 at 12:02 PM, Catalin Marinas >> <catalin.marinas@arm.com> wrote: >> > On Thu, Jan 24, 2013 at 04:05:33PM +0000, Christoffer Dall wrote: >> >> On Thu, Jan 24, 2013 at 6:39 AM, Catalin Marinas >> >> <catalin.marinas@arm.com> wrote: >> >> > On Wed, Jan 16, 2013 at 05:57:26PM +0000, Christoffer Dall wrote: >> >> >> @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; >> >> >> #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) >> >> >> #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) >> >> >> #define PAGE_KERNEL_EXEC pgprot_kernel >> >> >> +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) >> >> >> +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) >> >> >> +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) >> >> >> +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) >> >> > >> >> > Are these S2 read-only by default? >> >> >> >> not sure I understand what you're asking here? >> > >> > Why do you pass L_PTE_S2_RDONLY? Do you need to restrict guest writes >> > via the stage 2 attributes? >> > >> yes, for example when KSM merges two pages, then it must be mapped >> read-only to the guest so that we catch writes and perform COW. > > OK, so you want the default to be read-only unless write access is > required and you perform an 'or' with L_PTE_S2_RDWR. Sounds fine. > exactly, the specific pointer to the code is in line ~562 in arch/arm/kvm/mmu.c. -Christoffer -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h index a3f3792..6ef8afd 100644 --- a/arch/arm/include/asm/pgtable-3level.h +++ b/arch/arm/include/asm/pgtable-3level.h @@ -104,11 +104,29 @@ */ #define L_PGD_SWAPPER (_AT(pgdval_t, 1) << 55) /* swapper_pg_dir entry */ +/* + * 2nd stage PTE definitions for LPAE. + */ +#define L_PTE_S2_MT_UNCACHED (_AT(pteval_t, 0x5) << 2) /* MemAttr[3:0] */ +#define L_PTE_S2_MT_WRITETHROUGH (_AT(pteval_t, 0xa) << 2) /* MemAttr[3:0] */ +#define L_PTE_S2_MT_WRITEBACK (_AT(pteval_t, 0xf) << 2) /* MemAttr[3:0] */ +#define L_PTE_S2_RDONLY (_AT(pteval_t, 1) << 6) /* HAP[1] */ +#define L_PTE_S2_RDWR (_AT(pteval_t, 2) << 6) /* HAP[2:1] */ + +/* + * Hyp-mode PL2 PTE definitions for LPAE. + */ +#define L_PTE_HYP L_PTE_USER + #ifndef __ASSEMBLY__ #define pud_none(pud) (!pud_val(pud)) #define pud_bad(pud) (!(pud_val(pud) & 2)) #define pud_present(pud) (pud_val(pud)) +#define pmd_table(pmd) ((pmd_val(pmd) & PMD_TYPE_MASK) == \ + PMD_TYPE_TABLE) +#define pmd_sect(pmd) ((pmd_val(pmd) & PMD_TYPE_MASK) == \ + PMD_TYPE_SECT) #define pud_clear(pudp) \ do { \ diff --git a/arch/arm/include/asm/pgtable.h b/arch/arm/include/asm/pgtable.h index 9c82f98..f30ac3b 100644 --- a/arch/arm/include/asm/pgtable.h +++ b/arch/arm/include/asm/pgtable.h @@ -70,6 +70,9 @@ extern void __pgd_error(const char *file, int line, pgd_t); extern pgprot_t pgprot_user; extern pgprot_t pgprot_kernel; +extern pgprot_t pgprot_hyp_device; +extern pgprot_t pgprot_s2; +extern pgprot_t pgprot_s2_device; #define _MOD_PROT(p, b) __pgprot(pgprot_val(p) | (b)) @@ -82,6 +85,10 @@ extern pgprot_t pgprot_kernel; #define PAGE_READONLY_EXEC _MOD_PROT(pgprot_user, L_PTE_USER | L_PTE_RDONLY) #define PAGE_KERNEL _MOD_PROT(pgprot_kernel, L_PTE_XN) #define PAGE_KERNEL_EXEC pgprot_kernel +#define PAGE_HYP _MOD_PROT(pgprot_kernel, L_PTE_HYP) +#define PAGE_HYP_DEVICE _MOD_PROT(pgprot_hyp_device, L_PTE_HYP) +#define PAGE_S2 _MOD_PROT(pgprot_s2, L_PTE_S2_RDONLY) +#define PAGE_S2_DEVICE _MOD_PROT(pgprot_s2_device, L_PTE_USER | L_PTE_S2_RDONLY) #define __PAGE_NONE __pgprot(_L_PTE_DEFAULT | L_PTE_RDONLY | L_PTE_XN | L_PTE_NONE) #define __PAGE_SHARED __pgprot(_L_PTE_DEFAULT | L_PTE_USER | L_PTE_XN) diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 9f06102..1f51d71 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -57,6 +57,9 @@ static unsigned int cachepolicy __initdata = CPOLICY_WRITEBACK; static unsigned int ecc_mask __initdata = 0; pgprot_t pgprot_user; pgprot_t pgprot_kernel; +pgprot_t pgprot_hyp_device; +pgprot_t pgprot_s2; +pgprot_t pgprot_s2_device; EXPORT_SYMBOL(pgprot_user); EXPORT_SYMBOL(pgprot_kernel); @@ -66,34 +69,46 @@ struct cachepolicy { unsigned int cr_mask; pmdval_t pmd; pteval_t pte; + pteval_t pte_s2; }; +#ifdef CONFIG_ARM_LPAE +#define s2_policy(policy) policy +#else +#define s2_policy(policy) 0 +#endif + static struct cachepolicy cache_policies[] __initdata = { { .policy = "uncached", .cr_mask = CR_W|CR_C, .pmd = PMD_SECT_UNCACHED, .pte = L_PTE_MT_UNCACHED, + .pte_s2 = s2_policy(L_PTE_S2_MT_UNCACHED), }, { .policy = "buffered", .cr_mask = CR_C, .pmd = PMD_SECT_BUFFERED, .pte = L_PTE_MT_BUFFERABLE, + .pte_s2 = s2_policy(L_PTE_S2_MT_UNCACHED), }, { .policy = "writethrough", .cr_mask = 0, .pmd = PMD_SECT_WT, .pte = L_PTE_MT_WRITETHROUGH, + .pte_s2 = s2_policy(L_PTE_S2_MT_WRITETHROUGH), }, { .policy = "writeback", .cr_mask = 0, .pmd = PMD_SECT_WB, .pte = L_PTE_MT_WRITEBACK, + .pte_s2 = s2_policy(L_PTE_S2_MT_WRITEBACK), }, { .policy = "writealloc", .cr_mask = 0, .pmd = PMD_SECT_WBWA, .pte = L_PTE_MT_WRITEALLOC, + .pte_s2 = s2_policy(L_PTE_S2_MT_WRITEBACK), } }; @@ -310,6 +325,7 @@ static void __init build_mem_type_table(void) struct cachepolicy *cp; unsigned int cr = get_cr(); pteval_t user_pgprot, kern_pgprot, vecs_pgprot; + pteval_t hyp_device_pgprot, s2_pgprot, s2_device_pgprot; int cpu_arch = cpu_architecture(); int i; @@ -421,6 +437,8 @@ static void __init build_mem_type_table(void) */ cp = &cache_policies[cachepolicy]; vecs_pgprot = kern_pgprot = user_pgprot = cp->pte; + s2_pgprot = cp->pte_s2; + hyp_device_pgprot = s2_device_pgprot = mem_types[MT_DEVICE].prot_pte; /* * ARMv6 and above have extended page tables. @@ -444,6 +462,7 @@ static void __init build_mem_type_table(void) user_pgprot |= L_PTE_SHARED; kern_pgprot |= L_PTE_SHARED; vecs_pgprot |= L_PTE_SHARED; + s2_pgprot |= L_PTE_SHARED; mem_types[MT_DEVICE_WC].prot_sect |= PMD_SECT_S; mem_types[MT_DEVICE_WC].prot_pte |= L_PTE_SHARED; mem_types[MT_DEVICE_CACHED].prot_sect |= PMD_SECT_S; @@ -498,6 +517,9 @@ static void __init build_mem_type_table(void) pgprot_user = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | user_pgprot); pgprot_kernel = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY | kern_pgprot); + pgprot_s2 = __pgprot(L_PTE_PRESENT | L_PTE_YOUNG | s2_pgprot); + pgprot_s2_device = __pgprot(s2_device_pgprot); + pgprot_hyp_device = __pgprot(hyp_device_pgprot); mem_types[MT_LOW_VECTORS].prot_l1 |= ecc_mask; mem_types[MT_HIGH_VECTORS].prot_l1 |= ecc_mask;