diff mbox

[v2,8/9] ARM: DTS: AM33XX: Add nodes for OCMC RAM and WKUP-M3

Message ID 1359442762-13697-9-git-send-email-vaibhav.bedia@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vaibhav Bedia Jan. 29, 2013, 6:59 a.m. UTC
Since AM33XX supports only DT-boot, this is needed
for the appropriate device nodes to be created.

Note: OCMC RAM is part of the PER power domain and supports
retention. The assembly code for low power entry/exit will
run from OCMC RAM. To ensure that the OMAP PM code does not
attempt to disable the clock to OCMC RAM as part of the
suspend process add the no_idle_on_suspend flag.

Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
v2: Add reg property

 arch/arm/boot/dts/am33xx.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Peter Korsgaard Jan. 29, 2013, 8:20 a.m. UTC | #1
>>>>> "Vaibhav" == Vaibhav Bedia <vaibhav.bedia@ti.com> writes:

 Vaibhav> Since AM33XX supports only DT-boot, this is needed
 Vaibhav> for the appropriate device nodes to be created.

 Vaibhav> Note: OCMC RAM is part of the PER power domain and supports
 Vaibhav> retention. The assembly code for low power entry/exit will
 Vaibhav> run from OCMC RAM. To ensure that the OMAP PM code does not
 Vaibhav> attempt to disable the clock to OCMC RAM as part of the
 Vaibhav> suspend process add the no_idle_on_suspend flag.

 Vaibhav> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
 Vaibhav> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
 Vaibhav> ---
 Vaibhav> v2: Add reg property

 Vaibhav>  arch/arm/boot/dts/am33xx.dtsi | 14 +++++++++++++
 Vaibhav>  1 file changed, 14 insertions(+)

 Vaibhav> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav> index c2f14e8..423f898 100644
 Vaibhav> --- a/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav> +++ b/arch/arm/boot/dts/am33xx.dtsi
 Vaibhav> @@ -385,5 +385,19 @@
 Vaibhav>  				mac-address = [ 00 00 00 00 00 00 ];
 Vaibhav>  			};
 Vaibhav>  		};
 Vaibhav> +
 Vaibhav> +		ocmcram: ocmcram@40300000 {
 Vaibhav> +			compatible = "ti,ocmcram";
 Vaibhav> +			reg = <0x40300000 0x10000>;
 Vaibhav> +			ti,hwmods = "ocmcram";
 Vaibhav> +			ti,no_idle_on_suspend;
 Vaibhav> +		};
 Vaibhav> +
 Vaibhav> +		wkup_m3: wkup_m3@44d00000 {
 Vaibhav> +			compatible = "ti,wkup_m3";


Both of these compatible properties should probably use less generic
names, like:

ti,am3352-ocmcram
ti,am3352-wkup-m3 ('-' instead of '_')
Vaibhav Bedia Jan. 29, 2013, 10:07 a.m. UTC | #2
On Tue, Jan 29, 2013 at 13:50:44, Peter Korsgaard wrote:
> >>>>> "Vaibhav" == Vaibhav Bedia <vaibhav.bedia@ti.com> writes:
> 
>  Vaibhav> Since AM33XX supports only DT-boot, this is needed
>  Vaibhav> for the appropriate device nodes to be created.
> 
>  Vaibhav> Note: OCMC RAM is part of the PER power domain and supports
>  Vaibhav> retention. The assembly code for low power entry/exit will
>  Vaibhav> run from OCMC RAM. To ensure that the OMAP PM code does not
>  Vaibhav> attempt to disable the clock to OCMC RAM as part of the
>  Vaibhav> suspend process add the no_idle_on_suspend flag.
> 
>  Vaibhav> Signed-off-by: Vaibhav Bedia <vaibhav.bedia@ti.com>
>  Vaibhav> Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
>  Vaibhav> ---
>  Vaibhav> v2: Add reg property
> 
>  Vaibhav>  arch/arm/boot/dts/am33xx.dtsi | 14 +++++++++++++
>  Vaibhav>  1 file changed, 14 insertions(+)
> 
>  Vaibhav> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
>  Vaibhav> index c2f14e8..423f898 100644
>  Vaibhav> --- a/arch/arm/boot/dts/am33xx.dtsi
>  Vaibhav> +++ b/arch/arm/boot/dts/am33xx.dtsi
>  Vaibhav> @@ -385,5 +385,19 @@
>  Vaibhav>  				mac-address = [ 00 00 00 00 00 00 ];
>  Vaibhav>  			};
>  Vaibhav>  		};
>  Vaibhav> +
>  Vaibhav> +		ocmcram: ocmcram@40300000 {
>  Vaibhav> +			compatible = "ti,ocmcram";
>  Vaibhav> +			reg = <0x40300000 0x10000>;
>  Vaibhav> +			ti,hwmods = "ocmcram";
>  Vaibhav> +			ti,no_idle_on_suspend;
>  Vaibhav> +		};
>  Vaibhav> +
>  Vaibhav> +		wkup_m3: wkup_m3@44d00000 {
>  Vaibhav> +			compatible = "ti,wkup_m3";
> 
> 
> Both of these compatible properties should probably use less generic
> names, like:
> 
> ti,am3352-ocmcram
> ti,am3352-wkup-m3 ('-' instead of '_')
> 

Ok. Will do.

Thanks,
Vaibhav
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index c2f14e8..423f898 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -385,5 +385,19 @@ 
 				mac-address = [ 00 00 00 00 00 00 ];
 			};
 		};
+
+		ocmcram: ocmcram@40300000 {
+			compatible = "ti,ocmcram";
+			reg = <0x40300000 0x10000>;
+			ti,hwmods = "ocmcram";
+			ti,no_idle_on_suspend;
+		};
+
+		wkup_m3: wkup_m3@44d00000 {
+			compatible = "ti,wkup_m3";
+			reg = <0x44d00000 0x4000	/* M3 UMEM */
+			       0x44d80000 0x2000>;	/* M3 DMEM */
+			ti,hwmods = "wkup_m3";
+		};
 	};
 };