Add support for Eject hotkey in dell-wmi

Commit Message

Mario Limonciello April 20, 2009, 6:11 p.m. UTC

Hi:

I've gotten word that future Dell consumer laptops are transitioning
several hotkeys to WMI instead.  Here's a patch to enable the first to
enable the Eject hotkey.  I'm attaching it since my mail server
(exchange) would mangle it otherwise.

Thanks,

Comments

Matthew Garrett April 20, 2009, 6:23 p.m. UTC | #1

On Mon, Apr 20, 2009 at 01:11:46PM -0500, Mario Limonciello wrote:
> Hi:
> 
> I've gotten word that future Dell consumer laptops are transitioning
> several hotkeys to WMI instead.  Here's a patch to enable the first to
> enable the Eject hotkey.  I'm attaching it since my mail server
> (exchange) would mangle it otherwise.

Looks good - can you confirm that it'll be removed from the normal 
keyboard interface at the same time?

Mario Limonciello April 20, 2009, 6:25 p.m. UTC | #2

Hi Matthew:

Matthew Garrett wrote:
> On Mon, Apr 20, 2009 at 01:11:46PM -0500, Mario Limonciello wrote:
>   
>
> Looks good - can you confirm that it'll be removed from the normal 
> keyboard interface at the same time?
>   
No it won't be removed at the same time on all machines during the
transition period.  I've however requested to add a BIOS option for the
machines that support this to try to enable or disable WMI support in
the interim.

Regards

Matthew Garrett April 20, 2009, 6:28 p.m. UTC | #3

On Mon, Apr 20, 2009 at 01:25:57PM -0500, Mario Limonciello wrote:
> Hi Matthew:
> Matthew Garrett wrote:
> > On Mon, Apr 20, 2009 at 01:11:46PM -0500, Mario Limonciello wrote:
> >   
> >
> > Looks good - can you confirm that it'll be removed from the normal 
> > keyboard interface at the same time?
> >   
> No it won't be removed at the same time on all machines during the
> transition period.  I've however requested to add a BIOS option for the
> machines that support this to try to enable or disable WMI support in
> the interim.

Ok. How can we determine whether we're on a machine with this support? 
Applying this patch right now will result in systems receiving the event 
twice.

Mario Limonciello April 20, 2009, 6:45 p.m. UTC | #4

Hi Matthew

Matthew Garrett wrote:
> On Mon, Apr 20, 2009 at 01:25:57PM -0500, Mario Limonciello wrote:
>   
>
> Ok. How can we determine whether we're on a machine with this support? 
> Applying this patch right now will result in systems receiving the event 
> twice.
>   
I've checked with the BIOS teams further, and they indicated at the time
that this is enabled on those consumer systems, the hotkey should be
switched over to a mechanical key rather than a software key, so the
keyboard interface would not see this key.  The support in the BIOS to
turn on and off WMI would actually enable SMI hot key events instead
(which could then be serviced by dell-laptop).

Matthew Garrett April 20, 2009, 6:48 p.m. UTC | #5

On Mon, Apr 20, 2009 at 01:44:09PM -0500, Mario Limonciello wrote:

>    I've checked with the BIOS teams further, and they indicated at the time
>    that this is enabled on those consumer systems, the hotkey should be
>    switched over to a mechanical key rather than a software key, so the
>    keyboard interface would not see this key.  The support in the BIOS to
>    turn on and off WMI would actually enable SMI hot key events instead
>    (which could then be serviced by dell-laptop).

Ah, ok, that's fine. As long as the event will only be delivered either 
via WMI or the keyboard controller then we should be good.

Mario Limonciello April 20, 2009, 6:50 p.m. UTC | #6

Hi Matthew:

Matthew Garrett wrote:
> On Mon, Apr 20, 2009 at 01:44:09PM -0500, Mario Limonciello wrote:
>   
> Ah, ok, that's fine. As long as the event will only be delivered either 
> via WMI or the keyboard controller then we should be good.
>
>   
At least for consumer machines that I've heard, this will be the case. 
I'd expect the same policy for business client (Latitude etc), but I
don't know for sure.

Regards

Patch

--- a/drivers/platform/x86/dell-wmi.c~	2009-04-20 07:41:12.000000000 -0500
+++ b/drivers/platform/x86/dell-wmi.c	2009-04-20 07:42:04.000000000 -0500
@@ -50,6 +50,7 @@ 
 
 static struct key_entry dell_wmi_keymap[] = {
 	{KE_KEY, 0xe045, KEY_PROG1},
+	{KE_KEY, 0xe009, KEY_EJECTCD},
 	{KE_END, 0}
 };