diff mbox

[2/2] pinctrl: nomadik: Allow prcm_base to be extracted from Device Tree

Message ID CACRpkdbRosdAOeGo7W=05kC5H4OLbxNUjZydcpLc0OZVcZj+Dg@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij Jan. 18, 2013, 7:59 p.m. UTC
On Fri, Jan 11, 2013 at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:

> The Nomadik Pinctrl driver requires access to some PRCMU registers
> in order to run with full functionality. When Device Tree is
> disabled the required PRCMU base address is passed in via platform
> data, so in order for Device Tree booting to be as functional, we
> need a similar mechanism to fetch it from Device Tree.
>
> The new semantics goes like this: Parse the Device Tree and look
> for the PRCMU node using a provided Phandle. Obtain the ioremaped
> address from that node. If one was supplied via platform data
> over-write it with anything found in Device Tree. Fail if either
> the prcm_base can't be found if we're running on anything other
> than an STN8815 ASIC.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied as well, notice I had to add this hunk to the first
patch to have things working:


Lest the code won't find the prcmu registers.

Yours,
Linus Walleij

Comments

Lee Jones Jan. 18, 2013, 10:45 p.m. UTC | #1
It worked when I tested it?

Sent from my mobile Linux device.
On Jan 18, 2013 7:59 PM, "Linus Walleij" <linus.walleij@linaro.org> wrote:

> On Fri, Jan 11, 2013 at 4:45 PM, Lee Jones <lee.jones@linaro.org> wrote:
>
> > The Nomadik Pinctrl driver requires access to some PRCMU registers
> > in order to run with full functionality. When Device Tree is
> > disabled the required PRCMU base address is passed in via platform
> > data, so in order for Device Tree booting to be as functional, we
> > need a similar mechanism to fetch it from Device Tree.
> >
> > The new semantics goes like this: Parse the Device Tree and look
> > for the PRCMU node using a provided Phandle. Obtain the ioremaped
> > address from that node. If one was supplied via platform data
> > over-write it with anything found in Device Tree. Fail if either
> > the prcm_base can't be found if we're running on anything other
> > than an STN8815 ASIC.
> >
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> Applied as well, notice I had to add this hunk to the first
> patch to have things working:
>
> diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
> index 05d97f6..96f518b 100644
> --- a/arch/arm/boot/dts/dbx5x0.dtsi
> +++ b/arch/arm/boot/dts/dbx5x0.dtsi
> @@ -192,6 +192,7 @@
>                 prcmu: prcmu@80157000 {
>                         compatible = "stericsson,db8500-prcmu";
>                         reg = <0x80157000 0x1000>;
> +                       reg-names = "prcmu";
>                         interrupts = <0 47 0x4>;
>                         #address-cells = <1>;
>                         #size-cells = <1>;
>
> Lest the code won't find the prcmu registers.
>
> Yours,
> Linus Walleij
>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/dbx5x0.dtsi b/arch/arm/boot/dts/dbx5x0.dtsi
index 05d97f6..96f518b 100644
--- a/arch/arm/boot/dts/dbx5x0.dtsi
+++ b/arch/arm/boot/dts/dbx5x0.dtsi
@@ -192,6 +192,7 @@ 
                prcmu: prcmu@80157000 {
                        compatible = "stericsson,db8500-prcmu";
                        reg = <0x80157000 0x1000>;
+                       reg-names = "prcmu";
                        interrupts = <0 47 0x4>;
                        #address-cells = <1>;
                        #size-cells = <1>;