diff mbox

ARM: Kirkwood: Add missing linux/i2c.h include

Message ID 1360077025-8046-1-git-send-email-thierry.reding@avionic-design.de (mailing list archive)
State New, archived
Headers show

Commit Message

Thierry Reding Feb. 5, 2013, 3:10 p.m. UTC
The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
of which are defined in the linux/i2c.h header file.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 arch/arm/mach-kirkwood/board-nsa310.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jason Cooper Feb. 5, 2013, 3:34 p.m. UTC | #1
Thierry,

On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> of which are defined in the linux/i2c.h header file.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
>  arch/arm/mach-kirkwood/board-nsa310.c | 1 +
>  1 file changed, 1 insertion(+)

What is this based against?  We're in the process of removing this whole
file for v3.9 (pinctrl, mv643xx_eth, and i2c)...

thx,

Jason.

> 
> diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
> index 61c4b18..970174a 100644
> --- a/arch/arm/mach-kirkwood/board-nsa310.c
> +++ b/arch/arm/mach-kirkwood/board-nsa310.c
> @@ -11,6 +11,7 @@
>  #include <linux/kernel.h>
>  #include <linux/init.h>
>  #include <linux/gpio.h>
> +#include <linux/i2c.h>
>  #include <mach/kirkwood.h>
>  #include <linux/of.h>
>  #include "common.h"
> -- 
> 1.8.1.2
>
Thierry Reding Feb. 5, 2013, 3:38 p.m. UTC | #2
On Tue, Feb 05, 2013 at 10:34:11AM -0500, Jason Cooper wrote:
> Thierry,
> 
> On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> > The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> > of which are defined in the linux/i2c.h header file.
> > 
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > ---
> >  arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> What is this based against?  We're in the process of removing this whole
> file for v3.9 (pinctrl, mv643xx_eth, and i2c)...

It's based on today's linux-next, so if you're going to drop that file
for 3.9 I guess you can ignore the patch.

Thierry
Jason Cooper Feb. 5, 2013, 3:52 p.m. UTC | #3
On Tue, Feb 05, 2013 at 04:38:07PM +0100, Thierry Reding wrote:
> On Tue, Feb 05, 2013 at 10:34:11AM -0500, Jason Cooper wrote:
> > Thierry,
> > 
> > On Tue, Feb 05, 2013 at 04:10:25PM +0100, Thierry Reding wrote:
> > > The nsa310 board uses I2C_BOARD_INFO and i2c_register_board_info(), both
> > > of which are defined in the linux/i2c.h header file.
> > > 
> > > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> > > ---
> > >  arch/arm/mach-kirkwood/board-nsa310.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > What is this based against?  We're in the process of removing this whole
> > file for v3.9 (pinctrl, mv643xx_eth, and i2c)...
> 
> It's based on today's linux-next, so if you're going to drop that file
> for 3.9 I guess you can ignore the patch.

ok, thanks.

Jason.

> 
> Thierry
diff mbox

Patch

diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
index 61c4b18..970174a 100644
--- a/arch/arm/mach-kirkwood/board-nsa310.c
+++ b/arch/arm/mach-kirkwood/board-nsa310.c
@@ -11,6 +11,7 @@ 
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/gpio.h>
+#include <linux/i2c.h>
 #include <mach/kirkwood.h>
 #include <linux/of.h>
 #include "common.h"