Message ID | 1360353891-24210-1-git-send-email-swarren@wwwdotorg.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote:
> (?<!in)tegra
This doesn't work well. It matches too many
words like integral.
I suggest
K: (?:\btegra\b|\bTEGRA_)
On 02/08/2013 05:40 PM, Joe Perches wrote: > On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote: >> (?<!in)tegra > > This doesn't work well. It matches too many > words like integral. Hmmm. That's exactly what the (?<!in) negative look-behind assertion is attempting to avoid. It works fine here. Is there some dependency on Perl version or something? My Perl version is v5.14.2. > I suggest > > K: (?:\btegra\b|\bTEGRA_) >
On Fri, 2013-02-08 at 17:47 -0700, Stephen Warren wrote: > On 02/08/2013 05:40 PM, Joe Perches wrote: > > On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote: > >> (?<!in)tegra > > > > This doesn't work well. It matches too many > > words like integral. > > Hmmm. That's exactly what the (?<!in) negative look-behind assertion is > attempting to avoid. It works fine here. Is there some dependency on > Perl version or something? My Perl version is v5.14.2. Integral matches I don't see any issue with using a leading \b
On 02/08/2013 06:05 PM, Joe Perches wrote: > On Fri, 2013-02-08 at 17:47 -0700, Stephen Warren wrote: >> On 02/08/2013 05:40 PM, Joe Perches wrote: >>> On Fri, 2013-02-08 at 13:04 -0700, Stephen Warren wrote: >>>> (?<!in)tegra >>> >>> This doesn't work well. It matches too many >>> words like integral. >> >> Hmmm. That's exactly what the (?<!in) negative look-behind assertion is >> attempting to avoid. It works fine here. Is there some dependency on >> Perl version or something? My Perl version is v5.14.2. > > Integral matches > > I don't see any issue with using a leading \b Oh right, it's a capitalization issue; I only tested with "integral" not "Integral". The problem with \btegra is that it wouldn't match _tegra, which would be useful. Perhaps a custom almost-equivalent (?i)[^a-z]tegra would work?
On Fri, 2013-02-08 at 20:15 -0700, Stephen Warren wrote:
> Perhaps a custom almost-equivalent (?i)[^a-z]tegra would work?
I didn't notice false positives with that one.
diff --git a/MAINTAINERS b/MAINTAINERS index 972fd51..ebd3c64 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7850,9 +7850,7 @@ L: linux-tegra@vger.kernel.org Q: http://patchwork.ozlabs.org/project/linux-tegra/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/swarren/linux-tegra.git S: Supported -F: arch/arm/mach-tegra -F: arch/arm/boot/dts/tegra* -F: arch/arm/configs/tegra_defconfig +K: (?<!in)tegra TEHUTI ETHERNET DRIVER M: Andy Gospodarek <andy@greyhouse.net>