| Message ID | 1361872727-4388-1-git-send-email-josephl@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/26/2013 02:58 AM, Joseph Lo wrote: > The PMC HW dose not 100% compatible across all Tegra series. We need to > specify each of them in the DT match table. > diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c > static const struct of_device_id matches[] __initconst = { > { .compatible = "nvidia,tegra20-pmc" }, > + { .compatible = "nvidia,tegra30-pmc" }, > + { .compatible = "nvidia,tegra114-pmc" }, > { } > }; Those should be listed in order of most recent device through least recent device, i.e. in the opposite order.
Hello.
On 26-02-2013 13:58, Joseph Lo wrote:
Almost the same mistake.
> The PMC HW dose
s/dose/is/
> not 100% compatible across all Tegra series. We need to
> specify each of them in the DT match table.
> Signed-off-by: Joseph Lo <josephl@nvidia.com>
WBR, Sergei
diff --git a/arch/arm/mach-tegra/pmc.c b/arch/arm/mach-tegra/pmc.c index d4fdb5f..1b5a908 100644 --- a/arch/arm/mach-tegra/pmc.c +++ b/arch/arm/mach-tegra/pmc.c @@ -37,6 +37,8 @@ static inline void tegra_pmc_writel(u32 val, u32 reg) #ifdef CONFIG_OF static const struct of_device_id matches[] __initconst = { { .compatible = "nvidia,tegra20-pmc" }, + { .compatible = "nvidia,tegra30-pmc" }, + { .compatible = "nvidia,tegra114-pmc" }, { } }; #endif
The PMC HW dose not 100% compatible across all Tegra series. We need to specify each of them in the DT match table. Signed-off-by: Joseph Lo <josephl@nvidia.com> --- arch/arm/mach-tegra/pmc.c | 2 ++ 1 file changed, 2 insertions(+)