| Message ID | 20130226155510.GA18647@harvey-pc.matrox.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, den 26.02.2013, 10:55 -0500 schrieb Christopher Harvey: *assignments > These two variables are set again immediately in 'mgag200_modeset_init' The compiler would optimize this anyway I guess. Though now it can warn us, if the code should ever change and these variable are not set anymore in all cases. > Signed-off-by: Christopher Harvey <charvey@matrox.com> > --- > drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c > index 70dd3c5..aad280a 100644 > --- a/drivers/gpu/drm/mgag200/mgag200_main.c > +++ b/drivers/gpu/drm/mgag200/mgag200_main.c > @@ -240,8 +240,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags) > > drm_mode_config_init(dev); > dev->mode_config.funcs = (void *)&mga_mode_funcs; > - dev->mode_config.min_width = 0; > - dev->mode_config.min_height = 0; > dev->mode_config.preferred_depth = 24; > dev->mode_config.prefer_shadow = 1; Acked-by: Paul Menzel <paulepanter@users.sourceforge.net> Thanks, Paul
diff --git a/drivers/gpu/drm/mgag200/mgag200_main.c b/drivers/gpu/drm/mgag200/mgag200_main.c index 70dd3c5..aad280a 100644 --- a/drivers/gpu/drm/mgag200/mgag200_main.c +++ b/drivers/gpu/drm/mgag200/mgag200_main.c @@ -240,8 +240,6 @@ int mgag200_driver_load(struct drm_device *dev, unsigned long flags) drm_mode_config_init(dev); dev->mode_config.funcs = (void *)&mga_mode_funcs; - dev->mode_config.min_width = 0; - dev->mode_config.min_height = 0; dev->mode_config.preferred_depth = 24; dev->mode_config.prefer_shadow = 1;
These two variables are set again immediately in 'mgag200_modeset_init' Signed-off-by: Christopher Harvey <charvey@matrox.com> --- drivers/gpu/drm/mgag200/mgag200_main.c | 2 -- 1 file changed, 2 deletions(-)