diff mbox

[parisc] do not install modules when installing kernel

Message ID 3763734.hDYRZelWPG@donald.sf-tec.de (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Rolf Eike Beer March 1, 2013, 10:23 p.m. UTC
PA-RISC is the only arch that installs the modules when installing the kernel.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
 arch/parisc/Makefile | 4 +---
 1 Datei geändert, 1 Zeile hinzugefügt(+), 3 Zeilen entfernt(-)

Comments

Helge Deller March 2, 2013, 7:42 p.m. UTC | #1
On 03/01/2013 11:23 PM, Rolf Eike Beer wrote:
> PA-RISC is the only arch that installs the modules when installing the kernel.
> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>


Thanks!

Applied to my fixes-for-3.9-latest branch at
http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git

Helge

> ---
>  arch/parisc/Makefile | 4 +---
>  1 Datei geändert, 1 Zeile hinzugefügt(+), 3 Zeilen entfernt(-)
> 
> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
> index ed9a14c..01d95e2 100644
> --- a/arch/parisc/Makefile
> +++ b/arch/parisc/Makefile
> @@ -113,12 +113,10 @@ palo: vmlinux
>  # Shorthands for known targets not supported by parisc, use vmlinux as default
>  Image zImage bzImage: vmlinux
>  
> -kernel_install: vmlinux
> +install: vmlinux
>  	sh $(src)/arch/parisc/install.sh \
>  			$(KERNELRELEASE) $< System.map "$(INSTALL_PATH)"
>  
> -install: kernel_install modules_install
> -
>  CLEAN_FILES	+= lifimage
>  MRPROPER_FILES	+= palo.conf
>  
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
John David Anglin March 3, 2013, 9:25 p.m. UTC | #2
Hi Helge,

On 2-Mar-13, at 2:42 PM, Helge Deller wrote:

> Applied to my fixes-for-3.9-latest branch at
> http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git


I built the above branch yesterday.  We seem to have a regression in  
behavior.
My build of perl 5.14.2-18 failed with the following error:

....
Failed 1 test out of 2039, 99.95% okay.
         op/sigdispatch.t
### Since not all tests were successful, you may want to run some of
### them individually and examine any diagnostic messages they produce.
### See the INSTALL document's section on "make test".
### You have a good chance to get more information by running
###   ./perl harness
### in the 't' directory since most (>=80%) of the tests succeeded.
### You may have to set your dynamic library search path,
### LD_LIBRARY_PATH, to point to the build directory:
###   setenv LD_LIBRARY_PATH `pwd`; cd t; ./perl harness
###   LD_LIBRARY_PATH=`pwd`; export LD_LIBRARY_PATH; cd t; ./perl  
harness
###   export LD_LIBRARY_PATH=`pwd`; cd t; ./perl harness
### for csh-style shells, like tcsh; or for traditional/modern
### Bourne-style shells, like bash, ksh, and zsh, respectively.
u=18.18  s=28.38  cu=1367.86  cs=974.72  scripts=2039  tests=465774
make[1]: *** [test] Error 1
make[1]: Leaving directory `/home/dave/debian/perl/perl-5.14.2'
make: *** [perl.static] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Build command 'cd perl-5.14.2 && dpkg-buildpackage -b -uc' failed.

I ran ./perl harness again and the same test failed.  As this looked
like a kernel issue, I tried the build again with 3.7.6+ and had a  
successful
build.

Dave
--
John David Anglin	dave.anglin@bell.net



--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Helge Deller March 3, 2013, 10:23 p.m. UTC | #3
On 03/03/2013 10:25 PM, John David Anglin wrote:
> Hi Helge,
> 
> On 2-Mar-13, at 2:42 PM, Helge Deller wrote:
> 
>> Applied to my fixes-for-3.9-latest branch at
>> http://git.kernel.org/cgit/linux/kernel/git/deller/parisc-linux.git
> 
> 
> I built the above branch yesterday.  We seem to have a regression in behavior.
> My build of perl 5.14.2-18 failed with the following error:
> 
> ....
> Failed 1 test out of 2039, 99.95% okay.
>         op/sigdispatch.t
> ### Since not all tests were successful, you may want to run some of
> ### them individually and examine any diagnostic messages they produce.
> ### See the INSTALL document's section on "make test".
> ### You have a good chance to get more information by running
> ###   ./perl harness
> ### in the 't' directory since most (>=80%) of the tests succeeded.
> ### You may have to set your dynamic library search path,
> ### LD_LIBRARY_PATH, to point to the build directory:
> ###   setenv LD_LIBRARY_PATH `pwd`; cd t; ./perl harness
> ###   LD_LIBRARY_PATH=`pwd`; export LD_LIBRARY_PATH; cd t; ./perl harness
> ###   export LD_LIBRARY_PATH=`pwd`; cd t; ./perl harness
> ### for csh-style shells, like tcsh; or for traditional/modern
> ### Bourne-style shells, like bash, ksh, and zsh, respectively.
> u=18.18  s=28.38  cu=1367.86  cs=974.72  scripts=2039  tests=465774
> make[1]: *** [test] Error 1
> make[1]: Leaving directory `/home/dave/debian/perl/perl-5.14.2'
> make: *** [perl.static] Error 2
> dpkg-buildpackage: error: debian/rules build gave error exit status 2
> Build command 'cd perl-5.14.2 && dpkg-buildpackage -b -uc' failed.
> 
> I ran ./perl harness again and the same test failed.  As this looked
> like a kernel issue, I tried the build again with 3.7.6+ and had a successful
> build.

Hi Dave,

please pull Linus tree again on top.
There is a patch-fix from Al Viro regarding signals....
Just a guess....and 3.9 is still not stable...

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index ed9a14c..01d95e2 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -113,12 +113,10 @@  palo: vmlinux
 # Shorthands for known targets not supported by parisc, use vmlinux as default
 Image zImage bzImage: vmlinux
 
-kernel_install: vmlinux
+install: vmlinux
 	sh $(src)/arch/parisc/install.sh \
 			$(KERNELRELEASE) $< System.map "$(INSTALL_PATH)"
 
-install: kernel_install modules_install
-
 CLEAN_FILES	+= lifimage
 MRPROPER_FILES	+= palo.conf