| Message ID | 1362438937-28143-1-git-send-email-sboyd@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote: > WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference > from the function armpmu_register() to the function > .init.text:armpmu_init() > The function armpmu_register() references > the function __init armpmu_init(). > This is often because armpmu_register lacks a __init > annotation or the annotation of armpmu_init is wrong. > > Just drop the __init marking on armpmu_init() because > armpmu_register() no longer has an __init marking. > > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> Cheers Stephen: Acked-by: Will Deacon <will.deacon@arm.com> Can you put this into the patch system please? Will
On 03/04/13 18:43, Will Deacon wrote: > On Mon, Mar 04, 2013 at 11:15:37PM +0000, Stephen Boyd wrote: >> WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference >> from the function armpmu_register() to the function >> .init.text:armpmu_init() >> The function armpmu_register() references >> the function __init armpmu_init(). >> This is often because armpmu_register lacks a __init >> annotation or the annotation of armpmu_init is wrong. >> >> Just drop the __init marking on armpmu_init() because >> armpmu_register() no longer has an __init marking. >> >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > Cheers Stephen: > > Acked-by: Will Deacon <will.deacon@arm.com> > > Can you put this into the patch system please? > > Thanks. 7667/1
diff --git a/arch/arm/kernel/perf_event.c b/arch/arm/kernel/perf_event.c index 31e0eb3..32081ad 100644 --- a/arch/arm/kernel/perf_event.c +++ b/arch/arm/kernel/perf_event.c @@ -484,7 +484,7 @@ const struct dev_pm_ops armpmu_dev_pm_ops = { SET_RUNTIME_PM_OPS(armpmu_runtime_suspend, armpmu_runtime_resume, NULL) }; -static void __init armpmu_init(struct arm_pmu *armpmu) +static void armpmu_init(struct arm_pmu *armpmu) { atomic_set(&armpmu->active_events, 0); mutex_init(&armpmu->reserve_mutex);
WARNING: vmlinux.o(.text+0xfb80): Section mismatch in reference from the function armpmu_register() to the function .init.text:armpmu_init() The function armpmu_register() references the function __init armpmu_init(). This is often because armpmu_register lacks a __init annotation or the annotation of armpmu_init is wrong. Just drop the __init marking on armpmu_init() because armpmu_register() no longer has an __init marking. Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> --- I doubt anyone is actually experiencing any problems because this driver probes before kernel init is over. But the warning is a bit annoying. arch/arm/kernel/perf_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)