| Message ID | 1362649709-9608-1-git-send-email-benjamin.tissoires@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Jiri Kosina |
| Headers | show |
On Thu, 7 Mar 2013, Benjamin Tissoires wrote: > In the HID drivers tranport cleanup series, I removed the dependency > between hid-holtek and usbhid. This was wrong as hid-holtek.c relies > extensively on usb calls. > > This fixes compilation error when CONFIG_USB_SUPPORT is not enabled. Applied.
On 03/07/13 01:48, Benjamin Tissoires wrote: > In the HID drivers tranport cleanup series, I removed the dependency > between hid-holtek and usbhid. This was wrong as hid-holtek.c relies > extensively on usb calls. > > This fixes compilation error when CONFIG_USB_SUPPORT is not enabled. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled: ERROR: "usb_control_msg" [drivers/hid/hid-multitouch.ko] undefined! > --- > drivers/hid/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 3abb11f..613083a 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -215,7 +215,7 @@ config HID_EZKEY > > config HID_HOLTEK > tristate "Holtek HID devices" > - depends on HID > + depends on USB_HID > ---help--- > Support for Holtek based devices: > - Holtek On Line Grip based game controller >
On Fri, 8 Mar 2013, Randy Dunlap wrote: > > In the HID drivers tranport cleanup series, I removed the dependency > > between hid-holtek and usbhid. This was wrong as hid-holtek.c relies > > extensively on usb calls. > > > > This fixes compilation error when CONFIG_USB_SUPPORT is not enabled. > > > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > > > but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled: Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH, hence that shouldn't be a problem. There used to be a problem in linux-next, but that should be fixed by 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have pushed out yesterday.
On 03/08/13 13:00, Jiri Kosina wrote: > On Fri, 8 Mar 2013, Randy Dunlap wrote: > >>> In the HID drivers tranport cleanup series, I removed the dependency >>> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies >>> extensively on usb calls. >>> >>> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled. >>> >>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> >> >> Acked-by: Randy Dunlap <rdunlap@infradead.org> >> >> >> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled: > > Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH, > hence that shouldn't be a problem. You are correct. I was testing 3.9-rc1 + mmotm, where the latter contains some incorrect HID patches (from linux-next). Thanks. > There used to be a problem in linux-next, but that should be fixed by > 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have > pushed out yesterday. >
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 3abb11f..613083a 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -215,7 +215,7 @@ config HID_EZKEY config HID_HOLTEK tristate "Holtek HID devices" - depends on HID + depends on USB_HID ---help--- Support for Holtek based devices: - Holtek On Line Grip based game controller
In the HID drivers tranport cleanup series, I removed the dependency between hid-holtek and usbhid. This was wrong as hid-holtek.c relies extensively on usb calls. This fixes compilation error when CONFIG_USB_SUPPORT is not enabled. Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> --- drivers/hid/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)