| Message ID | 1362080229-27334-1-git-send-email-linux@roeck-us.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Feb 28, 2013 at 8:37 PM, Guenter Roeck <linux@roeck-us.net> wrote: > ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured. > > drivers/built-in.o: In function `ab8500_power_off': > drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name' > drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name' > > Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> It appears an identical patch was already submitted in feb 19: https://patchwork.kernel.org/patch/2163301/ Yours, Linus Walleij
Hi Guenter, On Thu, Feb 28, 2013 at 11:37:09AM -0800, Guenter Roeck wrote: > ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured. > > drivers/built-in.o: In function `ab8500_power_off': > drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name' > drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name' > > Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem. > > Signed-off-by: Guenter Roeck <linux@roeck-us.net> > --- > drivers/mfd/Kconfig | 1 + > 1 file changed, 1 insertion(+) I applied Axel's patch to my mfd-fixes tree now. Cheers, Samuel.
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 671f5b1..d5511de 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -860,6 +860,7 @@ config AB8500_CORE depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU select MFD_CORE select IRQ_DOMAIN + select POWER_SUPPLY help Select this option to enable access to AB8500 power management chip. This connects to U8500 either on the SSP/SPI bus (deprecated
ab8500-sysctrl.c fails to build if POWER_SUPPLY is not configured. drivers/built-in.o: In function `ab8500_power_off': drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name' drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name' Select POWER_SUPPLY in Kconfig if AB8500_CORE is configured to fix the problem. Signed-off-by: Guenter Roeck <linux@roeck-us.net> --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)