| Message ID | 1363017202-4556-1-git-send-email-rabin.vincent@stericsson.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Mar 11, 2013 at 4:53 PM, Rabin Vincent <rabin.vincent@stericsson.com> wrote: > Since 1932811f426fee ("Input: matrix-keymap - uninline and prepare for > device tree support"), the row_shift used by the driver does not match > the one used by matrix_keypad_build_keymap(), leading to misdetection of > keys. Fix it. > > Cc: <stable@vger.kernel.org> # 3.8 > Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Given that the other patch sent a week ago already made it into the fixes, was this one missed for some reason? It looks like another clear regression... Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c index 208de7c..4ce924d 100644 --- a/drivers/input/keyboard/tc3589x-keypad.c +++ b/drivers/input/keyboard/tc3589x-keypad.c @@ -163,7 +163,7 @@ static int tc3589x_keypad_init_key_hardware(struct tc_keypad *keypad) #define TC35893_DATA_REGS 4 #define TC35893_KEYCODE_FIFO_EMPTY 0x7f #define TC35893_KEYCODE_FIFO_CLEAR 0xff -#define TC35893_KEYPAD_ROW_SHIFT 0x3 +#define TC35893_KEYPAD_ROW_SHIFT 0x4 static irqreturn_t tc3589x_keypad_irq(int irq, void *dev) {
Since 1932811f426fee ("Input: matrix-keymap - uninline and prepare for device tree support"), the row_shift used by the driver does not match the one used by matrix_keypad_build_keymap(), leading to misdetection of keys. Fix it. Cc: <stable@vger.kernel.org> # 3.8 Signed-off-by: Rabin Vincent <rabin.vincent@stericsson.com> --- drivers/input/keyboard/tc3589x-keypad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)