diff mbox

[V2,1/4] ARM: tegra: dalmore: add cpu regulator node

Message ID 1363873663-19272-2-git-send-email-ldewangan@nvidia.com (mailing list archive)
State New, archived
Headers show

Commit Message

Laxman Dewangan March 21, 2013, 1:47 p.m. UTC 
Dalmore uses the TPS51632 as CPU regulator. The device is connected
on I2C5.

Add DT node for TPS51632.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 arch/arm/boot/dts/tegra114-dalmore.dts |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov March 21, 2013, 2:07 p.m. UTC | #1 
Hello.

On 21-03-2013 17:47, Laxman Dewangan wrote:

> Dalmore uses the TPS51632 as CPU regulator. The device is connected
> on I2C5.

> Add DT node for TPS51632.

> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
>   arch/arm/boot/dts/tegra114-dalmore.dts |   15 +++++++++++++++
>   1 files changed, 15 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
> index a61974e..6be9434 100644
> --- a/arch/arm/boot/dts/tegra114-dalmore.dts
> +++ b/arch/arm/boot/dts/tegra114-dalmore.dts
> @@ -718,6 +718,21 @@
>   		clock-frequency = <408000000>;
>   	};
>
> +	i2c@7000d000 {
> +		status = "okay";
> +		clock-frequency = <400000>;
> +
> +		tps51632 {

    Should be named "tps51632@43" I think.

> +			compatible = "ti,tps51632";
> +			reg = <0x43>;

WBR, Sergei
Stephen Warren March 21, 2013, 5:30 p.m. UTC | #2 
On 03/21/2013 08:07 AM, Sergei Shtylyov wrote:
> Hello.
> 
> On 21-03-2013 17:47, Laxman Dewangan wrote:
> 
>> Dalmore uses the TPS51632 as CPU regulator. The device is connected
>> on I2C5.
> 
>> Add DT node for TPS51632.

>> diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts

>> +    i2c@7000d000 {
>> +        status = "okay";
>> +        clock-frequency = <400000>;
>> +
>> +        tps51632 {
> 
>    Should be named "tps51632@43" I think.

The unit-address (i.e. "@43" part) of the node name is typically omitted
if it isn't required to make the node name unique.
diff mbox

Patch

diff --git a/arch/arm/boot/dts/tegra114-dalmore.dts b/arch/arm/boot/dts/tegra114-dalmore.dts
index a61974e..6be9434 100644
--- a/arch/arm/boot/dts/tegra114-dalmore.dts
+++ b/arch/arm/boot/dts/tegra114-dalmore.dts
@@ -718,6 +718,21 @@ 
 		clock-frequency = <408000000>;
 	};
 
+	i2c@7000d000 {
+		status = "okay";
+		clock-frequency = <400000>;
+
+		tps51632 {
+			compatible = "ti,tps51632";
+			reg = <0x43>;
+			regulator-name = "vdd-cpu";
+			regulator-min-microvolt = <500000>;
+			regulator-max-microvolt = <1520000>;
+			regulator-boot-on;
+			regulator-always-on;
+		};
+	};
+
 	pmc {
 		nvidia,invert-interrupt;
 	};