| Message ID | 1362219789-6146-2-git-send-email-sachin.kamat@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Rob, On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote: > On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> Instead of checking if num_encoders is zero, it is being assigned 0. >> Convert the assignment to a check. >> >> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> > > Signed-off-by: Rob Clark <robdclark@gmail.com> Just curious. Which tree would these patches be applied to (I mean your tree or Dave's)?
On 11 March 2013 15:38, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Hi Rob, > > On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote: >> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>> Instead of checking if num_encoders is zero, it is being assigned 0. >>> Convert the assignment to a check. >>> >>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >> >> Signed-off-by: Rob Clark <robdclark@gmail.com> > > Just curious. Which tree would these patches be applied to (I mean > your tree or Dave's)? ping...
sorry, was offline for a while (moving), and missed the last email.. I would guess that Tomi would send pull-req for tilcdc and omapdrm. Well I suppose I could do it if Tomi can't, although my pandas/beagles/beaglebones are not unpacked yet.. BR, -R On Mon, Mar 25, 2013 at 2:58 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 11 March 2013 15:38, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> Hi Rob, >> >> On 2 March 2013 20:40, Rob Clark <robdclark@gmail.com> wrote: >>> On Sat, Mar 2, 2013 at 5:23 AM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>>> Instead of checking if num_encoders is zero, it is being assigned 0. >>>> Convert the assignment to a check. >>>> >>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> >>> >>> Signed-off-by: Rob Clark <robdclark@gmail.com> >> >> Just curious. Which tree would these patches be applied to (I mean >> your tree or Dave's)? > > ping... > > > -- > With warm regards, > Sachin
On 25 March 2013 19:06, Rob Clark <robdclark@gmail.com> wrote: > sorry, was offline for a while (moving), and missed the last email.. No problem :) > > I would guess that Tomi would send pull-req for tilcdc and omapdrm. > Well I suppose I could do it if Tomi can't, although my > pandas/beagles/beaglebones are not unpacked yet.. Ok. Thanks.
Hi, On 2013-03-25 15:36, Rob Clark wrote: > sorry, was offline for a while (moving), and missed the last email.. > > I would guess that Tomi would send pull-req for tilcdc and omapdrm. > Well I suppose I could do it if Tomi can't, although my > pandas/beagles/beaglebones are not unpacked yet.. Well, I know nothing about tilcdc, I don't have a board to test it, it was merged even if I had objections, and I've got my hands full already... I think for the moment tilcdc is either maintained by Rob, or is unmaintained. I will try to handle omapdrm, though. Tomi
Hi Rob, With the merge window for 3.10 about to open shortly, I was wondering if the tilcdc patches are lined up somewhere as I could not find them in linux-next yet. Thanks and regards, Sachin. On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > Hi, > > On 2013-03-25 15:36, Rob Clark wrote: >> sorry, was offline for a while (moving), and missed the last email.. >> >> I would guess that Tomi would send pull-req for tilcdc and omapdrm. >> Well I suppose I could do it if Tomi can't, although my >> pandas/beagles/beaglebones are not unpacked yet.. > > Well, I know nothing about tilcdc, I don't have a board to test it, it > was merged even if I had objections, and I've got my hands full already... > > I think for the moment tilcdc is either maintained by Rob, or is > unmaintained. > > I will try to handle omapdrm, though. > > Tomi > >
On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > Hi Rob, > > With the merge window for 3.10 about to open shortly, I was wondering > if the tilcdc patches are lined up somewhere as I could not find them > in linux-next yet. I don't have any other patches for tilcdc, so if this isn't going through a pull req from tomi then I think it would be fine if Dave takes it directly through the drm-next tree. This patch has my s-o-b, it fixes an obvious typo. BR, -R > Thanks and regards, > Sachin. > > On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >> Hi, >> >> On 2013-03-25 15:36, Rob Clark wrote: >>> sorry, was offline for a while (moving), and missed the last email.. >>> >>> I would guess that Tomi would send pull-req for tilcdc and omapdrm. >>> Well I suppose I could do it if Tomi can't, although my >>> pandas/beagles/beaglebones are not unpacked yet.. >> >> Well, I know nothing about tilcdc, I don't have a board to test it, it >> was merged even if I had objections, and I've got my hands full already... >> >> I think for the moment tilcdc is either maintained by Rob, or is >> unmaintained. >> >> I will try to handle omapdrm, though. >> >> Tomi >> >>
On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote: > On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> Hi Rob, >> >> With the merge window for 3.10 about to open shortly, I was wondering >> if the tilcdc patches are lined up somewhere as I could not find them >> in linux-next yet. > > I don't have any other patches for tilcdc, so if this isn't going > through a pull req from tomi then I think it would be fine if Dave > takes it directly through the drm-next tree. This patch has my s-o-b, > it fixes an obvious typo. Thanks Rob. Dave, Could you please pick these 4 patches? Or do I send them again? >> On 27 March 2013 11:53, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: >>> Hi, >>> >>> On 2013-03-25 15:36, Rob Clark wrote: >>>> sorry, was offline for a while (moving), and missed the last email.. >>>> >>>> I would guess that Tomi would send pull-req for tilcdc and omapdrm. >>>> Well I suppose I could do it if Tomi can't, although my >>>> pandas/beagles/beaglebones are not unpacked yet.. >>> >>> Well, I know nothing about tilcdc, I don't have a board to test it, it >>> was merged even if I had objections, and I've got my hands full already... >>> >>> I think for the moment tilcdc is either maintained by Rob, or is >>> unmaintained. >>> >>> I will try to handle omapdrm, though. >>> >>> Tomi >>> >>>
On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: > On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote: >> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>> Hi Rob, >>> >>> With the merge window for 3.10 about to open shortly, I was wondering >>> if the tilcdc patches are lined up somewhere as I could not find them >>> in linux-next yet. >> >> I don't have any other patches for tilcdc, so if this isn't going >> through a pull req from tomi then I think it would be fine if Dave >> takes it directly through the drm-next tree. This patch has my s-o-b, >> it fixes an obvious typo. > > Thanks Rob. > > Dave, > Could you please pick these 4 patches? Or do I send them again? > All 4 are in drm-next now. Future reference, Acked-by: if you aren't going to handle the patches, I'm not saying it will make me notice them any quicker though. Dave.
On 24 April 2013 10:08, Dave Airlie <airlied@gmail.com> wrote: > On Wed, Apr 24, 2013 at 2:21 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >> On 24 April 2013 09:47, Rob Clark <robdclark@gmail.com> wrote: >>> On Tue, Apr 23, 2013 at 11:52 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote: >>>> Hi Rob, >>>> >>>> With the merge window for 3.10 about to open shortly, I was wondering >>>> if the tilcdc patches are lined up somewhere as I could not find them >>>> in linux-next yet. >>> >>> I don't have any other patches for tilcdc, so if this isn't going >>> through a pull req from tomi then I think it would be fine if Dave >>> takes it directly through the drm-next tree. This patch has my s-o-b, >>> it fixes an obvious typo. >> >> Thanks Rob. >> >> Dave, >> Could you please pick these 4 patches? Or do I send them again? >> > > All 4 are in drm-next now. Thanks Dave.
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index c5b592d..bfac582 100644 --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c @@ -75,7 +75,7 @@ static int modeset_init(struct drm_device *dev) mod->funcs->modeset_init(mod, dev); } - if ((priv->num_encoders = 0) || (priv->num_connectors == 0)) { + if ((priv->num_encoders == 0) || (priv->num_connectors == 0)) { /* oh nos! */ dev_err(dev->dev, "no encoders/connectors found\n"); return -ENXIO;
Instead of checking if num_encoders is zero, it is being assigned 0. Convert the assignment to a check. Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)