OMAP baseline test results for v3.9-rc1

Commit Message

Vaibhav Hiremath March 14, 2013, 11:29 a.m. UTC

> -----Original Message-----
> From: [e-mail] [mailto:linux-omap-
> [e-mail]] On Behalf Of Paul Walmsley
> Sent: Tuesday, March 12, 2013 10:10 PM
> To: [e-mail]
> Cc: [e-mail]
> Subject: OMAP baseline test results for v3.9-rc1
> 
> 
> Here are some basic OMAP test results for Linux v3.9-rc1.
> Logs and other details at:
> 
>     http://www.pwsan.com/omap/testlogs/test_v3.9-rc1/20130312100243/
> 
> 
> Test summary
> ------------
> 
> Build:
>     FAIL ( 4/16): am33xx_only, omap1_defconfig,
This requires some cleanup in Makefile and Kconfig handling,

Either you disable SMP support for non-SMP devices like AM33xx 

OR

Fix the Makefile to resolve the build dependencies (may not be trivial)

OR

Make functions __weak so that build will go through.



I have created below patch, if it is ok with you then I can
Submit patch for the same (build tested with am33xx_only and omap2plus_defconfig).







Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Santosh Shilimkar March 14, 2013, 11:46 a.m. UTC | #1

On Thursday 14 March 2013 04:59 PM, Hiremath, Vaibhav wrote:
> 
>> -----Original Message-----
>> From: [e-mail] [mailto:linux-omap-
>> [e-mail]] On Behalf Of Paul Walmsley
>> Sent: Tuesday, March 12, 2013 10:10 PM
>> To: [e-mail]
>> Cc: [e-mail]
>> Subject: OMAP baseline test results for v3.9-rc1
>>
>>
>> Here are some basic OMAP test results for Linux v3.9-rc1.
>> Logs and other details at:
>>
>>     http://www.pwsan.com/omap/testlogs/test_v3.9-rc1/20130312100243/
>>
>>
>> Test summary
>> ------------
>>
>> Build:
>>     FAIL ( 4/16): am33xx_only, omap1_defconfig,
> This requires some cleanup in Makefile and Kconfig handling,
> 
> Either you disable SMP support for non-SMP devices like AM33xx 
> 
> OR
> 
> Fix the Makefile to resolve the build dependencies (may not be trivial)
> 
This one... Better things is not to build the OMAP4 files for AM33XX only build.
Even if it is not trivial, its right way of fixing the issue.

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Paul Walmsley March 26, 2013, 6:44 p.m. UTC | #2

Hi,

On Thu, 14 Mar 2013, Hiremath, Vaibhav wrote:

> > -----Original Message-----
> > From: [e-mail] [mailto:linux-omap-
> > [e-mail]] On Behalf Of Paul Walmsley
> > Sent: Tuesday, March 12, 2013 10:10 PM
> > To: [e-mail]
> > Cc: [e-mail]
> > Subject: OMAP baseline test results for v3.9-rc1
> > 
> > 
> > Here are some basic OMAP test results for Linux v3.9-rc1.
> > Logs and other details at:
> > 
> >     http://www.pwsan.com/omap/testlogs/test_v3.9-rc1/20130312100243/
> > 
> > 
> > Test summary
> > ------------
> > 
> > Build:
> >     FAIL ( 4/16): am33xx_only, omap1_defconfig,
> This requires some cleanup in Makefile and Kconfig handling,
> 
> Either you disable SMP support for non-SMP devices like AM33xx 
> 
> OR
> 
> Fix the Makefile to resolve the build dependencies (may not be trivial)
> 
> OR
> 
> Make functions __weak so that build will go through.
> 
> 
> 
> I have created below patch, if it is ok with you then I can
> Submit patch for the same (build tested with am33xx_only and omap2plus_defconfig).

Santosh's suggestion seems the right way to go.  Care to implement a patch 
for #2 above?


- Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
index 0a6b9c7..cb0d55d 100644
--- a/arch/arm/mach-omap2/common.h
+++ b/arch/arm/mach-omap2/common.h
@@ -233,9 +233,9 @@  extern void omap_do_wfi(void);
 /* Needed for secondary core boot */
 extern void omap_secondary_startup(void);
 extern void omap_secondary_startup_4460(void);
-extern u32 omap_modify_auxcoreboot0(u32 set_mask, u32 clear_mask);
-extern void omap_auxcoreboot_addr(u32 cpu_addr);
-extern u32 omap_read_auxcoreboot0(void);
+extern u32 __weak omap_modify_auxcoreboot0(u32 set_mask, u32 clear_mask);
+extern void __weak omap_auxcoreboot_addr(u32 cpu_addr);
+extern u32 __weak omap_read_auxcoreboot0(void);

 extern void omap4_cpu_die(unsigned int cpu);

@@ -249,7 +249,7 @@  extern int omap4_mpuss_init(void);
 extern int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state);
 extern int omap4_finish_suspend(unsigned long cpu_state);
 extern void omap4_cpu_resume(void);
-extern int omap4_hotplug_cpu(unsigned int cpu, unsigned int power_state);
+extern int __weak omap4_hotplug_cpu(unsigned int cpu, unsigned int power_state);
 extern u32 omap4_mpuss_read_prev_context_state(void);
 #else
 static inline int omap4_enter_lowpower(unsigned int cpu,
diff --git a/arch/arm/mach-omap2/omap-wakeupgen.h b/arch/arm/mach-omap2/omap-wakeupgen.h
index b0fd16f..94f5281 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.h
+++ b/arch/arm/mach-omap2/omap-wakeupgen.h
@@ -33,6 +33,6 @@ 
 #define OMAP_TIMESTAMPCYCLEHI                  0xc0c

 extern int __init omap_wakeupgen_init(void);
-extern void __iomem *omap_get_wakeupgen_base(void);
-extern int omap_secure_apis_support(void);
+extern void __weak __iomem *omap_get_wakeupgen_base(void);
+extern int __weak omap_secure_apis_support(void);
 #endif