| Message ID | 87hajlk0oh.wl%kuninori.morimoto.gx@renesas.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote: > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), > but it was too long delay for SPI device. > Bock-W board SPI access was too slow without this patch. > This patch uses udelay(10) for it. > > Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> Acked-by: Simon Horman <horms+renesas@verge.net.au> Grant, can you take this patch? > --- > drivers/spi/spi-sh-hspi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c > index 60cfae5..eab593e 100644 > --- a/drivers/spi/spi-sh-hspi.c > +++ b/drivers/spi/spi-sh-hspi.c > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) > if ((mask & hspi_read(hspi, SPSR)) == val) > return 0; > > - msleep(20); > + udelay(10); > } > > dev_err(hspi->dev, "timeout\n"); > -- > 1.7.9.5 > ------------------------------------------------------------------------------ Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal http://www.cisco.com/web/learning/employer_resources/index.html
Hi Grant Could you please teach me current status of this patch ? > On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote: > > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), > > but it was too long delay for SPI device. > > Bock-W board SPI access was too slow without this patch. > > This patch uses udelay(10) for it. > > > > Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > Acked-by: Simon Horman <horms+renesas@verge.net.au> > > Grant, can you take this patch? > > > --- > > drivers/spi/spi-sh-hspi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c > > index 60cfae5..eab593e 100644 > > --- a/drivers/spi/spi-sh-hspi.c > > +++ b/drivers/spi/spi-sh-hspi.c > > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) > > if ((mask & hspi_read(hspi, SPSR)) == val) > > return 0; > > > > - msleep(20); > > + udelay(10); > > } > > > > dev_err(hspi->dev, "timeout\n"); > > -- > > 1.7.9.5 > > Best regards --- Kuninori Morimoto ------------------------------------------------------------------------------ Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account! http://www2.precog.com/precogplatform/slashdotnewsletter
Hi Grant ping ? > Hi Grant > > Could you please teach me current status of this patch ? > > > On Thu, Apr 04, 2013 at 10:26:42PM -0700, Kuninori Morimoto wrote: > > > Current HSPI driver is using msleep(20) on hspi_status_check_timeout(), > > > but it was too long delay for SPI device. > > > Bock-W board SPI access was too slow without this patch. > > > This patch uses udelay(10) for it. > > > > > > Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > > > > Acked-by: Simon Horman <horms+renesas@verge.net.au> > > > > Grant, can you take this patch? > > > > > --- > > > drivers/spi/spi-sh-hspi.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c > > > index 60cfae5..eab593e 100644 > > > --- a/drivers/spi/spi-sh-hspi.c > > > +++ b/drivers/spi/spi-sh-hspi.c > > > @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) > > > if ((mask & hspi_read(hspi, SPSR)) == val) > > > return 0; > > > > > > - msleep(20); > > > + udelay(10); > > > } > > > > > > dev_err(hspi->dev, "timeout\n"); > > > -- > > > 1.7.9.5 > > > > > > Best regards > --- > Kuninori Morimoto Best regards --- Kuninori Morimoto ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. This 200-page book is written by three acclaimed leaders in the field. The early access version is available now. Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
diff --git a/drivers/spi/spi-sh-hspi.c b/drivers/spi/spi-sh-hspi.c index 60cfae5..eab593e 100644 --- a/drivers/spi/spi-sh-hspi.c +++ b/drivers/spi/spi-sh-hspi.c @@ -89,7 +89,7 @@ static int hspi_status_check_timeout(struct hspi_priv *hspi, u32 mask, u32 val) if ((mask & hspi_read(hspi, SPSR)) == val) return 0; - msleep(20); + udelay(10); } dev_err(hspi->dev, "timeout\n");