| Message ID | 1365179481.1830.69.camel@x61.thuisdomein (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be > any nfc code that uses a DEBUG macro. This line can safely be removed. [] > diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile [] > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG pr_debug/dev_dbg/nfc_dev_dbg logging messages depend on this. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > depend on this. Thanks. But then a NFC_DEBUG symbol needs to be added, because now the DEBUG macro will never be set, won't it? Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: > On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > > depend on this. > > Thanks. But then a NFC_DEBUG symbol needs to be added, because now the > DEBUG macro will never be set, won't it? Probably right. I think all the nfc_dev_<level> uses are unsightly too. Almost all the nfc_dev_dbg uses are functdion enter/leave logging and should be done via the function tracer. I'll submit some patches for that. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Fix some defects in the logging too Joe Perches (3): nfc: Replace nfc_dev_dbg with dev_dbg, remove function tracing nfc: Convert nfc_dev_info and nfc_dev_err to nfc_<level> nfc: Standardize logging style drivers/nfc/microread/i2c.c | 32 ++--- drivers/nfc/microread/mei.c | 20 +-- drivers/nfc/microread/microread.c | 7 +- drivers/nfc/nfcwilink.c | 95 ++++++------- drivers/nfc/pn533.c | 271 ++++++++++++++++---------------------- drivers/nfc/pn544/i2c.c | 38 +++--- drivers/nfc/pn544/pn544.c | 13 +- include/net/nfc/nfc.h | 5 +- 8 files changed, 196 insertions(+), 285 deletions(-)
Hi Joe, On Fri, Apr 05, 2013 at 12:27:36PM -0700, Joe Perches wrote: > Fix some defects in the logging too > > Joe Perches (3): > nfc: Replace nfc_dev_dbg with dev_dbg, remove function tracing > nfc: Convert nfc_dev_info and nfc_dev_err to nfc_<level> > nfc: Standardize logging style All 3 patches applied, sorry for missing those ones. Cheers, Samuel.
diff --git a/drivers/nfc/Makefile b/drivers/nfc/Makefile index a189ada0..5b4ad00 100644 --- a/drivers/nfc/Makefile +++ b/drivers/nfc/Makefile @@ -6,5 +6,3 @@ obj-$(CONFIG_NFC_PN544) += pn544/ obj-$(CONFIG_NFC_MICROREAD) += microread/ obj-$(CONFIG_NFC_PN533) += pn533.o obj-$(CONFIG_NFC_WILINK) += nfcwilink.o - -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG
There's no Kconfig symbol NFC_DEBUG. Besides, there doesn't seem to be any nfc code that uses a DEBUG macro. This line can safely be removed. Signed-off-by: Paul Bolle <pebolle@tiscali.nl> --- Untested. drivers/nfc/Makefile | 2 -- 1 file changed, 2 deletions(-)